Changing the value of a MutableStateFlow if there is a collectAsState().value present in an open composable function and that function is called from a child's overriding function causes an exception to occur. [254292974]

Duplicate

of 165812010

Bug

Status Update

No update yet.

Description

mi...@gmail.com

created issue #1

Oct 18, 2022 05:54PM

lmao

Tested on compose versions 1.1.1 and 1.3.0-rc01

Basically:

have some open class, let's call it OpenClass
have some MutableStateFlow of any type, anywhere in the code such that it can be accessed by OpenClass, let's call it flow
have some open Composable function in OpenClass which has flow.collectAsState().value somewhere inside it, let's call it PeskyFun Also, it will not work if it's inside of specific lambda functions of specific composables, for example: Row { flow.collectAsState().value } will trigger this, but Button(onClick = {...}) { flow.collectAsState().value } will not.
have some class whose super class is OpenClass, let's call it ChildClass
have ChildClass override PeskyFun and call super.PeskyFun() somewhere inside it, doesn't matter where (as long as it's called)
have an instance of ChildClass and call PeskyFun somewhere
change the value of flow
profit (the app will crash with some exception, which one wildly depends on the execution)

Example:

    override fun onCreate(savedInstanceState: Bundle?) {
        super.onCreate(savedInstanceState)

        val b = ChildClass()

        setContent {
            MaterialTheme {
                Column(modifier = Modifier.fillMaxSize()) {
                    b.PeskyFun()
                    Button(onClick = { flow.value-- }) { Text("dec") } // <- The Button
                }
            }
        }
    }
}

val flow = MutableStateFlow(0)

open class OpenClass {

    @Composable
    open fun PeskyFun() {
        flow.collectAsState().value
    }
}

class ChildClass : OpenClass() {

    @Composable
    override fun PeskyFun() {
        super.PeskyFun()
    }
}```

Pressing The Button crashes with this exception:

```androidx.compose.runtime.ComposeRuntimeError: Compose Runtime internal error. Unexpected or incorrect use of the Compose internal runtime API (Cannot skip the enclosing group while in an empty region). Please report to Google or use https://goo.gle/compose-feedback
        at androidx.compose.runtime.ComposerKt.composeRuntimeError(Composer.kt:4383)
        at androidx.compose.runtime.SlotReader.skipToGroupEnd(SlotTable.kt:3443)
        at androidx.compose.runtime.ComposerImpl.skipReaderToGroupEnd(Composer.kt:2651)
        at androidx.compose.runtime.ComposerImpl.skipToGroupEnd(Composer.kt:2664)
        at androidx.compose.material3.ButtonKt.Button(Button.kt:952)
        at androidx.compose.material3.ButtonKt$Button$3.invoke(Unknown Source:27)
        at androidx.compose.material3.ButtonKt$Button$3.invoke(Unknown Source:10)
        at androidx.compose.runtime.RecomposeScopeImpl.compose(RecomposeScopeImpl.kt:145)
        at androidx.compose.runtime.ComposerImpl.recomposeToGroupEnd(Composer.kt:2375)
        at androidx.compose.runtime.ComposerImpl.skipCurrentGroup(Composer.kt:2643)
        at androidx.compose.runtime.ComposerImpl$doCompose$2$5.invoke(Composer.kt:3260)
        at androidx.compose.runtime.ComposerImpl$doCompose$2$5.invoke(Composer.kt:3238)
        at androidx.compose.runtime.SnapshotStateKt__DerivedStateKt.observeDerivedStateRecalculations(DerivedState.kt:341)
        at androidx.compose.runtime.SnapshotStateKt.observeDerivedStateRecalculations(Unknown Source:1)
        at androidx.compose.runtime.ComposerImpl.doCompose(Composer.kt:3238)
        at androidx.compose.runtime.ComposerImpl.recompose$runtime_release(Composer.kt:3203)
        at androidx.compose.runtime.CompositionImpl.recompose(Composition.kt:771)
        at androidx.compose.runtime.Recomposer.performRecompose(Recomposer.kt:1031)
        at androidx.compose.runtime.Recomposer.access$performRecompose(Recomposer.kt:125)
        at androidx.compose.runtime.Recomposer$runRecomposeAndApplyChanges$2$2.invoke(Recomposer.kt:534)
        at androidx.compose.runtime.Recomposer$runRecomposeAndApplyChanges$2$2.invoke(Recomposer.kt:503)
        at androidx.compose.ui.platform.AndroidUiFrameClock$withFrameNanos$2$callback$1.doFrame(AndroidUiFrameClock.android.kt:34)
        at androidx.compose.ui.platform.AndroidUiDispatcher.performFrameDispatch(AndroidUiDispatcher.android.kt:109)
        at androidx.compose.ui.platform.AndroidUiDispatcher.access$performFrameDispatch(AndroidUiDispatcher.android.kt:41)
        at androidx.compose.ui.platform.AndroidUiDispatcher$dispatchCallback$1.doFrame(AndroidUiDispatcher.android.kt:69)
        at android.view.Choreographer$CallbackRecord.run(Choreographer.java:1035)
        at android.view.Choreographer.doCallbacks(Choreographer.java:845)
        at android.view.Choreographer.doFrame(Choreographer.java:775)
        at android.view.Choreographer$FrameDisplayEventReceiver.run(Choreographer.java:1022)
        at android.os.Handler.handleCallback(Handler.java:938)
        at android.os.Handler.dispatchMessage(Handler.java:99)
        at android.os.Looper.loopOnce(Looper.java:201)
        at android.os.Looper.loop(Looper.java:288)
        at android.app.ActivityThread.main(ActivityThread.java:7839)
        at java.lang.reflect.Method.invoke(Native Method)
        at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:548)
        at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1003)
    	Suppressed: kotlinx.coroutines.DiagnosticCoroutineContextException: [androidx.compose.runtime.PausableMonotonicFrameClock@5c87e75, androidx.compose.ui.platform.MotionDurationScaleImpl@63ae0a, StandaloneCoroutine{Cancelling}@f34567b, AndroidUiDispatcher@9c47c98]```

Example:
```class MainActivity : ComponentActivity() {
    override fun onCreate(savedInstanceState: Bundle?) {
        super.onCreate(savedInstanceState)

        val b = ChildClass()

        setContent {
            MaterialTheme {
                Column(modifier = Modifier.fillMaxSize()) {
                    b.PeskyFun()
                }
            }
        }
    }
}

val flow = MutableStateFlow(0)

open class OpenClass {

    @Composable
    open fun PeskyFun() {
        flow.collectAsState().value
        Button(onClick = { flow.value-- }) { Text("dec") } // <- The Dec Button
    }
}

class ChildClass : OpenClass() {

    @Composable
    override fun PeskyFun() = Column {
        super.PeskyFun()
        Button(onClick = { flow.value++ }) { Text("inc") } // <- The Inc Button
    }
}```

Pressing The Dec Button crashes with this exception:

```java.lang.ArrayIndexOutOfBoundsException: src.length=16 srcPos=2 dst.length=16 dstPos=1 length=-1
        at java.lang.System.arraycopy(Native Method)
        at kotlin.collections.ArraysKt___ArraysJvmKt.copyInto(_ArraysJvm.kt:1247)
        at androidx.compose.runtime.collection.MutableVector.removeAt(MutableVector.kt:795)
        at androidx.compose.ui.node.MutableVectorWithMutationTracking.removeAt(MutableVectorWithMutationTracking.kt:43)
        at androidx.compose.ui.node.LayoutNode.removeAt$ui_release(LayoutNode.kt:287)
        at androidx.compose.ui.node.UiApplier.remove(UiApplier.android.kt:35)
        at androidx.compose.runtime.ComposerImpl$realizeMovement$1.invoke(Composer.kt:3769)
        at androidx.compose.runtime.ComposerImpl$realizeMovement$1.invoke(Composer.kt:3769)
        at androidx.compose.runtime.CompositionImpl.applyChangesInLocked(Composition.kt:808)
        at androidx.compose.runtime.CompositionImpl.applyChanges(Composition.kt:839)
        at androidx.compose.runtime.Recomposer$runRecomposeAndApplyChanges$2$2.invoke(Recomposer.kt:585)
        at androidx.compose.runtime.Recomposer$runRecomposeAndApplyChanges$2$2.invoke(Recomposer.kt:503)
        at androidx.compose.ui.platform.AndroidUiFrameClock$withFrameNanos$2$callback$1.doFrame(AndroidUiFrameClock.android.kt:34)
        at androidx.compose.ui.platform.AndroidUiDispatcher.performFrameDispatch(AndroidUiDispatcher.android.kt:109)
        at androidx.compose.ui.platform.AndroidUiDispatcher.access$performFrameDispatch(AndroidUiDispatcher.android.kt:41)
        at androidx.compose.ui.platform.AndroidUiDispatcher$dispatchCallback$1.doFrame(AndroidUiDispatcher.android.kt:69)
        at android.view.Choreographer$CallbackRecord.run(Choreographer.java:1035)
        at android.view.Choreographer.doCallbacks(Choreographer.java:845)
        at android.view.Choreographer.doFrame(Choreographer.java:775)
        at android.view.Choreographer$FrameDisplayEventReceiver.run(Choreographer.java:1022)
        at android.os.Handler.handleCallback(Handler.java:938)
        at android.os.Handler.dispatchMessage(Handler.java:99)
        at android.os.Looper.loopOnce(Looper.java:201)
        at android.os.Looper.loop(Looper.java:288)
        at android.app.ActivityThread.main(ActivityThread.java:7839)
        at java.lang.reflect.Method.invoke(Native Method)
        at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:548)
        at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1003)
    	Suppressed: kotlinx.coroutines.DiagnosticCoroutineContextException: [androidx.compose.runtime.PausableMonotonicFrameClock@62fbc84, androidx.compose.ui.platform.MotionDurationScaleImpl@fdbac6d, StandaloneCoroutine{Cancelling}@85fd0a2, AndroidUiDispatcher@1a96133]```

But, pressing The Inc Button crashes with this exception:

```java.lang.ArrayIndexOutOfBoundsException: length=10240; index=10243
        at androidx.compose.runtime.SlotTableKt.groupSize(SlotTable.kt:3251)
        at androidx.compose.runtime.SlotTableKt.access$groupSize(SlotTable.kt:1)
        at androidx.compose.runtime.SlotWriter.moveGroup(SlotTable.kt:1843)
        at androidx.compose.runtime.ComposerImpl$start$2.invoke(Composer.kt:2100)
        at androidx.compose.runtime.ComposerImpl$start$2.invoke(Composer.kt:2099)
        at androidx.compose.runtime.CompositionImpl.applyChangesInLocked(Composition.kt:808)
        at androidx.compose.runtime.CompositionImpl.applyChanges(Composition.kt:839)
        at androidx.compose.runtime.Recomposer$runRecomposeAndApplyChanges$2$2.invoke(Recomposer.kt:585)
        at androidx.compose.runtime.Recomposer$runRecomposeAndApplyChanges$2$2.invoke(Recomposer.kt:503)
        at androidx.compose.ui.platform.AndroidUiFrameClock$withFrameNanos$2$callback$1.doFrame(AndroidUiFrameClock.android.kt:34)
        at androidx.compose.ui.platform.AndroidUiDispatcher.performFrameDispatch(AndroidUiDispatcher.android.kt:109)
        at androidx.compose.ui.platform.AndroidUiDispatcher.access$performFrameDispatch(AndroidUiDispatcher.android.kt:41)
        at androidx.compose.ui.platform.AndroidUiDispatcher$dispatchCallback$1.doFrame(AndroidUiDispatcher.android.kt:69)
        at android.view.Choreographer$CallbackRecord.run(Choreographer.java:1035)
        at android.view.Choreographer.doCallbacks(Choreographer.java:845)
        at android.view.Choreographer.doFrame(Choreographer.java:775)
        at android.view.Choreographer$FrameDisplayEventReceiver.run(Choreographer.java:1022)
        at android.os.Handler.handleCallback(Handler.java:938)
        at android.os.Handler.dispatchMessage(Handler.java:99)
        at android.os.Looper.loopOnce(Looper.java:201)
        at android.os.Looper.loop(Looper.java:288)
        at android.app.ActivityThread.main(ActivityThread.java:7839)
        at java.lang.reflect.Method.invoke(Native Method)
        at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:548)
        at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1003)
    	Suppressed: kotlinx.coroutines.DiagnosticCoroutineContextException: [androidx.compose.runtime.PausableMonotonicFrameClock@653fe9a, androidx.compose.ui.platform.MotionDurationScaleImpl@e7283cb, StandaloneCoroutine{Cancelling}@4ec27a8, AndroidUiDispatcher@9242c1]```

The flow does not need to be of Int type, example:
```class MainActivity : ComponentActivity() {
    override fun onCreate(savedInstanceState: Bundle?) {
        super.onCreate(savedInstanceState)

        val b = ChildClass()

        setContent {
            MaterialTheme {
                Column(modifier = Modifier.fillMaxSize()) {
                    b.PeskyFun()
                    Checkbox(
                        checked = flow.collectAsState().value, // <- The Checkbox
                        onCheckedChange = { flow.value = it }
                    )
                }
            }
        }
    }
}

val flow = MutableStateFlow(false) // can also start as true, the same thing will happen

open class OpenClass {

    @Composable
    open fun PeskyFun() {
        if (flow.collectAsState().value) {
            Text("Hello")
        }
    }
}

class ChildClass : OpenClass() {

    @Composable
    override fun PeskyFun() = Column {
        super.PeskyFun()
    }
}```

Checking The Checkbox crashes with this exception:

```androidx.compose.runtime.ComposeRuntimeError: Compose Runtime internal error. Unexpected or incorrect use of the Compose internal runtime API (Expected to be at the end of a group). Please report to Google or use https://goo.gle/compose-feedback
        at androidx.compose.runtime.ComposerKt.composeRuntimeError(Composer.kt:4383)
        at androidx.compose.runtime.SlotWriter.endGroup(SlotTable.kt:3488)
        at androidx.compose.runtime.ComposerKt$endGroupInstance$1.invoke(Composer.kt:4303)
        at androidx.compose.runtime.ComposerKt$endGroupInstance$1.invoke(Composer.kt:4303)
        at androidx.compose.runtime.CompositionImpl.applyChangesInLocked(Composition.kt:808)
        at androidx.compose.runtime.CompositionImpl.applyChanges(Composition.kt:839)
        at androidx.compose.runtime.Recomposer$runRecomposeAndApplyChanges$2$2.invoke(Recomposer.kt:585)
        at androidx.compose.runtime.Recomposer$runRecomposeAndApplyChanges$2$2.invoke(Recomposer.kt:503)
        at androidx.compose.ui.platform.AndroidUiFrameClock$withFrameNanos$2$callback$1.doFrame(AndroidUiFrameClock.android.kt:34)
        at androidx.compose.ui.platform.AndroidUiDispatcher.performFrameDispatch(AndroidUiDispatcher.android.kt:109)
        at androidx.compose.ui.platform.AndroidUiDispatcher.access$performFrameDispatch(AndroidUiDispatcher.android.kt:41)
        at androidx.compose.ui.platform.AndroidUiDispatcher$dispatchCallback$1.doFrame(AndroidUiDispatcher.android.kt:69)
        at android.view.Choreographer$CallbackRecord.run(Choreographer.java:1035)
        at android.view.Choreographer.doCallbacks(Choreographer.java:845)
        at android.view.Choreographer.doFrame(Choreographer.java:775)
        at android.view.Choreographer$FrameDisplayEventReceiver.run(Choreographer.java:1022)
        at android.os.Handler.handleCallback(Handler.java:938)
        at android.os.Handler.dispatchMessage(Handler.java:99)
        at android.os.Looper.loopOnce(Looper.java:201)
        at android.os.Looper.loop(Looper.java:288)
        at android.app.ActivityThread.main(ActivityThread.java:7839)
        at java.lang.reflect.Method.invoke(Native Method)
        at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:548)
        at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1003)
    	Suppressed: kotlinx.coroutines.DiagnosticCoroutineContextException: [androidx.compose.runtime.PausableMonotonicFrameClock@3f3aa40, androidx.compose.ui.platform.MotionDurationScaleImpl@a1f2d79, StandaloneCoroutine{Cancelling}@3b76abe, AndroidUiDispatcher@492871f]```

and so forth...
Also, as mentioned before, if the flow.collectAsState().value statement is in a specific Composable function, the crash will not occur.

For example if the PeskyFun is defined as follow:
```@Composable
open fun PeskyFun() {
   Button(onClick = { }) {
       Text(flow.collectAsState().value.toString())
   }
}```
This will not crash.
Furthermore, fetching the value of the collected state is what causes the crashes.
For example:
```@Composable
open fun PeskyFun() {
   val state = flow.collectAsState()
   //state.value // <- uncommenting this value WILL cause a crash to happen
   Button(onClick = { }) {
       //state.value // <- uncommenting this value will NOT cause a crash to happen
   }
}```

Thank you Jetpack Compose, very cool!

Comments

le...@google.com <le...@google.com> Oct 21, 2022 01:19PM

Assigned to je...@google.com.

ch...@google.com <ch...@google.com> Apr 4, 2023 08:16PM

Reassigned to ch...@google.com.

ch...@google.com <ch...@google.com> #2Apr 4, 2023 10:29PM

Reassigned to le...@google.com.

Could we get an official response to this feature request? Is there an idea to support SafeArgs in navigation-compose one day? Not asking for any time frames. Maybe there is no plans for statically generated args for navigation-compose at all.

al...@google.com <al...@google.com> #3Dec 19, 2024 09:30PM

Reassigned to ch...@google.com.

Please check out my implementation of the same-

Part 1-

https://proandroiddev.com/safe-compose-arguments-an-improved-way-to-navigate-in-jetpack-compose-95c84722eec2

Part 2-

https://proandroiddev.com/safe-compose-arguments-an-improved-way-to-navigate-in-jetpack-compose-part-2-218a6ae7a027

Github repo-

https://github.com/dilrajsingh1997/safe-compose-args

ch...@google.com <ch...@google.com> Jan 10, 2025 10:27PM

Reassigned to as...@google.com.

as...@google.com <as...@google.com> #4Jan 15, 2025 12:56PM

Status: Duplicate of

165812010

Integration guide-

https://proandroiddev.com/safe-compose-arguments-an-improved-way-to-navigate-in-jetpack-compose-part-3-2e5ab79b9a05

Issue 254292974