com.intellij.diagnostic.PluginException: 345 ms to call on EDT DeviceAndSnapshotComboBoxAction#update@NavBarToolbar [258484267]

Fixed

Bug

Status Update

No update yet.

Description

ne...@jetbrains.com

created issue #1

Nov 10, 2022 10:36AM

DESCRIOTION:

DeviceAndSnapshotComboBoxAction action's update method does too much work on EDT and exceeds 300ms threshold.

PluginException stacktrace is provided in attachment.

stacktrace.txt

5.2 KB

View

Download

Comments

gh...@google.com <gh...@google.com> Nov 10, 2022 04:46PM

Assigned to an...@google.com.

gh...@google.com <gh...@google.com> #2Nov 10, 2022 06:06PM

Flagging this bug as a good one to investigate, because JetBrains has seen this exception a lot. Also note that, AFAIK, you may be able to override getActionUpdateThread to move this work to a background thread, if applicable.

Message last modified on Nov 10, 2022 06:35PM

gh...@google.com <gh...@google.com> #3Nov 10, 2022 06:07PM

Will flag this for Giraffe for now — just to make sure we investigate this a bit more. It is possible that DeviceAndSnapshotComboBoxAction is causing frequent short UI freezes for users.

rp...@google.com <rp...@google.com> #4Nov 10, 2022 06:32PM

Reassigned to ju...@google.com.

Marking as P1 to ensure we investigate... Depending on the actual issue, we may lower P.

ju...@google.com <ju...@google.com> #5Nov 10, 2022 11:47PM

Accepted by ju...@google.com.

I've resorted to pouring over the code and looking for anything suspicious

I found this. That's a blocking get on the EDT.

ju...@google.com <ju...@google.com> #6Nov 11, 2022 12:00AM

Oh, and I feel P1 is quite appropriate

ju...@google.com <ju...@google.com> Jan 12, 2023 12:10AM

Marked as fixed.

sa...@google.com <sa...@google.com> #7Jan 17, 2023 08:26PM

Thank you for your patience while our engineering team worked to resolve this issue. A fix for this issue is now available in:

Android Studio Giraffe Canary 1 (2022.3.1.1)
Android Gradle Plugin 8.1.0

We encourage you to try the latest update.

If you notice further issues or have questions, please file a new bug report.

Thank you for taking the time to submit feedback — we really appreciate it!