AGP 7.4.0-rc01 breaks Variant API with "Querying the mapped value of map(provider(java.util.Set)) before task '...' has completed is not supported" [261329823]

Fixed

Bug

Status Update

No update yet.

Description

nc...@meta.com

created issue #1

Dec 5, 2022 01:43PM

This bug should be moved under:
> Android Public Tracker > App Development > Android Studio > Gradle > Android Gradle Plugin
but I don't have permission to do so.

## Expected Result

AGP Variant API works well between 7.4.0-beta05 and 7.4.0-rc01

## Observed Results

Bumping AGP from 7.4.0-beta05 to 7.4.0-rc01 results in a build failure with the following message:

```
> Task :example:mapDebugSourceSetPaths FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':example:mapDebugSourceSetPaths'.
> Querying the mapped value of map(provider(java.util.Set)) before task ':example:reproducerdebugTask' has completed is not supported
```

It seems like AGP is querying the value of the `@OutputDirectory` of the task I created `example:reproducerdebugTask`.

## Reproducer

You can find a small reproducer here:

https://github.com/cortinico/reproducer-agp-74rc01

Specifically this commit shows a working setup with AGP 7.4 beta5
-

https://github.com/cortinico/reproducer-agp-74rc01/commit/89ad099f44ecbb2bed53ece979c2f1bd241fe31f

Bumping to RC01 causes the failure:
-

https://github.com/cortinico/reproducer-agp-74rc01/commit/6fc570e9492b4413a013d9031aba5ceb80f08a65

I've also configured the CI so you have a clean environment where you can easily reproduce.
The command to reproduce upon cloning is `./gradlew :example:assembleDebug`.

## Further Context

This issue was noticed upstream on React Native here:

https://github.com/facebook/react-native/pull/35522
as we're using a similar pattern inside the React Native Gradle Plugin.

Comments

vi...@google.com <vi...@google.com> Dec 5, 2022 01:50PM

Status: New

ga...@google.com <ga...@google.com> #2Dec 5, 2022 06:42PM

Assigned to je...@google.com.

Retraced stack trace:

Caused by: java.lang.UnsupportedOperationException: Operation is not supported for read-only collection
	at com.android.tools.r8.jetbrains.kotlin.collections.EmptyList.removeAll(Collections.kt)
	at com.android.tools.r8.resourceshrinker.r8integration.LegacyResourceShrinker.run(LegacyResourceShrinker.java:228)
	at com.android.tools.r8.R8.shrinkResources(R8.java:991)
	at com.android.tools.r8.R8.runInternal(R8.java:894)
	at com.android.tools.r8.R8.runInternal(R8.java:259)
	at com.android.tools.r8.R8.lambda$runForTesting$1(R8.java:243)
	at com.android.tools.r8.internal.Nu.a(R8_8.9.27_3afcc9fea5cc5cd06373667ec09d5fe106db8a4a77576689534e667542385a93:28

je...@google.com <je...@google.com> Dec 5, 2022 07:32PM

Accepted by je...@google.com.

je...@google.com <je...@google.com> #3Dec 6, 2022 05:57PM

Marked as fixed.

This is happening when there are no unused resources at all and we have duplicated resources between the feature and base (or different features)

Reproduction here: https://r8-review.git.corp.google.com/c/r8/+/102418

Fix here: https://r8-review.git.corp.google.com/c/r8/+/102626

For the reporter to work around this:

Disable resource shrinking in this case, it will have no effect since there are no unused resources for this build
Use legacy AGP embedded shrinker - set android.r8.integratedResourceShrinking false in your settings
Manually update to a new R8 version (I will post a follow up when this is on our release branch)

nc...@meta.com <nc...@meta.com> #4Dec 6, 2022 06:16PM

Thanks!

je...@google.com <je...@google.com> #5Dec 6, 2022 06:30PM

Project: r8
Branch: main
Author: Rico Wind <ricow@google.com>
Link: https://r8-review.googlesource.com/102626

Fix usage of Immutable list in resource shrinker

Expand for full commit details

Fix usage of Immutable list in resource shrinker 
 
The returned list is mutable unless it is empty, allways create a copy. 
 
Bug: b/401546693 
Change-Id: I9ea50d23c365ea59e1f6ae5e13a02048daa8b5f8

Files:

M src/resourceshrinker/java/com/android/build/shrinker/r8integration/LegacyResourceShrinker.java
M src/test/java/com/android/tools/r8/androidresources/DuplicatedEntriesEmptyUnusedTest.java

Hash: dc5cae852ee11d42456d275afb1837d1f770306f
Date: Mon Mar 10 17:56:18 2025

[Deleted User] <[Deleted User]> #6Dec 8, 2022 02:00PM

Project: r8
Branch: main
Author: Rico Wind <ricow@google.com>
Link: https://r8-review.googlesource.com/102418

Add reproduction of adding to immutable list in resource shrinker

Expand for full commit details

Add reproduction of adding to immutable list in resource shrinker 
 
This happens if the list returned from the model is empty, in which case it is immutable 
 
Bug: b/401546693 
Change-Id: Ib596242df6e3299f19ff00a03dbe43bde79e13c0

Files:

A src/test/java/com/android/tools/r8/androidresources/DuplicatedEntriesEmptyUnusedTest.java

Hash: 429ddad6ffce418ebaf482277ee8e96a68ab18e4
Date: Mon Mar 10 17:51:07 2025

le...@gmail.com <le...@gmail.com> #7Dec 8, 2022 02:16PM

Project: r8
Branch: 8.9
Author: Rico Wind <ricow@google.com>
Link: https://r8-review.googlesource.com/102641

Add reproduction of adding to immutable list in resource shrinker

Expand for full commit details

Add reproduction of adding to immutable list in resource shrinker 
 
This happens if the list returned from the model is empty, in which case it is immutable 
 
Bug: b/401546693 
Change-Id: Ib596242df6e3299f19ff00a03dbe43bde79e13c0

Files:

A src/test/java/com/android/tools/r8/androidresources/DuplicatedEntriesEmptyUnusedTest.java

Hash: 2f90d4133d2af07c954dceddb1ae47cc28e7b9d8
Date: Tue Mar 11 10:54:07 2025

ca...@gmail.com <ca...@gmail.com> #8Dec 15, 2022 08:14PM

Project: r8
Branch: 8.9
Author: Rico Wind <ricow@google.com>
Link: https://r8-review.googlesource.com/102664

Fix usage of Immutable list in resource shrinker

Expand for full commit details

Fix usage of Immutable list in resource shrinker 
 
The returned list is mutable unless it is empty, allways create a copy. 
 
Bug: b/401546693 
Change-Id: I9ea50d23c365ea59e1f6ae5e13a02048daa8b5f8

Files:

M src/resourceshrinker/java/com/android/build/shrinker/r8integration/LegacyResourceShrinker.java
M src/test/java/com/android/tools/r8/androidresources/DuplicatedEntriesEmptyUnusedTest.java

Hash: 5e687ec23a4cdb897cbd2cdccc75ff956d99c88c
Date: Tue Mar 11 10:54:12 2025

je...@google.com <je...@google.com> #9Dec 16, 2022 05:49PM

Project: r8
Branch: 8.9
Author: Rico Wind <ricow@google.com>
Link: https://r8-review.googlesource.com/102642

Version 8.9.32

Expand for full commit details

Version 8.9.32 
 
Bug: b/401546693 
Change-Id: Ibed0928d2ac5c2b649516ce2a4918ad04da0b0e7

Files:

M src/main/java/com/android/tools/r8/Version.java

Hash: 3daff1971b739cc421cbc79ff63f8e54cf3ae2ed
Date: Tue Mar 11 10:54:18 2025

nc...@meta.com <nc...@meta.com> #10Dec 22, 2022 12:55PM

As a follow up to the last comment, you can try version 8.9.32 with the instructions from here:

https://r8.googlesource.com/r8/+/refs/heads/main#replacing-r8-in-agp

That should make the compilation succeed

ga...@google.com <ga...@google.com> Dec 22, 2022 01:13PM

Status: Assigned (reopened)

xa...@google.com <xa...@google.com> #11Dec 22, 2022 05:11PM

Project: r8
Branch: 8.10
Author: Rico Wind <ricow@google.com>
Link: https://r8-review.googlesource.com/102663

Version 8.10.17

Expand for full commit details

Version 8.10.17 
 
Bug: b/401546693 
Change-Id: I0f46c848db5653a9a7728f6f38ab305ac1dac80d

Files:

M src/main/java/com/android/tools/r8/Version.java

Hash: 5cb0d6c73b79a70b23b4717529431e18e2501c7a
Date: Tue Mar 11 10:53:16 2025

ga...@google.com <ga...@google.com> #12Dec 23, 2022 05:28PM

Marked as fixed.

Project: r8
Branch: 8.10
Author: Rico Wind <ricow@google.com>
Link: https://r8-review.googlesource.com/102661

Add reproduction of adding to immutable list in resource shrinker

Expand for full commit details

Add reproduction of adding to immutable list in resource shrinker 
 
This happens if the list returned from the model is empty, in which case it is immutable 
 
Bug: b/401546693 
Change-Id: Ib596242df6e3299f19ff00a03dbe43bde79e13c0

Files:

A src/test/java/com/android/tools/r8/androidresources/DuplicatedEntriesEmptyUnusedTest.java

Hash: 3867edebfc19c949d55427b1f1774ba25539646e
Date: Tue Mar 11 10:53:02 2025

pe...@gmail.com <pe...@gmail.com> #13Dec 29, 2022 12:11PM

Project: r8
Branch: 8.10
Author: Rico Wind <ricow@google.com>
Link: https://r8-review.googlesource.com/102662

Fix usage of Immutable list in resource shrinker

Expand for full commit details

Fix usage of Immutable list in resource shrinker 
 
The returned list is mutable unless it is empty, allways create a copy. 
 
Bug: b/401546693 
Change-Id: I9ea50d23c365ea59e1f6ae5e13a02048daa8b5f8

Files:

M src/resourceshrinker/java/com/android/build/shrinker/r8integration/LegacyResourceShrinker.java
M src/test/java/com/android/tools/r8/androidresources/DuplicatedEntriesEmptyUnusedTest.java

Hash: d3cabf6667451e51d1d2edec5443ecaaadfbea01
Date: Tue Mar 11 10:53:09 2025

ro...@sentry.io <ro...@sentry.io> #14Jan 13, 2023 12:19AM

Thank you for your patience while our engineering team worked to resolve this issue. A fix for this issue is now available in:

Android Studio Meerkat Feature Drop | 2024.3.2 Beta 1
Android Gradle Plugin 8.10.0-beta01

We encourage you to try the latest update.

If you notice further issues or have questions, please file a new bug report.

Thank you for taking the time to submit feedback — we really appreciate it!

Message last modified on Jan 13, 2023 12:20AM

nc...@meta.com <nc...@meta.com> #15Jan 13, 2023 12:50AM

The fixes for this issue are now also available in:

Android Studio Meerkat | 2024.3.1 Patch 1
Android Gradle Plugin 8.9.1

We encourage you to try the latest update.

If you notice further issues or have questions, please file a new bug report.

pe...@gmail.com <pe...@gmail.com> #16Jan 13, 2023 01:15PM

Thanks very much for the regular updates. I just tried it out and it works for me.

ha...@gmail.com <ha...@gmail.com> #17Jan 24, 2023 09:25AM

je...@google.com <je...@google.com> #18Jan 24, 2023 05:43PM

My IDE is not allowing me select keystore location when i want to generate signed APK. I am using Android Studio Meerkat | 2024.3.1 Patch 1

[Deleted User] <[Deleted User]> #19Feb 2, 2023 08:27AM

Comment #18 please file a separate bug.

Message last modified on Feb 2, 2023 08:29AM

nc...@meta.com <nc...@meta.com> #20Feb 2, 2023 02:37PM

Actually the issue looks like fixed on our end. We're bumping React Native to use AGP 7.4.1 and the addGeneratedSourceDirectory API here: https://github.com/facebook/react-native/pull/36039

Thanks for working on this folks even if it took longer to land than expected

je...@google.com <je...@google.com> #21Feb 2, 2023 06:01PM

#19, I am sorry, there was a misunderstanding with the release team. they had an even more urgent fix to push which was 7.4.1 and the normal dot release that contains this fix got pushed to 7.4.2 which is looking to be couple of weeks away (still working the date with them). So sorry for the wrong info, It surprised me too.

nc...@meta.com <nc...@meta.com> #22Feb 2, 2023 06:30PM

That's confusing as the issue seems effectively fixed in 7.4.1, also in the reproducer I linked: https://github.com/cortinico/reproducer-agp-74rc01

pe...@gmail.com <pe...@gmail.com> #23Feb 2, 2023 07:06PM

I tested some more today. First I got the error like mentioned in #19 (looked like it at least), and 2 hours later it seemed to build, at least the app was deployed on the emulator.
For a workmate it also failed on his first try. We might see tomorrow.
Not sure yet, but it might be flaky now, depending on some cache or other internals.

I'll report back if I know more but it's good to know about the new target of 7.4.2. Really sad this kind of thing can't make it into a .0 release as prio 0 bug, especially since it *was* ready.
Maybe you guys can take this as a feedback and improve something, feels like it just hit a process / politics wall.

ar...@gmail.com <ar...@gmail.com> #24Mar 7, 2023 12:45PM

This still seems to be plaguing 7.4.2 as well

je...@google.com <je...@google.com> #25Mar 7, 2023 10:27PM

this might be due to a third party plugin. do you have a small project to reproduce the issue ?

can you provide a stack trace ?

ar...@gmail.com <ar...@gmail.com> #26Mar 14, 2023 05:21AM

my bad, it was due to react native dependencies, had to update those as well

Issue 261329823

Description

Issue summary

Comments

vi...@google.com <vi...@google.com> Dec 5, 2022 01:50PM

ga...@google.com <ga...@google.com> #2Dec 5, 2022 06:42PM

je...@google.com <je...@google.com> Dec 5, 2022 07:32PM

je...@google.com <je...@google.com> #3Dec 6, 2022 05:57PM

nc...@meta.com <nc...@meta.com> #4Dec 6, 2022 06:16PM

je...@google.com <je...@google.com> #5Dec 6, 2022 06:30PM

[Deleted User] <[Deleted User]> #6Dec 8, 2022 02:00PM

le...@gmail.com <le...@gmail.com> #7Dec 8, 2022 02:16PM

ca...@gmail.com <ca...@gmail.com> #8Dec 15, 2022 08:14PM

je...@google.com <je...@google.com> #9Dec 16, 2022 05:49PM

nc...@meta.com <nc...@meta.com> #10Dec 22, 2022 12:55PM

ga...@google.com <ga...@google.com> Dec 22, 2022 01:13PM

xa...@google.com <xa...@google.com> #11Dec 22, 2022 05:11PM

ga...@google.com <ga...@google.com> #12Dec 23, 2022 05:28PM

pe...@gmail.com <pe...@gmail.com> #13Dec 29, 2022 12:11PM

ro...@sentry.io <ro...@sentry.io> #14Jan 13, 2023 12:19AM

nc...@meta.com <nc...@meta.com> #15Jan 13, 2023 12:50AM

pe...@gmail.com <pe...@gmail.com> #16Jan 13, 2023 01:15PM

ha...@gmail.com <ha...@gmail.com> #17Jan 24, 2023 09:25AM

je...@google.com <je...@google.com> #18Jan 24, 2023 05:43PM

[Deleted User] <[Deleted User]> #19Feb 2, 2023 08:27AM

nc...@meta.com <nc...@meta.com> #20Feb 2, 2023 02:37PM

je...@google.com <je...@google.com> #21Feb 2, 2023 06:01PM

nc...@meta.com <nc...@meta.com> #22Feb 2, 2023 06:30PM

pe...@gmail.com <pe...@gmail.com> #23Feb 2, 2023 07:06PM

ar...@gmail.com <ar...@gmail.com> #24Mar 7, 2023 12:45PM

je...@google.com <je...@google.com> #25Mar 7, 2023 10:27PM

ar...@gmail.com <ar...@gmail.com> #26Mar 14, 2023 05:21AM

Add comment

Issue metadata