Drawable com.example.app:drawable/mr_button_dark_static [261878418]

Fixed

Bug

Status Update

No update yet.

Description

bo...@justin.tv

created issue #1

Dec 8, 2022 08:17PM

Component used: androidx.mediarouter Version used: 1.3.1 Devices/Android versions reproduced on:

When reporting bugs, please always include:

We see the following stack trace in Crashlytics, but we can't reproduce the problem locally.

mr_button_dark_static.xml refers to ic_mr_button_connected_30_dark, ic_mr_button_disconnected_dark, and ic_mr_button_disabled_dark.

ic_mr_button_disconnected_dark and ic_mr_button_disabled_dark both have xxhdpi, xhdpi, hdpi, and mdpi versions, but ic_mr_button_connected_30_dark only has xxhdpi and xhdpi versions, so maybe this is the problem?

Fatal Exception: java.lang.RuntimeException: An error occurred while executing doInBackground()
       at android.os.AsyncTask$4.done(AsyncTask.java:415)
       at java.util.concurrent.FutureTask.finishCompletion(FutureTask.java:383)
       at java.util.concurrent.FutureTask.setException(FutureTask.java:252)
       at java.util.concurrent.FutureTask.run(FutureTask.java:271)
       at android.os.AsyncTask$SerialExecutor$1.run(AsyncTask.java:305)
       at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1167)
       at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:641)
       at java.lang.Thread.run(Thread.java:920)
Caused by android.content.res.Resources$NotFoundException: Drawable com.example.app:drawable/mr_button_dark_static with resource ID #0x7f08048b
Caused by android.content.res.Resources$NotFoundException: File res/drawable/mr_button_dark_static.xml from drawable resource ID #0x7f08048b
       at android.content.res.ResourcesImpl.loadDrawableForCookie(ResourcesImpl.java:874)
       at android.content.res.ResourcesImpl.loadDrawable(ResourcesImpl.java:668)
       at android.content.res.Resources.loadDrawable(Resources.java:993)
       at android.content.res.Resources.getDrawableForDensity(Resources.java:983)
       at android.content.res.Resources.getDrawable(Resources.java:922)
       at android.content.Context.getDrawable(Context.java:754)
       at androidx.core.content.ContextCompat$Api21Impl.getDrawable(ContextCompat.java:864)
       at androidx.core.content.ContextCompat.getDrawable(ContextCompat.java:483)
       at androidx.appcompat.widget.ResourceManagerInternal.getDrawable(ResourceManagerInternal.java:148)
       at androidx.appcompat.widget.ResourceManagerInternal.getDrawable(ResourceManagerInternal.java:136)
       at androidx.appcompat.content.res.AppCompatResources.getDrawable(AppCompatResources.java:66)
       at androidx.mediarouter.app.MediaRouteButton$RemoteIndicatorLoader.doInBackground(MediaRouteButton.java:869)
       at androidx.mediarouter.app.MediaRouteButton$RemoteIndicatorLoader.doInBackground(MediaRouteButton.java:856)
       at android.os.AsyncTask$3.call(AsyncTask.java:394)
       at java.util.concurrent.FutureTask.run(FutureTask.java:266)
       at android.os.AsyncTask$SerialExecutor$1.run(AsyncTask.java:305)
       at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1167)
       at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:641)
       at java.lang.Thread.run(Thread.java:920)
Caused by org.xmlpull.v1.XmlPullParserException: Binary XML file line #4: <item> tag requires a 'drawable' attribute or child tag defining a drawable
       at android.graphics.drawable.StateListDrawable.inflateChildElements(StateListDrawable.java:195)
       at android.graphics.drawable.StateListDrawable.inflate(StateListDrawable.java:126)
       at android.graphics.drawable.DrawableInflater.inflateFromXmlForDensity(DrawableInflater.java:145)
       at android.graphics.drawable.Drawable.createFromXmlInnerForDensity(Drawable.java:1399)
       at android.graphics.drawable.Drawable.createFromXmlForDensity(Drawable.java:1358)
       at android.content.res.ResourcesImpl.loadXmlDrawable(ResourcesImpl.java:906)
       at android.content.res.ResourcesImpl.loadDrawableForCookie(ResourcesImpl.java:860)
       at android.content.res.ResourcesImpl.loadDrawable(ResourcesImpl.java:668)
       at android.content.res.Resources.loadDrawable(Resources.java:993)
       at android.content.res.Resources.getDrawableForDensity(Resources.java:983)
       at android.content.res.Resources.getDrawable(Resources.java:922)
       at android.content.Context.getDrawable(Context.java:754)
       at androidx.core.content.ContextCompat$Api21Impl.getDrawable(ContextCompat.java:864)
       at androidx.core.content.ContextCompat.getDrawable(ContextCompat.java:483)
       at androidx.appcompat.widget.ResourceManagerInternal.getDrawable(ResourceManagerInternal.java:148)
       at androidx.appcompat.widget.ResourceManagerInternal.getDrawable(ResourceManagerInternal.java:136)
       at androidx.appcompat.content.res.AppCompatResources.getDrawable(AppCompatResources.java:66)
       at androidx.mediarouter.app.MediaRouteButton$RemoteIndicatorLoader.doInBackground(MediaRouteButton.java:869)
       at androidx.mediarouter.app.MediaRouteButton$RemoteIndicatorLoader.doInBackground(MediaRouteButton.java:856)
       at android.os.AsyncTask$3.call(AsyncTask.java:394)
       at java.util.concurrent.FutureTask.run(FutureTask.java:266)
       at android.os.AsyncTask$SerialExecutor$1.run(AsyncTask.java:305)
       at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1167)
       at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:641)
       at java.lang.Thread.run(Thread.java:920)

Comments

ja...@gmail.com <ja...@gmail.com> #2Apr 7, 2023 06:17PM

Thank you for reporting this issue. We have been able to reproduce it internally and we will be working on a fix. We will update the issue with any related news.

vi...@eitv.com.br <vi...@eitv.com.br> #3Sep 29, 2023 06:04PM

This is working as intended and is documented here:

https://developers.google.com/places/ios-sdk/place-details

"GMSPlaceFieldPhoneNumber, GMSPlaceFieldWebsite, GMSPlaceFieldOpeningHours, and GMSPlaceFieldAddressComponents are not supported for GMSPlaceLikelihoodList place objects."

We are working on adding it here to the list of unsupported fields:

https://developers.google.com/places/ios-sdk/client-migration#find-place-likelihoods

I will keep this issue open until we fix this documentation bug. Again thank you for flagging this.

I you are interested in having this feature that returns all address components, please explain your use case.

ti...@candyspace.com <ti...@candyspace.com> #4Oct 4, 2023 10:10AM

This seems like a pretty standard use case from the previous iterations of this API. I need to pull the user's current location and get the address for display but often do not need to display the complete address. The user generally knows the city and state they are in so displaying a partial address allows for a much cleaner UI/UX. While it appears that I can achieve the same effect by making two API calls one to get the likelihood list and another to get the place details, that seems like a drain on user resources and could negatively affect performance, especially in rural and semi-rural markets where mobile data is often slow. Based on the fact that the deprecated version of the API returned all of the standard details for a place, this seems less like a feature add than a regression.

aq...@google.com <aq...@google.com> #5Oct 27, 2023 10:31AM

Hi folks, is there any available explanation for this other than users sideloading the apk and getting the apk splitting wrong? Because if so, I don't see what the library developers can do about this.

This seems like a androidx.mediarouter issue though

Could you narrow down what the issue is?

If we don't have concrete steps that the media router developers can take to help with this, we'll mark this as obsolete. Please kindly help us out.

bo...@justin.tv <bo...@justin.tv> #6Oct 27, 2023 04:04PM

In my original report, I said

ic_mr_button_disconnected_dark and ic_mr_button_disabled_dark both have xxhdpi, xhdpi, hdpi, and mdpi versions, but ic_mr_button_connected_30_dark only has xxhdpi and xhdpi versions, so maybe this is the problem?

Don't we need the same resolutions for all drawable components?

aq...@google.com <aq...@google.com> #7Oct 30, 2023 04:29PM

Reassigned to aq...@google.com.

Ah, apologies. I was sure we had fixed that some time ago, but the change was not merged, as far as I can tell. Thanks for pointing that out again. I'll look into this.

ap...@google.com <ap...@google.com> #8Nov 1, 2023 05:49PM

Project: platform/frameworks/support
Branch: androidx-main

commit cddba9334fdcdc5e5e7ac6df9753df7095545814
Author: Santiago Seifert <aquilescanta@google.com>
Date: Wed Nov 01 16:35:29 2023

Add missing dpi versions for ic_mr_button_connected_30_dark

Add hdpi and mdpi versions of ic_mr_button_connected_30_dark,
which are missing when compared to other drawables like
ic_mr_button_disconnected_dark and ic_mr_button_disabled_dark.

Bug: 261878418
Test: Manually using an emulator with hdpi resolution and the routing demo app.
Change-Id: I907c0581d186d5c7b58e092cda645fb1994f0757

A mediarouter/mediarouter/src/main/res/drawable-hdpi/ic_mr_button_connected_30_dark.png
A mediarouter/mediarouter/src/main/res/drawable-mdpi/ic_mr_button_connected_30_dark.png

https://android-review.googlesource.com/2812744

aq...@google.com <aq...@google.com> #9Nov 1, 2023 05:50PM

Marked as fixed.

The two missing resolutions have been added in https://android-review.git.corp.google.com/c/platform/frameworks/support/+/2812744. Next steps are:

Let me know if I missed anything.
Please upgrade to the next release that includes the fix.
File a fresh bug if the issue still reproduced, but please provide more info about the patterns behind the crash, like affected API versions, affected device models and DPI.