Fixed
Status Update
Comments
vi...@google.com <vi...@google.com> #2
So what is the recommendation on where to observe LiveData? onViewCreated? Because at one point, the docs were using onActivityCreated.
hu...@bytedance.com <hu...@bytedance.com> #3
Re #2 - They're called back to back, so they'd be equally valid (for a Fragment with a View).
vi...@google.com <vi...@google.com> #4
Project: platform/frameworks/support
Branch: androidx-master-dev
commit d3c7e85f798b804ef66da955f79f2d162aa20452
Author: Jeremy Woods <jbwoods@google.com>
Date: Tue Dec 17 11:27:36 2019
Ensure StrictFragment does not ascend state with destroyed activity
Added a check to make sure that when a StrictFragment is going up in
state, its activity is not destroyed. Put checks in onCreateView and
onCreatedView of StrictViewFragment too.
Test: all tests pass
BUG: 144309266
Change-Id: Iefe2031c0c40ba603dd83d257a255bf5df278dc3
M fragment/fragment/src/androidTest/java/androidx/fragment/app/StrictViewFragment.kt
M testutils/testutils-runtime/src/main/java/androidx/fragment/app/StrictFragment.kt
https://android-review.googlesource.com/1193030
Branch: androidx-master-dev
commit d3c7e85f798b804ef66da955f79f2d162aa20452
Author: Jeremy Woods <jbwoods@google.com>
Date: Tue Dec 17 11:27:36 2019
Ensure StrictFragment does not ascend state with destroyed activity
Added a check to make sure that when a StrictFragment is going up in
state, its activity is not destroyed. Put checks in onCreateView and
onCreatedView of StrictViewFragment too.
Test: all tests pass
BUG: 144309266
Change-Id: Iefe2031c0c40ba603dd83d257a255bf5df278dc3
M fragment/fragment/src/androidTest/java/androidx/fragment/app/StrictViewFragment.kt
M testutils/testutils-runtime/src/main/java/androidx/fragment/app/StrictFragment.kt
hu...@bytedance.com <hu...@bytedance.com> #5
Project: platform/frameworks/support
Branch: androidx-master-dev
commit c03c0e0ebfaca4b1b342dad0270489107ea4c73d
Author: Jeremy Woods <jbwoods@google.com>
Date: Tue Dec 17 11:35:33 2019
Change FragmentFinishEarlyTest to use StrictFragment
The goal of the FragmentFinishEarlyTest is to ensure that the Fragment
state is not raised while the activity is being destroyed.
StrictFragment now checks if the activity is being destroyed in all of
the upward states (onCreate, onStart, etc.) so we should just use that
instead of a custom Fragment with booleans.
Test: all tests pass
BUG: 144309266
Change-Id: Ic47a178c50bcbba246b91e2e25d969dd6931d765
M fragment/fragment/src/androidTest/java/androidx/fragment/app/FragmentFinishEarlyTest.kt
https://android-review.googlesource.com/1193089
Branch: androidx-master-dev
commit c03c0e0ebfaca4b1b342dad0270489107ea4c73d
Author: Jeremy Woods <jbwoods@google.com>
Date: Tue Dec 17 11:35:33 2019
Change FragmentFinishEarlyTest to use StrictFragment
The goal of the FragmentFinishEarlyTest is to ensure that the Fragment
state is not raised while the activity is being destroyed.
StrictFragment now checks if the activity is being destroyed in all of
the upward states (onCreate, onStart, etc.) so we should just use that
instead of a custom Fragment with booleans.
Test: all tests pass
BUG: 144309266
Change-Id: Ic47a178c50bcbba246b91e2e25d969dd6931d765
M fragment/fragment/src/androidTest/java/androidx/fragment/app/FragmentFinishEarlyTest.kt
Description