Fixed
Status Update
Comments
cc...@google.com <cc...@google.com> #2
I'm not able to reproduce the first issue, either in androidx or in the github sample (invoking via Studio, Bramble running API 33). In both cases, it correctly runs a single iteration, and Studio prints out a single metric value for min/median/max.
Able to reproduce the issue with baseline profiles, will fix.
ap...@google.com <ap...@google.com> #3
Project: platform/frameworks/support
Branch: androidx-main
commit f5efbd86f8a2594613268b7a54a5a2c50f70a9c2
Author: Chris Craik <ccraik@google.com>
Date: Mon Feb 06 16:28:10 2023
Fix dryRunMode for baseline profile generation
Test: TrivialListScrollBaselineProfile
Fixes:266403227
Relnote: "Fix DryRunMode to no longer crash with empty profile, due to
compilation skipping. Instead, it runs a single iteration and extracts
the profile to ensure something is captured."
Change-Id: I2f05dcb4b21b7bc1e3fc6262ab6106d383f885dc
M benchmark/benchmark-macro/src/main/java/androidx/benchmark/macro/BaselineProfiles.kt
M benchmark/benchmark-macro/src/main/java/androidx/benchmark/macro/CompilationMode.kt
https://android-review.googlesource.com/2424129
Branch: androidx-main
commit f5efbd86f8a2594613268b7a54a5a2c50f70a9c2
Author: Chris Craik <ccraik@google.com>
Date: Mon Feb 06 16:28:10 2023
Fix dryRunMode for baseline profile generation
Test: TrivialListScrollBaselineProfile
Fixes:266403227
Relnote: "Fix DryRunMode to no longer crash with empty profile, due to
compilation skipping. Instead, it runs a single iteration and extracts
the profile to ensure something is captured."
Change-Id: I2f05dcb4b21b7bc1e3fc6262ab6106d383f885dc
M benchmark/benchmark-macro/src/main/java/androidx/benchmark/macro/BaselineProfiles.kt
M benchmark/benchmark-macro/src/main/java/androidx/benchmark/macro/CompilationMode.kt
na...@google.com <na...@google.com> #4
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.benchmark:benchmark-macro:1.2.0-alpha10
Description
Component used: macrobench 1.2.0-alpha09, profileinstaller 1.3.0-alpha03 Devices/Android versions reproduced on:
When running benchmarks with
-Pandroid.testInstrumentationRunnerArguments.androidx.benchmark.dryRunMode.enable=true
they fail with missing metrics.For BaselineProfile generators it fails with profile being empty: