Live literals result in poor runtime performance due to boxing primitves [274207650]

Obsolete

Bug

Status Update

No update yet.

Description

za...@gmail.com

created issue #1

Mar 19, 2023 06:26PM

Jetpack Compose version: 1.4.0-rc01

Jetpack Compose component(s) used: compose-compiler

Android Studio Build: Giraffe canary 9

Kotlin version: 1.8.10

Steps to Reproduce or Code Sample to Reproduce:

Live literals currently appear to replace all literals with value class equivalent, including sources not related to compose.

I'm seeing significant performance loss in debug builds due to invoke-virtualbytecode being generated for basic math because kotlin turns 1 + 1 into 1.plus(1). Making a release build fixes that but I'd really like to enable that optimization on my debug builds so I can test some things faster in development.

Example bytecode: https://gist.github.com/vinc3m1/d56ff294a73ad506a5fa5ffb3e46185f

Comments

cs...@google.com <cs...@google.com> Mar 20, 2023 11:07PM

Assigned to ac...@google.com.

ac...@google.com <ac...@google.com> #2Mar 21, 2023 04:22AM

Assuming that 274231395 is working as intented (we can disable Live Edit support in the build file), given that Live Edit will completely remove all Compose Compiler instrumentations, I don't think it will be worth improving Live Literal's performance at this point.

ac...@google.com <ac...@google.com> #3May 26, 2023 08:35PM

Status: Won't Fix (Obsolete)

As of Giraffe, Live Literal is deprecated and will be completely replaced by Live Edit so I am going to close this bug.

Issue 274207650

Description

Issue summary

Comments

cs...@google.com <cs...@google.com> Mar 20, 2023 11:07PM

ac...@google.com <ac...@google.com> #2Mar 21, 2023 04:22AM

ac...@google.com <ac...@google.com> #3May 26, 2023 08:35PM

Add comment

Issue metadata