IssueTracker

Forgot to add a sample code! Here it goes:

SelectionContainer {
    LazyColumn {
        items(100) {
            Text("Line number $it")
        }
    }
}

A normal column works without any issues (expected since everything is composed unlike the LazyColumn).

Edit to give more details about my use case: I'm trying to show the lines of a text document in my app, so using a column is not an option as the files can be quite large.

Sean, would you be able to take the first stab at it and see what's needed?

This happens because the nodes containing selection are removed from the composition when they're scrolled out of view, which causes the selection container to stop tracking them. This is one of the use cases for b/195049010.

b/195049010 has been fixed, we can now request items be pinned to stay composed even when not visible. We just need to update BasicText to pin itself when it's participating in selection.

It'd be interesting to test how it can affect performance when selecting large number of lines.

Just tried beta3. The crash is now fixed ! Thanks.

However, the Popup always appears at the top of the screen instead of at the proper location. I'll try to put together a small project on github to demonstrate/reproduce the issue.

Unfortunately, this fix seems to cause EmojiPicker to crash when embedded into an IME:

android.view.WindowManager$BadTokenException: Unable to add window -- token null is not valid; is your activity running?
	at android.view.ViewRootImpl.setView(ViewRootImpl.java:931)
	at android.view.WindowManagerGlobal.addView(WindowManagerGlobal.java:387)
	at android.view.WindowManagerImpl.addView(WindowManagerImpl.java:95)
	at android.widget.PopupWindow.invokePopup(PopupWindow.java:1577)
	at android.widget.PopupWindow.showAtLocation(PopupWindow.java:1343)
	at android.widget.PopupWindow.showAtLocation(PopupWindow.java:1309)
	at androidx.emoji2.emojipicker.EmojiViewHolder.showPopupWindow(EmojiViewHolder.kt:114)
	at androidx.emoji2.emojipicker.EmojiViewHolder.onEmojiLongClickListener$lambda$0(EmojiViewHolder.kt:41)
	at androidx.emoji2.emojipicker.EmojiViewHolder.$r8$lambda$4L5z_x3hpOEoRlrrYk9cvuxGptg(Unknown Source:0)
	at androidx.emoji2.emojipicker.EmojiViewHolder$$ExternalSyntheticLambda0.onLongClick(Unknown Source:4)
	at android.view.View.performLongClickInternal(View.java:7339)
	at android.view.View.performLongClick(View.java:7297)
	at android.view.View.performLongClick(View.java:7315)
	at android.view.View$CheckForLongPress.run(View.java:27850)
	at android.os.Handler.handleCallback(Handler.java:883)
	at android.os.Handler.dispatchMessage(Handler.java:100)
	at android.os.Looper.loop(Looper.java:214)
	at android.app.ActivityThread.main(ActivityThread.java:7356)
	at java.lang.reflect.Method.invoke(Native Method)
	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:492)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:930)

Here's a super simple demo: https://github.com/abn-volk/EmojiPickerRepro. It crashes on 1.4.0-beta05 but works fine on 1.4.0-beta02.

To summarize the issue. Previously, we use emojiView as the parent of the popup view, this works fine with the sample app and embedding into an IME, however, this doesn't work with the nested popup view (embedding emoji picker into a popup view). After we use the inflated popupview as the parent of the popup view, this works fine with the sample app and embedding into a popup view, however, this doesn't work with embedding into an IME.

Logically, we should use the emojiView as the parent of the popup view, so we can anchor the popup view to the correct position. However, when we embed the emoji picker in the popup view, calling the #showAtLocation() with emojiView throws the WindowManagerGlobal.ADD_BAD_SUBWINDOW_TOKEN which is returned in here WindowManagerService error log: "Attempted to add window with token that is a sub-window".

Hi, With rc1 the feature is broken and displays 'Don't use EmojiPickerView inside a Popup'.

However using EmojiPickerView inside a popup is (in my opinion) the major and most valuable use-case for EmojiPickerView.

Docking EmojiPickerView at the bottom of the screen as a 'fake soft keyboard' leads to a bad user experience, especially on larger screens (tablets, foldables, laptops etc): When adding reactions to content, it forces the user to look away from the content.

Note that on larger screens, competing reaction-system usually allow to pick a emoji from a popup that opens near the content that is being reacted-to.

I attached a few examples of Apple implementation.

It would be awesome if Google could provide an equivalent for Android, and EmojiPickerView is almost it :) So please consider supporting EmojiPickerView in a popup, or provide guidance for a similar feature.

Thanks for the answer :)

I put together a small project to reproduce the issue:

https://github.com/aberaud/test_android_popupinpopup

This small project also try to show that:

• When placed in a PopupWindow, the EmojiPickerView is gorgeous, fun and super useful !
• The native Android PopupWindow is very useful and implements a lot of logic that would be hard to get right if done by hand.
• Showing a Popup inside a popup with correct positioning in Android is possible and simple on API 26+.

The project shows that it would be easily possible for EmojiPickerView to support nested popups, at least for API 26+. Also, maybe it would make sense for the androidx support library, or at least for the EmojiPickerView, to support a nested popup fallback for API < 26 ?

Many thanks

We will add this request to our planning.