[AGP] Prefab: CMake configuration task fails when JAVA_TOOL_OPTIONS env variable is set [278747089]

Fixed

Bug

Status Update

No update yet.

Description

kt...@google.com

created issue #1

Apr 18, 2023 06:25PM

When running tests we export JAVA_TOOL_OPTIONS environment variable to '-Djavax.net.ssl.trustStore=/var/cache/proxy.crt.jks' -Xlog:os+container=error (the exact value doesn't matter).

When this env set, java print Picked up JAVA_TOOL_OPTIONS: ' to the stderr at startup, this variable is also propagated to all child processes. (by design of export shell command)

Seems like the root case is that we:

create the child process to execute the com.google.prefab.cli.AppKt java app
The JAVA_TOOL_OPTIONS variable is propagated to the child java process
The fist line the child process to stderr is Picked up JAVA_TOOL_OPTIONS ...
This line is parsed as fatal error in the custom log consumer and reported up to the call stack.

Steps to reproduce:

We could use the sample curl-ssl app

Expectation:

cd curl-ssl/
export JAVA_TOOL_OPTIONS="-Xlog:os+container=error"
./gradlew assemble
Picked up JAVA_TOOL_OPTIONS: -Xlog:os+container=error # current gradle process
# gradle build output here ...
BUILD SUCCESSFUL in 8s
92 actionable tasks: 92 executed

Reality:

cd curl-ssl/
export JAVA_TOOL_OPTIONS="-Xlog:os+container=error"
./gradlew assemble
Picked up JAVA_TOOL_OPTIONS: -Xlog:os+container=error # current gradle process
# gradle build output here ...
FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':app:configureCMakeDebug[arm64-v8a]'.
> Picked up JAVA_TOOL_OPTIONS: -Xlog:os+container=error

here is the full stack trace with level=info: https://cnsviewer-static.corp.google.com/placer/prod/home/kokoro-dedicated/build_artifacts/prod/gmscore_libsculptor_app_build/prod/gcp_ubuntu/gradle/1743599/20230418-072720/gradle-log.txt

The issues is reproduced both for 7.3.1 and 8.0.0 Android Gradle Plugin versions.

Build: AI-222.4459.24.2221.9787799, 202303212107, 

AI-222.4459.24.2221.9787799, JRE 17.0.6+0-17.0.6b802.4-9586694x64 JetBrains s.r.o., OS Linux(amd64) v6.1.15-1rodete3-amd64, screens 2560.0x1440.0

AS: Flamingo | 2022.2.1 RC 1
Kotlin plugin: 222-1.8.0-release-AS3739.54
Android Gradle Plugin: 8.0.0
Gradle: 8.0
Gradle JDK: version 17.0.6
NDK: from module: 25.1.8937393, from local.properties: (not specified), latest from SDK: (not found)
CMake: from local.properties: (not specified), latest from SDK: 3.22.1-g37088a8, from PATH: 3.25.1

Comments

lu...@google.com <lu...@google.com> #2Jun 5, 2023 04:19PM

Accepted by lu...@google.com.

Taking a look, I don't think the issue is a duplicate of b/258246140, since there are differences in the env variable JAVA_TOOL_OPTIONS vs _JAVA_OPTION. I'll land a change similar to ag/21851679 which will fix the issue. Nightly snapshots of AGP can be found here https://androidx.dev/studio/builds

lu...@google.com <lu...@google.com> Jun 6, 2023 09:56AM

Marked as fixed.

fe...@google.com <fe...@google.com> #3Jun 6, 2023 11:14AM

Can you attach the fix CL (or PR) to the buganizer issue?

On Tue, 6 Jun 2023, 10:57 lukeedgar, <buganizer-system+lukeedgar@google.com>
wrote:

- Show quoted text -

kt...@google.com <kt...@google.com> #4Jul 5, 2023 01:38PM

@fergus,

This is the change: https://googleplex-android-review.git.corp.google.com/c/platform/tools/base/+/23563160

ch...@stripe.com <ch...@stripe.com> #5Jan 17, 2024 03:55PM

This issue does not seem fixed since it looks like a different error code is still reproducible on Android Gradle Plugin 8.2.1 (and updating Gradle to version 8.2 in the sample project as well).

cd curl-ssl/
export JAVA_TOOL_OPTIONS="-Xlog:os+container=error"
./gradlew assemble
Picked up JAVA_TOOL_OPTIONS: -Xlog:os+container=error
[0.001s][warning][logging] No tag set matches selection: os+container. Did you mean any of the following? os* os+thread* os+cpu os+thread+timer
> Task :app:configureCMakeDebug[arm64-v8a] FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':app:configureCMakeDebug[arm64-v8a]'.
> [CXX1210] /Users/chr/Documents/ndk-samples/prefab/curl-ssl/app/src/main/cpp/CMakeLists.txt debug|arm64-v8a : No compatible library found

The actual value of JAVA_TOOL_OPTIONS still doesn't matter as I can reproduce the same "No compatible library found" message regardless of the environment variable's value.

EDIT: Filed as b/353259702

Message last modified on Jul 15, 2024 08:06PM

Issue 278747089