Cannot run instrumented test for lib module on Pixel 7 Pro [281557479]

Fixed

Bug

Status Update

No update yet.

Description

em...@google.com

created issue #1

May 8, 2023 07:38PM

Build: AI-222.4459.24.2221.9971841, 202304191751, 

AI-222.4459.24.2221.9971841, JRE 17.0.6+0-17.0.6b802.4-9586694x64 JetBrains s.r.o., OS Mac OS X(aarch64) v13.3.1, screens 2992.0x1934.0; Retina

AS: Flamingo | 2022.2.1 Patch 1
Kotlin plugin: 222-1.8.20-release-AS3739.54
Android Gradle Plugin: 8.0.1
Gradle: (gradle version information not found)
Gradle JDK: JetBrains Runtime version 17.0.6
NDK: from module: 25.1.8937393, from module: 25.1.8937393, from local.properties: (not specified), latest from SDK: (not found)
CMake: from local.properties: (not specified), latest from SDK: 3.22.1-g37088a8, from PATH: (not found)

Repro instructions:

Use attached project.

Project has a nativelib module that has native code. Nothing special.

Select NativeLibInstrumentedTest target
Connect a Pixel 7 Pro device with latest OS updates.

I tested with emulators with API levels up to and including 33, and they work fine.
I tested with AGP 8.0.0 and 8.0.1 and they both fail.
I tested with AS Flamingo Patch 1, Giraffe canary 11, and studio-main, they all fail.

Hit the Run (play) button to run the test.

Expected result:

Test passes.

Actual result:

Test APK could not be installed.

Error message on the build window:

> Task :nativelib:connectedDebugAndroidTest FAILED
45 actionable tasks: 3 executed, 42 up-to-date
Exception thrown during onBeforeAll invocation of plugin com.google.testing.platform.plugin.android.AndroidDevicePlugin.
Failed to install APK(s): /Users/emrekultursay/Downloads/MyApplication30/nativelib/build/intermediates/apk/androidTest/debug/nativelib-debug-androidTest.apk
INSTALL_FAILED_VERIFICATION_FAILURE: Install not allowed
com.android.ddmlib.InstallException: INSTALL_FAILED_VERIFICATION_FAILURE: Install not allowed
	at com.android.ddmlib.internal.DeviceImpl.installRemotePackage(DeviceImpl.java:1376)
	at com.android.ddmlib.internal.DeviceImpl.installPackage(DeviceImpl.java:1202)
	at com.android.tools.utp.plugins.deviceprovider.ddmlib.DdmlibAndroidDevice.installPackage(DdmlibAndroidDevice.kt)
	at com.android.tools.utp.plugins.deviceprovider.ddmlib.DdmlibAndroidDeviceController$executeAsync$deferred$1.invokeSuspend(DdmlibAndroidDeviceController.kt:192)
	at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:33)
	at kotlinx.coroutines.DispatchedTask.run(DispatchedTask.kt:106)
	at kotlinx.coroutines.scheduling.CoroutineScheduler.runSafely(CoroutineScheduler.kt:571)
	at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.executeTask(CoroutineScheduler.kt:750)
	at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.runWorker(CoroutineScheduler.kt:678)
	at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.run(CoroutineScheduler.kt:665)


FAILURE: Build failed with an exception.

Logs and project are attached.

idea.log

130 KB

View

Download

MyApplication30.zip

47 MB

Download

Comments

es...@google.com <es...@google.com> May 8, 2023 11:24PM

Assigned to an...@google.com.

ar...@google.com <ar...@google.com> #2Jul 18, 2023 10:52PM

Reassigned to di...@google.com.

Are there any updates here?

di...@google.com <di...@google.com> #3Oct 16, 2023 08:44PM

I looked at it and I'm planning to remove the deduplicating lookup the callstack refers to. It should be no longer needed. How was the 80ms in comment#1 calculated? If it's straightforward I'll calculate it again before my change goes in.

di...@google.com <di...@google.com> #4Oct 16, 2023 08:45PM

I couldn't move the logging off thread but I was able to address an area of concern in the callstack:
com.google.protobuf.Descriptors$FileDescriptor.internalBuildGeneratedFileFrom(Descriptors.java)
com.android.build.gradle.internal.cxx.logging.CxxLogging.<clinit>(CxxLogging.java:82)
com.android.build.gradle.internal.cxx.logging.LoggingMessage.getDescriptor(LoggingMessage.java:110)
com.android.build.gradle.internal.cxx.logging.LoggingMessage.hashCode(LoggingMessage.java:489)
java.util.HashMap.hash(HashMap.java:340)
java.util.HashMap.containsKey(HashMap.java:592)
java.util.HashSet.contains(HashSet.java:204)

This logic was deduplicating messages (including chatty 'info' messages). This deduplication shouldn't be needed anymore so I removed it.

I don't know how the 80ms from

comment#1

was gathered so I can't say how much it has improved logging, but it should help quite a bit. Let me know if you can still measure a performance issue. The next step would be to reduce the 'info' that's logged.

Screenshot 2023-10-16 at 1.39.48 PM.png

2.5 MB

View

Download

em...@google.com <em...@google.com> #5Oct 18, 2023 09:46AM

The change mentioned in

comment#4

(internal Id I4e51a10d9ee2a81ca56c8e81c7890dfb0bf239d7) should be available in Canary 8 of Flamingo.

di...@google.com <di...@google.com> Oct 24, 2023 11:29PM

Accepted by di...@google.com.

cm...@google.com <cm...@google.com> #6Oct 31, 2023 01:00PM

Yes, target sdk defaults to min SDK in AGP if it's not set (this mimics the platform's behavior)

We have discussed changing that default in AGP to the compileSdkVersion, especially for library tests, but it's a behavioural breaking change so we'd want to wait for a major version

em...@google.com <em...@google.com> #7Nov 1, 2023 12:00AM

Then, at the moment, I believe we should fix the template for File > New > New Module..." so that it sets targetSdk field (similar to how the default Empty Activity template sets targetSdk = compileSdk).

Message last modified on Nov 1, 2023 12:01AM

em...@google.com <em...@google.com> #8Nov 1, 2023 12:21AM

But then I discover these:

b/234472788 => Remove targetSdkValue from gradle.builds for library modules
http://ag/21487220 => Don't set targetSdk in libraries

...which conflicts with what I want/need here. How can we set targetSdk for an instrumented test inside a library module?

Message last modified on Nov 1, 2023 12:22AM

em...@google.com <em...@google.com> #9Nov 1, 2023 12:22AM

+cc alex and james

di...@google.com <di...@google.com> #10Nov 14, 2023 07:33PM

Marked as fixed.

HI, I have created a bug to track changing the default targetSdk to compileSdk for AGP 9.0. b/308684631 In the meantime, I have merged a change to suppress this error in UTP for instrumented tests and should be available soon.

Message last modified on Nov 14, 2023 07:34PM

an...@google.com <an...@google.com> #11Nov 16, 2023 11:25PM

Thank you for your patience while our engineering team worked to resolve this issue. A fix for this issue is now available in:

Android Studio Iguana | 2023.2.1 Canary 14
Android Gradle Plugin 8.3.0-alpha14

We encourage you to try the latest update.

If you notice further issues or have questions, please file a new bug report.

Thank you for taking the time to submit feedback — we really appreciate it!

Issue 281557479

Description

Issue summary

Comments

es...@google.com <es...@google.com> May 8, 2023 11:24PM

ar...@google.com <ar...@google.com> #2Jul 18, 2023 10:52PM

di...@google.com <di...@google.com> #3Oct 16, 2023 08:44PM

di...@google.com <di...@google.com> #4Oct 16, 2023 08:45PM

em...@google.com <em...@google.com> #5Oct 18, 2023 09:46AM

di...@google.com <di...@google.com> Oct 24, 2023 11:29PM

cm...@google.com <cm...@google.com> #6Oct 31, 2023 01:00PM

em...@google.com <em...@google.com> #7Nov 1, 2023 12:00AM

em...@google.com <em...@google.com> #8Nov 1, 2023 12:21AM

em...@google.com <em...@google.com> #9Nov 1, 2023 12:22AM

di...@google.com <di...@google.com> #10Nov 14, 2023 07:33PM

an...@google.com <an...@google.com> #11Nov 16, 2023 11:25PM

Add comment

Issue metadata