Obsolete
Status Update
No update yet.
Comments
mi...@gmail.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit 3ba83f0a97f9cb645b95dc6a5b2ac02b4f159a23
Author: Ian Lake <ilake@google.com>
Date: Thu Mar 21 14:19:27 2019
Remove argument Bundle from FragmentFactory#instantiate
Provide a clearer separation between what
instantiate() is supposed to do (just
construct the class instance) versus what is
the responsibility of the caller (set the
arguments on the resulting Fragment).
As arguments can change at any time, it doesn't
make as much sense to use them at instantiation
time.
Test: tests still pass
Fixes: 128836103
Change-Id: I8018f4963ace5e58144ed1596c3b1e0b46638a7e
M fragment/api/1.1.0-alpha06.txt
M fragment/api/current.txt
M fragment/src/androidTest/java/androidx/fragment/app/FragmentFactoryTest.kt
M fragment/src/main/java/androidx/fragment/app/Fragment.java
M fragment/src/main/java/androidx/fragment/app/FragmentFactory.java
M fragment/src/main/java/androidx/fragment/app/FragmentManagerImpl.java
M fragment/src/main/java/androidx/fragment/app/FragmentState.java
M fragment/src/main/java/androidx/fragment/app/FragmentTabHost.java
M fragment/testing/api/1.1.0-alpha06.txt
M fragment/testing/api/current.txt
M fragment/testing/src/androidTest/java/androidx/fragment/app/testing/FragmentScenarioTest.kt
M fragment/testing/src/main/java/androidx/fragment/app/testing/FragmentScenario.java
M fragment/testing/src/main/java/androidx/fragment/app/testing/FragmentScenario.kt
M navigation/fragment/src/androidTest/java/androidx/navigation/fragment/FragmentNavigatorTest.kt
M navigation/fragment/src/main/java/androidx/navigation/fragment/FragmentNavigator.java
M preference/build.gradle
M preference/src/main/java/androidx/preference/PreferenceFragmentCompat.java
M samples/Support4Demos/src/main/java/com/example/android/supportv4/app/FragmentTabsPager.java
M samples/SupportLeanbackDemos/src/main/java/com/example/android/leanback/SearchSupportActivity.java
M samples/SupportPreferenceDemos/src/main/java/com/example/android/supportpreference/FragmentSupportPreferencesLeanback.java
M samples/SupportPreferenceDemos/src/main/java/com/example/androidx/preference/LeanbackPreferences.java
https://android-review.googlesource.com/932496
https://goto.google.com/android-sha1/3ba83f0a97f9cb645b95dc6a5b2ac02b4f159a23
Branch: androidx-master-dev
commit 3ba83f0a97f9cb645b95dc6a5b2ac02b4f159a23
Author: Ian Lake <ilake@google.com>
Date: Thu Mar 21 14:19:27 2019
Remove argument Bundle from FragmentFactory#instantiate
Provide a clearer separation between what
instantiate() is supposed to do (just
construct the class instance) versus what is
the responsibility of the caller (set the
arguments on the resulting Fragment).
As arguments can change at any time, it doesn't
make as much sense to use them at instantiation
time.
Test: tests still pass
Fixes: 128836103
Change-Id: I8018f4963ace5e58144ed1596c3b1e0b46638a7e
M fragment/api/1.1.0-alpha06.txt
M fragment/api/current.txt
M fragment/src/androidTest/java/androidx/fragment/app/FragmentFactoryTest.kt
M fragment/src/main/java/androidx/fragment/app/Fragment.java
M fragment/src/main/java/androidx/fragment/app/FragmentFactory.java
M fragment/src/main/java/androidx/fragment/app/FragmentManagerImpl.java
M fragment/src/main/java/androidx/fragment/app/FragmentState.java
M fragment/src/main/java/androidx/fragment/app/FragmentTabHost.java
M fragment/testing/api/1.1.0-alpha06.txt
M fragment/testing/api/current.txt
M fragment/testing/src/androidTest/java/androidx/fragment/app/testing/FragmentScenarioTest.kt
M fragment/testing/src/main/java/androidx/fragment/app/testing/FragmentScenario.java
M fragment/testing/src/main/java/androidx/fragment/app/testing/FragmentScenario.kt
M navigation/fragment/src/androidTest/java/androidx/navigation/fragment/FragmentNavigatorTest.kt
M navigation/fragment/src/main/java/androidx/navigation/fragment/FragmentNavigator.java
M preference/build.gradle
M preference/src/main/java/androidx/preference/PreferenceFragmentCompat.java
M samples/Support4Demos/src/main/java/com/example/android/supportv4/app/FragmentTabsPager.java
M samples/SupportLeanbackDemos/src/main/java/com/example/android/leanback/SearchSupportActivity.java
M samples/SupportPreferenceDemos/src/main/java/com/example/android/supportpreference/FragmentSupportPreferencesLeanback.java
M samples/SupportPreferenceDemos/src/main/java/com/example/androidx/preference/LeanbackPreferences.java
mi...@gmail.com
Woot woot
mi...@gmail.com
We've deprecated the FragmentFactory.instantiate(ClassLoader, String, android.os.Bundle?) method and switched all of our code to use the new instantiate(ClassLoader, String) for Fragment 1.1.0-alpha06.
The deprecated API will be removed in a later release.
The deprecated API will be removed in a later release.
ma...@seedtosaleteam.com
I've also been experiencing the same error on regularly running scripts. As the others, I'm using jdbc in a library script, and the errors are intermittent and seemingly random. The errors have greatly increased in frequency over the last several weeks.
jp...@google.com
jp...@google.com
I'm not able to reproduce. Please comment here if it is still an issue.
ke...@magentahealth.ca
Thank you for the update.
a) for our "mission critical scripts", we started making the connection in the app directly (instead of the library), and those for sure have not been throwing any errors.
b) for our "nice to have scripts", where the connection continues to be made in the library, and not the app, we believe with 90% certainty that the issue has been resolved as we stopped seeing errors in the logs. We will post if it seems to crop up again, especially once we revert our mission critical scripts in the coming weeks.
Thank you!
a) for our "mission critical scripts", we started making the connection in the app directly (instead of the library), and those for sure have not been throwing any errors.
b) for our "nice to have scripts", where the connection continues to be made in the library, and not the app, we believe with 90% certainty that the issue has been resolved as we stopped seeing errors in the logs. We will post if it seems to crop up again, especially once we revert our mission critical scripts in the coming weeks.
Thank you!
ke...@magentahealth.ca
I wanted to flag that this issue seems to have started up again on Sept 26, but very infrequently. Yesterday (Oct 4) the issue seems to have started again with a much higher (but still random) frequency
Thanks!
Thanks!
jp...@google.com
Thanks Keith. This might be related to the work on
ke...@magentahealth.ca
Thanks jp.... it's similar, but I don't think it's a duplicate of that issue because we're not using Oracle and that thread seems specific to Oracle dbs. We're connecting to Google Cloud SQL to a MySQL 5.6 db
jp...@google.com
ja...@studielokaal.nl
I saw the "Jdbc is not defined" error a few times since Monday 26 Feb 2024, while/since
Description
"ReferenceError: Jdbc is not defined" when making this call:
Jdbc.getCloudSqlConnection(dbUrl, info); in the following context:
A script deployed as a webapp running V8 where this call is made within a library
It is intermittent / random and we haven't been able to find any root cause. Various attempts at mitigation include:
a) implementing script caching to minimize db calls
b) upgrading the Google Cloud SQL instance that we are using
c) implementing an automated retry with an exponential backoff
We implemented a test function that made this library call 1000 times and run through the editor, it succeeded every time so it might be related to the webapp deployment?
Assistance would be highly appreciated!