Assigned
Status Update
Comments
se...@google.com <se...@google.com> #2
This actually has nothing to do with NavHostFragment, but is the behavior of NavController's setGraph().
When you call navController.setGraph(R.navigation.navigation_graph), it stores that ID and will restore that ID automatically.
If you were to instead use:
NavInflater navInflater = new NavInflater(this, navController.getNavigatorProvider());
navController.setGraph(navInflater.inflate(R.navigation.navigation_graph));
Then NavController would not restore the graph itself and the call to restoreState() you point out would only restore the back stack state, etc. but would wait for you to call setGraph again.
You're right that the inconsistency between the two setGraph methods is concerning. We'll take a look.
When you call navController.setGraph(R.navigation.navigation_graph), it stores that ID and will restore that ID automatically.
If you were to instead use:
NavInflater navInflater = new NavInflater(this, navController.getNavigatorProvider());
navController.setGraph(navInflater.inflate(R.navigation.navigation_graph));
Then NavController would not restore the graph itself and the call to restoreState() you point out would only restore the back stack state, etc. but would wait for you to call setGraph again.
You're right that the inconsistency between the two setGraph methods is concerning. We'll take a look.
se...@google.com <se...@google.com> #3
Turns out, we already had a tracking bug for this issue, will follow up on that other one.
si...@google.com <si...@google.com> #4
Thank you for promptly replying to my report. You are right that the issue you've just mentioned is similar to mine. I shall continue observing the progress over there.
se...@google.com <se...@google.com> #5
Relevant doc: go/unbundled-optimization
Description
Emoji2 initializer is in the hot path for most appcompat and compose applications.
It currently has several allocations and callbacks in bindActivity.
Audit it to ensure it's running as fast as possible (ideally just two object allocations and move on).
Also check in on the handler post(0), it is dispatching before Activity.onCreate so it's unclear it's actually gaining anything.