Status Update
Comments
og...@a-bank.com.ua <og...@a-bank.com.ua> #2
ca...@google.com <ca...@google.com>
ca...@google.com <ca...@google.com> #3
Analyzing dynamic features on their own like that doesn't work properly since even though they "depend" on the app they're actually including into an app so for example the unused resource check only makes sense when you look at it from the app perspective, not the other way around.
I believe in 7.0 we've fixed this in the sense that there isn't a lint task on the individual dynamic features.
og...@a-bank.com.ua <og...@a-bank.com.ua> #4
+1. In AGP 7.0 there are no lint tasks in dynamic-features; instead, any dynamic-features are analyzed when running lint on the app module. OP, can you try with AGP 7.0.0-rc01
, run lintRelease
on the corresponding application module, and see if you still hit the same issue?
ca...@google.com <ca...@google.com> #5
Not using dynamic feature modules but have this with an application module and a library module, happening on 7.0.0-rc01. I haven't figured out a repro yet but will upload one if I manage.
og...@a-bank.com.ua <og...@a-bank.com.ua> #6
Re #5, yes, a repro project would be very helpful, thanks!
ca...@google.com <ca...@google.com> #7
Closing this bug as not reproducible, but please reopen if you have a repro project.
dh...@relianceada.com <dh...@relianceada.com> #8
I am facing the same issue in my existing project but not getting in new project. Could you please suggest how can I fix it. I am attaching the my old project SR.
cl...@googlemail.com <cl...@googlemail.com> #9
After MUCH MUCH debugging I found the cause.
Before If you declared the GMSMapView only in the Storyboard class field and wrote no code to init the map it used to display a basic map and the frame were as expected the ones you configured in the SB.
Now you need to init the mapView in code using the new options parameter and the new init method and pass the frame in there.
see code here
From the release notes
September 19, 2023 8.0.0 added the new frame in options init method.
I would not have rebuilt this project since Sep. so only noticed today.
Before v8 If I added a UIView to the Storyboard. Added 0.0.0.0 constraint all round. Changed the classname in SB to GMSMapView. Run the app you would get a basic map and bounds would stay correct.
After GoogleMaps (8.3.1 possible 8.0+) if you only set the class name in SB and write no other code it no longer render a basic map
and oddly sets the frame on the GMSMapView to 0,0,0,0 so wrecks the whole UI and dumps a ton of layout errors which freaked me out.
Maybe a less dramatic default might prevent the hell I went through debugging this for the last 2 days.
Maybe keep the frame of the IBOutlet but render it blank till user intis it in code...
or put back the basic map
To fix it
I changed the GMSMapView in the SB to a UIView.
I mapped it to an IBOutlet called UIView mapViewContainer.
I removed IBOutlet from my mapView property so all my code can still find it.
BEFORE
@property (nonatomic, retain) IBOutlet SNGMSMapView *mapView;
AFTER
@property (nonatomic, retain) SNGMSMapView *mapView;
@property (weak, nonatomic) IBOutlet UIView *mapViewContainer;
Then in viewDidAppear i add code from the new docs to init it map
(not in viewDidLoad as constraints not laid out for mapViewContainer)
I use the code in the docs and pass the frame of mapViewContainer in the new options init
- (void)viewDidAppear:(BOOL)animated{
[super viewDidAppear:animated];
GMSMapViewOptions *options = [[GMSMapViewOptions alloc] init];
options.camera = [GMSCameraPosition cameraWithLatitude:-33.8683
longitude:151.2086
zoom:6];
options.frame =
CGRectMake(0.0,
0.0,
self.mapViewContainer.bounds.size.width,
self.mapViewContainer.bounds.size.height);
self.mapView = [[SNGMSMapView alloc] initWithOptions:options];
[self.mapViewContainer addSubview:self.mapView];
}
Probably not the best location but for now this worked.
mr...@gmail.com <mr...@gmail.com> #10
I changed my gsmmapview in storyboard to uiview and gsmmapview to the UIView as mentioned in above comment and it worked.
Thanks a bunch!!! I had been struggling for long.
Description
Operating system version: ios 15, ios 16
Google Maps SDK for iOS version: 4.1.0
Hardware model: iphone 11, iphone 12