WindowRecomposer throws exception finding a LifecycleOwner while inside an overlay [287484338]

Assigned

Bug

Status Update

No update yet.

Description

di...@gmail.com

created issue #1

Jun 15, 2023 11:56PM

Jetpack Compose version: 1.4.3

Jetpack Compose component used: UI, ComposeView

Android Studio Build: Android Studio Hedgehog | 2023.1.1 Canary 8 Build #AI-231.9011.34.2311.10290408

Kotlin version: 1.8.10

Steps to Reproduce:

Create a RecyclerView with lots of items. At least one off-screen should be a ComposeView.
Start a Visibility Transition in which the RecyclerView disappears.
While the transition is ongoing, call recyclerView.smoothScrollToPosition() to reveal the off-screen ComposeView.
Observe a crash as WindowRecomposer tries to get a ViewTreeLifecycleOwner from its root (a ViewGroupOverlay, due to the transition).

Sample project attached. Click any item (without scrolling) to run.

I'm seeing this crash infrequently in a production app, and while we should probably avoid calling smoothScrollToPosition() on a view that we know is disappearing, this ideally wouldn't crash. Not sure if this is more an issue with RecyclerView or Compose.

Stack trace:

java.lang.IllegalStateException: ViewTreeLifecycleOwner not found from android.view.ViewOverlay$OverlayViewGroup{ddd67a7 V.E...... ......ID 0,0-1080,2295}
	at androidx.compose.ui.platform.WindowRecomposer_androidKt.createLifecycleAwareWindowRecomposer(WindowRecomposer.android.kt:350)
	at androidx.compose.ui.platform.WindowRecomposer_androidKt.createLifecycleAwareWindowRecomposer$default(WindowRecomposer.android.kt:325)
	at androidx.compose.ui.platform.WindowRecomposerFactory$Companion$LifecycleAware$1.createRecomposer(WindowRecomposer.android.kt:168)
	at androidx.compose.ui.platform.WindowRecomposerPolicy.createAndInstallWindowRecomposer$ui_release(WindowRecomposer.android.kt:224)
	at androidx.compose.ui.platform.WindowRecomposer_androidKt.getWindowRecomposer(WindowRecomposer.android.kt:300)
	at androidx.compose.ui.platform.AbstractComposeView.resolveParentCompositionContext(ComposeView.android.kt:244)
	at androidx.compose.ui.platform.AbstractComposeView.ensureCompositionCreated(ComposeView.android.kt:251)
	at androidx.compose.ui.platform.AbstractComposeView.onAttachedToWindow(ComposeView.android.kt:283)
	at android.view.View.dispatchAttachedToWindow(View.java:20812)
	at android.view.ViewGroup.dispatchAttachedToWindow(ViewGroup.java:3490)
	at android.view.ViewGroup.addViewInner(ViewGroup.java:5290)
	at android.view.ViewGroup.addView(ViewGroup.java:5076)
	at android.view.ViewGroup.addView(ViewGroup.java:5016)
	at androidx.recyclerview.widget.RecyclerView$5.addView(RecyclerView.java:950)
	at androidx.recyclerview.widget.ChildHelper.addView(ChildHelper.java:107)
	at androidx.recyclerview.widget.RecyclerView$LayoutManager.addViewInt(RecyclerView.java:9430)
	at androidx.recyclerview.widget.RecyclerView$LayoutManager.addView(RecyclerView.java:9388)
	at androidx.recyclerview.widget.RecyclerView$LayoutManager.addView(RecyclerView.java:9375)
	at androidx.recyclerview.widget.LinearLayoutManager.layoutChunk(LinearLayoutManager.java:1676)
	at androidx.recyclerview.widget.LinearLayoutManager.fill(LinearLayoutManager.java:1622)
	at androidx.recyclerview.widget.LinearLayoutManager.onLayoutChildren(LinearLayoutManager.java:687)
	at androidx.recyclerview.widget.RecyclerView.dispatchLayoutStep2(RecyclerView.java:4645)
	at androidx.recyclerview.widget.RecyclerView.dispatchLayout(RecyclerView.java:4348)
	at androidx.recyclerview.widget.RecyclerView.consumePendingUpdateOperations(RecyclerView.java:2076)
	at androidx.recyclerview.widget.RecyclerView$ViewFlinger.run(RecyclerView.java:5789)
	at android.os.Handler.handleCallback(Handler.java:938)
	at android.os.Handler.dispatchMessage(Handler.java:99)
	at android.os.Looper.loopOnce(Looper.java:201)
	at android.os.Looper.loop(Looper.java:288)
	at android.app.ActivityThread.main(ActivityThread.java:7842)
	at java.lang.reflect.Method.invoke(Native Method)
	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:548)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1003)

ComposeRecyclerViewOverlayCrash.zip

946 KB

Download

Comments

ri...@google.com <ri...@google.com> #2Jun 16, 2023 04:44PM

Can't COUNT_DISTINCT() over a specific date range!!! This appears to be a common problem! Please fix ASAP!

ri...@google.com <ri...@google.com> #3Jun 16, 2023 07:02PM

Instead of counting unique values in a specified column COUNT_DISCTINCT counts rows in a database (on a view, not a table, to be more specific)... It works as expected with spreadsheets.

ri...@google.com <ri...@google.com> #4Jul 12, 2023 06:01PM

Having the same issue with count distinct when selecting a specific filter

di...@gmail.com <di...@gmail.com> #5Jul 19, 2023 02:42PM

From my side, I'm using Postgres Database (All good in Postgres doing the same grouping-unique, so no issues in DB or in Data).
If no values are selected in Filter Control widget the COUNT_DISTINCT is working as expected as it's getting Unique values for the entire dataset, but when I put a value in Filter Control, COUNT_DISTINCT is generating a wrong value.

ni...@parshipgroup.com <ni...@parshipgroup.com> #6Oct 26, 2023 08:03AM

I've run into the same issue. I'm connected to Postgres. When I apply a date filter to any metrics that use COUNT DISTINCT, the results wind up being COUNTs.

ek...@uber.com <ek...@uber.com> #7Mar 7, 2024 09:47PM

I can't believe that Google has left this bug unresolved for months, this is a joke. Any time we apply date filtering, and try to utilise count distinct aggregation, when we apply further filtering through other dimensions, the metrics become extremely overstated.

Please sort this out Google, we will have to move to a different tool as this is fundamental functionality...

Message last modified on Mar 18, 2024 08:48PM

ek...@uber.com <ek...@uber.com> #8Apr 24, 2024 09:48PM

My read on this is that Google doesn't care about Postgres/Redshift support for GDS, and that anyone not on BigQuery should choose a different BI tool. It's really unfortunate because GDS seemed to have a lot of potential.

at...@netflix.com <at...@netflix.com> #9May 7, 2024 09:46PM

We're using Big Query and have similar issue, don't know how long we have
to wait to get this resolved.

On Tue, Feb 4, 2020 at 1:02 PM <buganizer-system@google.com> wrote:

- Show quoted text -

sa...@google.com <sa...@google.com> #10Jun 12, 2024 03:34AM

Reassigned to an...@google.com.

Yeah, I don't think this is connector specific. It more so seems like a bug in how Data Studio handles count distinct aggregation when applying a date range and in conjunction with filtering with other dimensions. I created another thread for this here:

https://issuetracker.google.com/issues/148813902

Feel free to jump in on it and comment as well, this bug is affecting us massively here.

an...@google.com <an...@google.com> #11Jun 12, 2024 04:21PM

On our side it's probably working with a view vs actual table. Funny enough same data with the same filters displays in expected number of rows (so it can distinguish between unique entries properly (same string)).

ek...@uber.com <ek...@uber.com> #12Jun 12, 2024 05:15PM

Interesting. I am using Postgres and I gave your idea a shot, but a view and a table result in the same bug. However, I also tested to load the exact same data source onto Google Sheets and then load it onto Data Studio and the problem was resolved. So I was wrong^^ it IS connector specific. I guess the guy above^ is probably right. I'm pretty sure Google is aware of this but doubt they will ever fix it.

Best case if any one stumbles upon this 1) Either use a proxy like GSheets to load your data on there first if you are experiencing this bug with MySQL or Postgres or whatever other engine, or 2) Switch to a different BI tool!

ek...@uber.com <ek...@uber.com> #13Jul 16, 2024 07:58PM

Using Redshift with the Postgresql connector. When I render the individual values as a table, everything is correct, but when I render a COUNT DISTINCT in a score card I get incorrect numbers similar to what has been described above. We've really liked Data Studio so far as a BI Tool but it's a serious bullet if it can't do such a basic counting function correctly. The worst thing to present in a business report is data that is obviously wrong.

an...@google.com <an...@google.com> #14Jul 17, 2024 03:22PM

Same problem here. Count_distinct(column) fails when multiple values of a filter is applied.
Very Critical for us.

an...@google.com <an...@google.com> Oct 31, 2024 04:53PM

Accepted by an...@google.com.

do...@google.com <do...@google.com> #15Nov 12, 2024 05:38PM

It's incredible given how debilitating this is, how long this bug has existed 😢

an...@google.com <an...@google.com> #16Nov 13, 2024 08:33PM

Same problem on Postgres, please get this fixed, it GROUP BY on the date range dimension field so it's unable to COUNT DISTINCT properly

ap...@google.com <ap...@google.com> #17Nov 13, 2024 09:28PM

I've ran into this issue before using a Postgres connector but I've ran into it again now using the file upload (.csv) connector too. Interestingly, the Data Studio Explorer shows the correct values (using same config)!

an...@google.com <an...@google.com> #18Dec 11, 2024 06:41PM

Assigned to bu...@google.com.

I'm having the same issue, reading from a CSV and unable to count_distinct() a text field. Somehow this is fixed if I blend the data

bu...@google.com <bu...@google.com> #19Dec 11, 2024 06:41PM

Accepted by bu...@google.com.

Same here. Postgres connector. count_distinct() returns the value as if it were grouped by day and then summed, rather than a true distinct count for the duration of the date range selected

gb...@netflix.com <gb...@netflix.com> #20Jan 16, 2025 03:55AM

Same issue here...csv file, when a data range is selected, them returns incorrect value

bu...@google.com <bu...@google.com> Feb 11, 2025 06:43PM

Assigned to an...@google.com.

br...@target.com <br...@target.com> #21Mar 7, 2025 07:21PM

same here. Mysql connector. Data range filter + count distinct >> wrong value

br...@target.com <br...@target.com> #22Mar 7, 2025 09:54PM

Same issue. We solved by combining the data with itself, but it's a very dirty solution. Wait for a real fix !!
I also try using directly a calculated field with COUNT_DISTINCT() but it gave the same wrong result.