Infeasible
Status Update
Comments
su...@google.com <su...@google.com> #2 Restricted
Restricted
Comment has been deleted.
su...@google.com <su...@google.com> #3
Project: platform/frameworks/support
Branch: androidx-main
commit e465976de8f05f0d1db49b4e2887c9f3cd4beab5
Author: Jeremy Woods <jbwoods@google.com>
Date: Wed Mar 17 17:07:42 2021
Add OnBackPressedDispatcher observer before NavController observer
If you add a OnBackPressed callback with the NavBackStackEntry as the
lifecycle owner, if the Activity Lifecycle is STOPPED and STARTED again, the navController callback and NavBackStackEntry callback are readded to the Activity Lifecycle in the wrong order. This means that the new callback will not properly intercept onBackPressed() calls from the system, they will instead be intercepted by NavController.
If an OnBackPressedDispatcher is set, we should remove and readd the
NavController observer after we add the callback to the dispatcher.
RelNote: "OnBackPressedCallbacks added to a dispatcher with the
NavBackStackEntry as the LifecycleOwner now properly intercept back
after the Activity Lifecycle is STOPPED, then STARTED"
Test: NavControllerTest
Bug: 182284739
Change-Id: I6acf78848546160eaea7ed700ef8875664a125d0
M navigation/navigation-runtime/src/androidTest/java/androidx/navigation/NavControllerTest.kt
M navigation/navigation-runtime/src/main/java/androidx/navigation/NavController.kt
https://android-review.googlesource.com/1643646
Branch: androidx-main
commit e465976de8f05f0d1db49b4e2887c9f3cd4beab5
Author: Jeremy Woods <jbwoods@google.com>
Date: Wed Mar 17 17:07:42 2021
Add OnBackPressedDispatcher observer before NavController observer
If you add a OnBackPressed callback with the NavBackStackEntry as the
lifecycle owner, if the Activity Lifecycle is STOPPED and STARTED again, the navController callback and NavBackStackEntry callback are readded to the Activity Lifecycle in the wrong order. This means that the new callback will not properly intercept onBackPressed() calls from the system, they will instead be intercepted by NavController.
If an OnBackPressedDispatcher is set, we should remove and readd the
NavController observer after we add the callback to the dispatcher.
RelNote: "OnBackPressedCallbacks added to a dispatcher with the
NavBackStackEntry as the LifecycleOwner now properly intercept back
after the Activity Lifecycle is STOPPED, then STARTED"
Test: NavControllerTest
Bug: 182284739
Change-Id: I6acf78848546160eaea7ed700ef8875664a125d0
M navigation/navigation-runtime/src/androidTest/java/androidx/navigation/NavControllerTest.kt
M navigation/navigation-runtime/src/main/java/androidx/navigation/NavController.kt
su...@google.com <su...@google.com> #4
This has been fixed internally and will be part of the Navigation 2.3.5
release (via 2.4.0-alpha01
).
st...@google.com <st...@google.com> #5
Project: platform/frameworks/support
Branch: androidx-main
commit f231e0f384f9fd2e7a078bfcbeb7768c82c617b1
Author: Jeremy Woods <jbwoods@google.com>
Date: Wed Mar 17 17:40:05 2021
Add BackHandler callback with a LifecycleOwner
We need to ensure that the callback from BackHandler remains in the
proper position in the event of Lifecycle changes.
RelNote: "The BackHandler will now properly intercept back presses in
the event that the Activity is STOPPED, then STARTED again, and other
callbacks were added with a LifecycleOwner."
Test: BackHandlerTest
Bug: 182284739
Change-Id: I71de6184ba73f56b34de9dcddaf138d98c46417f
M activity/activity-compose/build.gradle
M activity/activity-compose/src/androidTest/java/androidx/activity/compose/BackHandlerTest.kt
M activity/activity-compose/src/main/java/androidx/activity/compose/BackHandler.kt
https://android-review.googlesource.com/1644062
Branch: androidx-main
commit f231e0f384f9fd2e7a078bfcbeb7768c82c617b1
Author: Jeremy Woods <jbwoods@google.com>
Date: Wed Mar 17 17:40:05 2021
Add BackHandler callback with a LifecycleOwner
We need to ensure that the callback from BackHandler remains in the
proper position in the event of Lifecycle changes.
RelNote: "The BackHandler will now properly intercept back presses in
the event that the Activity is STOPPED, then STARTED again, and other
callbacks were added with a LifecycleOwner."
Test: BackHandlerTest
Bug: 182284739
Change-Id: I71de6184ba73f56b34de9dcddaf138d98c46417f
M activity/activity-compose/build.gradle
M activity/activity-compose/src/androidTest/java/androidx/activity/compose/BackHandlerTest.kt
M activity/activity-compose/src/main/java/androidx/activity/compose/BackHandler.kt
vi...@google.com <vi...@google.com> #6
This has been addressed internally and will be available when using both the Activity 1.3.0-alpha06
and Navigation 2.3.5
releases.
su...@google.com <su...@google.com> #7
Project: platform/frameworks/support
Branch: androidx-main
commit d1d6f89ba90be8e7fba193570b427f52ec98f57a
Author: Jeremy Woods <jbwoods@google.com>
Date: Wed Mar 31 09:40:42 2021
Make nav compose depend on Navigation 2.3.5
Upgrading to the latest Navigation version to take advantage of fixed
bugs, (particularly around OnBackPressedDispatcher and lifecycles
b/182284739 ).
RelNote: "Navigation-compose now depends on Navigation version `2.3.5`"
Test: ./gradlew bOS
Change-Id: I7e63b32c93deaee60b1d5e132d3fa255c3ba85e2
M navigation/navigation-compose/build.gradle
https://android-review.googlesource.com/1660640
Branch: androidx-main
commit d1d6f89ba90be8e7fba193570b427f52ec98f57a
Author: Jeremy Woods <jbwoods@google.com>
Date: Wed Mar 31 09:40:42 2021
Make nav compose depend on Navigation 2.3.5
Upgrading to the latest Navigation version to take advantage of fixed
bugs, (particularly around OnBackPressedDispatcher and lifecycles
RelNote: "Navigation-compose now depends on Navigation version `2.3.5`"
Test: ./gradlew bOS
Change-Id: I7e63b32c93deaee60b1d5e132d3fa255c3ba85e2
M navigation/navigation-compose/build.gradle
Description
I am a developer of the Timeflick (com.apposter.watchmaker) app.
First, I will briefly introduce the operation of our app Timeflick (com.apposter.watchmaker).
Users can find a watch face product they like on the mobile screen and apply the watch face to Wear. At this time, the mobile and Wear are developed to interact with each other through the library below.
If you tap My Watch Information in My Page of the app, you will enter the 'Find My Watch' page.
Get a list of usable nodes through getCapabilityClient(context).getCapability on the page, and send a message requesting wear device information to each node using getMessageClient(context).sendMessage.
The wear receiving the request signal sends its information back to the mobile through getMessageClient(context).sendMessage. In the mobile app that received the information, the wear information is displayed as a list as shown in the success video below.
There is a release of the Galaxy Watch 6 soon, so I am testing the Galaxy Watch 6 samples provided by Samsung.
When the debug version or the release version is installed on the device through Android Studio, it works without any problems. However, the version installed on Google Play is not working. (production track, internal test track, etc.)
Since no abnormal termination occurs and debugging cannot be done with the version obtained from Google Play, it is only possible to guess which part does not work. The mobile to wear interaction works well, but the wear to mobile interaction works. I'm guessing it doesn't. The watch model I am testing is the Galaxy Watch 6 wear os 4.0, and I will send you screenshot files for detailed software information.
Can I know if there is a malfunction issue related to the library above when I install the app on wear os 4.0 through the play store?
thank you