Status Update
Comments
ap...@google.com <ap...@google.com> #2
Branch: androidx-main
commit fa340abe58c62a201665f788fdbc8bd3a2bd402d
Author: Charcoal Chen <charcoalchen@google.com>
Date: Mon Jul 10 14:43:55 2023
Fix large JPEG image issue on Samsung A5 series devices
Relnote:"Fixed large captured JPEG image issue on Samsung A5 (2017) series devices. The captured JPEG images contain redundant 0's padding data in the JFIF compressed data segment. It causes the captured images to have about 32 MB file size. Those redundant 0's padding data will be removed to make the captured images have normal image file sizes."
Bug: 288828159
Test: InvalidJpegDataParserTest && manual test on real devcies
Change-Id: I298373a190ff42cee685a51290ff5e08945e326a
M camera/camera-core/src/main/java/androidx/camera/core/imagecapture/JpegBytes2Disk.java
M camera/camera-core/src/main/java/androidx/camera/core/internal/compat/quirk/DeviceQuirksLoader.java
A camera/camera-core/src/main/java/androidx/camera/core/internal/compat/quirk/LargeJpegImageQuirk.java
A camera/camera-core/src/main/java/androidx/camera/core/internal/compat/workaround/InvalidJpegDataParser.java
A camera/camera-core/src/test/java/androidx/camera/core/internal/compat/workaround/InvalidJpegDataParserTest.kt
ch...@google.com <ch...@google.com>
na...@google.com <na...@google.com> #3
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.camera:camera-core:1.3.0-beta02
si...@gmail.com <si...@gmail.com> #4
Each picture is around 96mb in size, with a high amount of zeroes at the end.
Applying the change for A520F (
Thanks in advance.
ch...@google.com <ch...@google.com> #5
Thanks for your feedback. May I clarify with you some questions?
1. Do you add SM-A525F into the list here
<
If SM-A525F has been added and the issue still occurs, could you provide a
problematic image so that I can clarify the issue.
2. Could you provide the device model name info for the problematic A70 and
A72 devices?
3. On your side, is it possible to verify whether
adding A70 and A72 model names into the list here
<
We do not have all devices, if you can help to verify it in your side, it
will reduce the chance to cause any regression issue on those devices.
Thanks.
On Thu, Jul 27, 2023 at 9:32 PM <buganizer-system@google.com> wrote:
si...@gmail.com <si...@gmail.com> #6
thanks for your reply.
1. Yes, I added SM-A525F into that exact list. I also attached two images, one without the change applied and one with it applied.
2. The model names are:
A52 4G: SM-A525F and SM-A525M
A72: SM-A725F and SM-A725M
A70: SM-A705F, SM-A705FN, SM-A705GM, SM-A705MN, SM-A7050, SM-A705W, SM-A705YN and SM-A705U
3. Yes, I can directly verify that. A72 faces the exact same issue as A52 4G, so the image sizes are exactly the same for both phones (96mb without the change, around 77mb with the change applied).
On A70 the images are 48mb, and with it added to the list they are 24mb.
Two images shot on A52 4G are attached, one without the change and one with.
Thank you in advance.
sa...@gmail.com <sa...@gmail.com> #7
The bug appears regardless if I use the ViewPort API or not, or if I change the aspect ratio to 4:3 (image is then about 17MB).
ch...@google.com <ch...@google.com> #8
Hi,
For
For
si...@gmail.com <si...@gmail.com> #9
thanks for the patch. I applied the patch and the images now have normal sizes (<10mb on A52 and A72, <5mb on A70), so it works fine on all three phones.
I also checked and none of the images have any unneeded zeroes added to the end of the image.
Thank you very much, looking forward to it getting merged!
ap...@google.com <ap...@google.com> #10
Branch: androidx-main
commit 4a135311ced51b1772aca52a9c698341c769d0bb
Author: Charcoal Chen <charcoalchen@google.com>
Date: Fri Aug 04 17:40:30 2023
Fix large JPEG image issue on Samsung A5 series devices
Relnote:"Fixed large captured JPEG image issue on Samsung A5, A52, A70 and A72 series devices. The captured JPEG images contain redundant 0's padding data in the JFIF compressed data segment. It causes the captured images to have extreme file size (ex about 32MB or even 96 MB). Those redundant 0's padding data will be removed to make the captured images have normal image file sizes."
Bug: 288828159
Test: InvalidJpegDataParserTest && manual test on real devcies
Change-Id: I97c4d7745cfbff789e8890a9a04ee735eb84e5ed
M camera/camera-core/src/main/java/androidx/camera/core/imagecapture/JpegBytes2Disk.java
M camera/camera-core/src/main/java/androidx/camera/core/internal/compat/quirk/LargeJpegImageQuirk.java
M camera/camera-core/src/main/java/androidx/camera/core/internal/compat/workaround/InvalidJpegDataParser.java
M camera/camera-core/src/test/java/androidx/camera/core/internal/compat/workaround/InvalidJpegDataParserTest.kt
v....@dental-monitoring.com <v....@dental-monitoring.com> #12
ap...@google.com <ap...@google.com> #13
Branch: androidx-main
commit 6267c619847ff56a6ad72ac661291b7997815620
Author: Charcoal Chen <charcoalchen@google.com>
Date: Tue Aug 08 10:30:06 2023
Fix large JPEG image issue on Samsung S22 and S22+ series devices
Relnote:"Fixed large captured JPEG image issue on Samsung S22 (SM-S901B, SM-S901B/DS) and S22+ (SM-S906B) series devices. The captured JPEG images contain redundant 0's padding data in the JFIF compressed data segment. It causes the captured images to have large file size about 13MB on S22 SM-S901B/DS device. Those redundant 0's padding data will be removed to make the captured images have normal image file sizes."
Bug: 288828159
Test: ./gradlew bOS
Change-Id: I73be940494d3d600e6e2cdc99eb1f3814fb8bed2
M camera/camera-core/src/main/java/androidx/camera/core/internal/compat/quirk/LargeJpegImageQuirk.java
v....@dental-monitoring.com <v....@dental-monitoring.com> #14
I have the same issue on SM-G930V and SM-G930T (samsung galaxy s7)
ch...@google.com <ch...@google.com> #15
Hi,
These two S7 devices have green captured image problem and CameraX has a
- Are their device name "heroqltevzw" and "heroqltetmo"?
- After launching your app on these two S7 devices, could you execute the following command and let me know what are printed?
adb shell dumpsys media.camera | grep Dims
- If possible, please also provide the problematic images.
Although the workaround can resolve the problem, it will take some additional time to remove the redundant 0s padding data. Therefore, I would like to get some more info to make sure it is the same issue.
v....@dental-monitoring.com <v....@dental-monitoring.com> #16
2. I don't have reproduced it on the S7 I have, only saw it with the content-length logged on the backend side
3. Not possible :X sorry
But here the end of one of the image (from SM-G930V)
ap...@google.com <ap...@google.com> #17
Branch: androidx-main
commit 963ee2ae23f37aef995b05958e16ccfdefc6af63
Author: Charcoal Chen <charcoalchen@google.com>
Date: Wed Aug 09 10:14:42 2023
Fix large JPEG image issue on Samsung S7 series devices
Relnote:"Fixed large captured JPEG image issue on Samsung S7 (SM-G930T, SM-G930V) series devices. The captured JPEG images contain redundant 0's padding data in the JFIF compressed data segment. It causes the captured images to have large file size. Those redundant 0's padding data will be removed to make the captured images have normal image file sizes."
Bug: 288828159
Test: ./gradlew bOS
Change-Id: I407b0731d23a749a3cab21d8ed8cb5d52fe0ab0e
M camera/camera-core/src/main/java/androidx/camera/core/internal/compat/quirk/LargeJpegImageQuirk.java
v....@dental-monitoring.com <v....@dental-monitoring.com> #18
ch...@google.com <ch...@google.com> #19
If everything goes well, the next release might be published on around Aug/23.
ap...@google.com <ap...@google.com> #20
Branch: androidx-main
commit d01f2910e55912f1bb89f17feb7eb6ae985cc0fe
Author: Charcoal Chen <charcoalchen@google.com>
Date: Tue Sep 05 17:00:45 2023
Add a test to detect the abnormally large JPEG image issue
Added new jpegImageZeroPaddingDataDetectionTest to detect whether 1mb continuous zero padding data occurs after EOI.
Bug: 288828159
Test: ImageCaptureTest on real devices
Change-Id: I2337c90980fa772323769411e1951efa25941957
M camera/camera-core/src/main/java/androidx/camera/core/internal/compat/workaround/InvalidJpegDataParser.java
M camera/integration-tests/coretestapp/src/androidTest/java/androidx/camera/integration/core/ImageCaptureTest.kt
na...@google.com <na...@google.com> #21
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.camera:camera-core:1.4.0-alpha01
le...@gmail.com <le...@gmail.com> #22
can some one add samsung A71 SM-A715F ? same issue spotted with camera it take 96 mb image size
ch...@google.com <ch...@google.com> #23
Hi,
Can you provide a image captured from A71 to us to confirm the same solution can work? Thanks.
le...@gmail.com <le...@gmail.com> #24
Here is the image from A71
ha...@gmail.com <ha...@gmail.com> #25
Galaxy A71:
SM-A715F
SM-A715F/DS
SM-A715F/DSM
SM-A715F/DSN
SM-A715W
SM-A715X
Galaxy M51:
SM-M515F
SM-M515F/DSN
ap...@google.com <ap...@google.com> #26
Branch: androidx-main
commit 3fc8f444693fc413fdc0152aadc3e555837c1a9e
Author: CharcoalChen <charcoalchen@google.com>
Date: Tue Nov 14 11:19:56 2023
Fix large JPEG image issue on Samsung A71, M51 series devices
Relnote:"Fixed large captured JPEG image issue on Samsung A71 and M51 series devices. The captured JPEG images contain redundant 0's padding data in the JFIF compressed data segment. It causes the captured images to have extreme file size. Those redundant 0's padding data will be removed to make the captured images have normal image file sizes."
Bug: 288828159
Test: ./gradlew bOS
Change-Id: I01afc7e5001f42788a66388f5a66e0858e4dcfd5
M camera/camera-core/src/main/java/androidx/camera/core/internal/compat/quirk/LargeJpegImageQuirk.java
le...@gmail.com <le...@gmail.com> #27
Hi,
thanks for your reply.
i will apply the changes and come back with resultes !
na...@google.com <na...@google.com> #28
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.camera:camera-core:1.4.0-alpha03
de...@gmail.com <de...@gmail.com> #29
Galaxy S20 FE Snapdragon (r8q):
SM-G780G
SM-G780G/DS
SM-G781B
SM-G781B/DS
SM-G781U1
SM-G781U1/DS
SM-G781W
ap...@google.com <ap...@google.com> #30
Branch: androidx-main
commit 21205f26089d04d68d881cf9a8e32f16aaaeae3f
Author: CharcoalChen <charcoalchen@google.com>
Date: Thu Jan 18 16:03:31 2024
Make the invalid JPEG data check applied to all Samsung devices if the captured image is larger than 10 MB
Relnote: "Make the invalid JPEG data check applied to all Samsung devices if the captured image is larger than 10 MB. This can fix abnormally large iamge issue on Samsung devices."
Bug: 288828159
Test: manual test on real device
Change-Id: Ic2a65ccdc3eeb75bdf4c70e5c2b96004328422d1
M camera/camera-core/src/main/java/androidx/camera/core/internal/compat/quirk/LargeJpegImageQuirk.java
M camera/camera-core/src/main/java/androidx/camera/core/internal/compat/workaround/InvalidJpegDataParser.java
v....@dental-monitoring.com <v....@dental-monitoring.com> #31
q....@dental-monitoring.com <q....@dental-monitoring.com> #32
q....@dental-monitoring.com <q....@dental-monitoring.com> #33
V2045 VIVO X60
V2046 Vivo X60 Pro
SM-S921B Samsung Galaxy S24
SM-S926B Samsung Galaxy S24+
ap...@google.com <ap...@google.com> #34
Branch: androidx-main
commit 9d460850fcdca9f8ca2cdb03d82efc97c623144d
Author: CharcoalChen <charcoalchen@google.com>
Date: Fri Feb 23 14:12:18 2024
Apply LargeJpegImageQuirk onto Vivo X60 and X60 Pro devices
Relnote: "Make the invalid JPEG data check applied to Vivo X60 and X60 Pro devices. This can fix abnormally large iamge issue on these devices."
Bug: 288828159
Test: ./gradlew bOS
Change-Id: I8224707d5976d8e9a2cb96c54399544fb14699de
M camera/camera-core/src/main/java/androidx/camera/core/internal/compat/quirk/LargeJpegImageQuirk.java
ch...@google.com <ch...@google.com> #35
v....@dental-monitoring.com <v....@dental-monitoring.com> #36
ch...@google.com <ch...@google.com> #37
Hi Julie,
Could you help to share the CameraX v1.4's next release plan? Thanks.
wu...@google.com <wu...@google.com> #38
v....@dental-monitoring.com <v....@dental-monitoring.com> #39
na...@google.com <na...@google.com> #40
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.camera:camera-core:1.4.0-alpha05
Description
This issue is created for the issue reported via Android CameraX Discussion Group .
This should be a device specific issue that happens on Samsung A5 series devices. Please see the following two related posts I can find:
Re-encoding the JPEG images can produce normal size JPEG files and it seems like that it won't take obviously longer time to capture photos on my local A5 device.