Status Update
Comments
al...@google.com <al...@google.com>
ap...@google.com <ap...@google.com> #2
I had to rollback to an older version. I've had hundreds of crashes reported because of this.
ap...@google.com <ap...@google.com> #3
Sorry about this, can you provide some additional context:
What percentage of your app installs are crashing? Is it isolated on any small number of OEMs or android versions?
ap...@google.com <ap...@google.com> #4
1% of our active users.
According to Crashlytics it looks like it's mostly Motorola (Moto Z), followed by LG (G7 ThinQ and V20, and then Pixel 2 and Pixel 2 XL, then Blu Pure View. Equally spread across Android 8-10.
It looks like the majority (85%) of the crashes are happening when the app is in the background, i.e. a notification wakes it up.
ap...@google.com <ap...@google.com> #5
Have you observed anything log containing the AndroidKeysetManager tag?
na...@google.com <na...@google.com> #6
I haven't been able to repro this locally, and I don't have access to logs on the users' devices. I've tried to get it to happen on my device, and I monitored the logs and didn't see AndroidKeysetManager anywhere.
na...@google.com <na...@google.com> #7
Does 1.1.0-alpha01 address this?
na...@google.com <na...@google.com> #8
I haven't been able to repro this locally, however the count of users and crashes that this is happening for is steadily rising (I released an update that rolled the library version back, but it doesn't have wide adoption yet).
I sampled a bunch of them, and it looks like this predominantly happens when an FCM wakes up the device while in the background.
pr...@google.com <pr...@google.com> #9
pr...@google.com <pr...@google.com> #10
Alpha 1.1.0 adds support for Lollipop devices, it may not help in this case.
We're working on adding better exception handling in these cases. There is a small percentage of devices that will not be able to use the AndroidKeyStore.
na...@google.com <na...@google.com> #11
Got a report of this happening on a co-worker's device (unfortunately can't get device physically because of COVID, but I will be sending them builds to try and diagnose more). They confirmed:
- The issue occurred after opening the app from a notification (posted locally, not through FCM)
- After the crash, they can not recover
pr...@google.com <pr...@google.com> #12
#10 when you say "small percentage of devices" does that mean models, or physical devices? Because the current predominant device this is happening on is Pixel 2, but there are many more Pixel 2s that don't have the issue.
And if they aren't able to use the AndroidKeyStore will they still be able to use this library?
cl...@gmail.com <cl...@gmail.com> #13
I mean physical devices, some work and some don't - even the same phone model. I don't have any concrete numbers to share.
Yes, the library still works, we do a self test to check the keystore in the newer versions RC2+ to see if the Keystore is operating properly. In these cases where the Keystore is broken, the Keystore is not used to wrap the key. You do still get the protection of Android's full disk encryption/file based encryption depending on Android version.
For more info, bullet 3 describes what I'm talking about.
Description
We've finalized SDK_INT 34, we should deprecate the check.