IssueTracker

Copying over the comment from the duplicate bug: the gradlew file is treated by the IDE as a C++ header file (see the h icon), which is probably why it causes clangd to be used for analyzing this file. We should investigate why gradlew file is treated as a C++ header.

This might be related: http://cs/studio-main/tools/vendor/intellij/cidr/cidr-lang-base/src/com/jetbrains/cidr/lang/OCFileTypeHelpers.java;l=34;rcl=0e51e33e523a1036436765faf7382dca68f201e2

It is related, but removing that line that associates the "" extension with C++ header files is not sufficient.

When I remove that line, this time we get gradlew recognized as a C++ source file, i.e., VirtualFile(".../gradlew") has the type OCFile. Debugging the internals of how file type is computed, I see:

1. We first try to find the file type using the file extension, which returns null file type because the empty file extension is no longer associated with anything.
2. Then we try to deduce from contents of the file: In FileTypeDetectionService, we iterate over a set of detectors. One of those detectors is OCHeaderFileTypeDetector. It has a parser that somehow accepts this gradlew file contents and returns OCFileType.

I think all the # comments inside the gradlew file make the detector think that this is a header file.

There is a denylist inside the OCHeaderFileTypeDetector, and when I add the empty/null extension (or "gradlew") there, I get gradlew file registered as a Shell file (which fixes (1) the icon, (2) the "Inspect Code", and (3) syntax higlighting in the editor for the gradlew file).

Filed https://youtrack.jetbrains.com/issue/CPP-34353/Android-Studio-C-CIDR-detects-gradlew-as-a-C-file

Android Studio specific CIDR patch in http://ag/24125164

I can't access the bug, so maybe add something along the following lines unless you already did: I can see why looking at the file contents for a file full of shell comments (#) might lead it to think it's a header file since # is often a preprocessor directive, but it would be great for it to explicitly check for shebangs (https://en.wikipedia.org/wiki/Shebang_(Unix)) so if the file starts with "#!" it is NOT a headerfile.

I can't access the bug

That's odd. Are you logged into YouTrack? (I always mark visibility as Jetbrains Team + Registered Users).

to explicitly check for shebangs (https://en.wikipedia.org/wiki/Shebang_(Unix))

Makes sense. I'll make sure I mention this in the YouTrack bug.

Jetbrains says this has already been implemented in the following issue:

https://youtrack.jetbrains.com/issue/CPP-34057/Autodetect-of-shell-scripts-via-shebang-not-working

I searched the latest tags in our cidr/ fork, but I couldn't find the fix. I asked them for the commit hash. Maybe it's not tagged yet.

Raluca found the change I was looking for: https://googleplex-android.googlesource.com/platform/tools/vendor/intellij/cidr/+/0902785f0abbb61ececcd6f392056aba83b71038

We will cherry-pick that one (instead of my fix(es)) next week. We should also cherry-pick it into studio-hedgehog-dev when the branch is ready.