Assigned
Status Update
Comments
ca...@google.com <ca...@google.com>
ca...@google.com <ca...@google.com>
he...@google.com <he...@google.com> #2
- Application get crashed when Recylerview reach at end(last page). Inside GithubRemoteMediator.kt I have set val endOfPaginationReached = page > 2 to allow maximum 2 pages for testing. So, the problem is when I reach at the last page of list, application get crashed as remoteKeys.nextKey is null(as we have set nextKey=null for last page of list).
Do you have a stack trace for the crash you could share?
- Offline cache broken How to support caching when application is open without internet connection. currently it is showing retry button. How to show previously loaded data. I have tried to fix this by removing
This might be due to loadStateFlow / listener logic on the PagingDataAdapter which hides / shows UI elements based on load state. You'll want to modify that logic to only listen to remote errors and not the local ones as well.
he...@google.com <he...@google.com>
ca...@google.com <ca...@google.com> #3
1. stack for remoteKeys.nextKey gets null
06-17 14:48:03.981 18015-18015/com.example.android.codelabs.paging E/AndroidRuntime: FATAL EXCEPTION: main
Process: com.example.android.codelabs.paging, PID: 18015
java.io.InvalidObjectException: Remote key should not be null for APPEND
at com.example.android.codelabs.paging.data.GithubRemoteMediator.load(GithubRemoteMediator.kt:68)
at com.example.android.codelabs.paging.data.GithubRemoteMediator$load$1.invokeSuspend(GithubRemoteMediator.kt)
at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:33)
at kotlinx.coroutines.DispatchedTask.run(DispatchedTask.kt:56)
at android.os.Handler.handleCallback(Handler.java:739)
at android.os.Handler.dispatchMessage(Handler.java:95)
at android.os.Looper.loop(Looper.java:148)
at android.app.ActivityThread.main(ActivityThread.java:7325)
at java.lang.reflect.Method.invoke(Native Method)
at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:1230)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1120)
2. I have checked loadStateFlow / listener logic and changed it to listen only remote errors using loadState.mediator.refersh. But still, in offline mode application shows empty list. I have also removed the loadStateFlow / listener but still, it's not working in offline mode. It is not fetching data available in databa.
06-17 14:48:03.981 18015-18015/com.example.android.codelabs.paging E/AndroidRuntime: FATAL EXCEPTION: main
Process: com.example.android.codelabs.paging, PID: 18015
java.io.InvalidObjectException: Remote key should not be null for APPEND
at com.example.android.codelabs.paging.data.GithubRemoteMediator.load(GithubRemoteMediator.kt:68)
at com.example.android.codelabs.paging.data.GithubRemoteMediator$load$1.invokeSuspend(GithubRemoteMediator.kt)
at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:33)
at kotlinx.coroutines.DispatchedTask.run(DispatchedTask.kt:56)
at android.os.Handler.handleCallback(Handler.java:739)
at android.os.Handler.dispatchMessage(Handler.java:95)
at android.os.Looper.loop(Looper.java:148)
at android.app.ActivityThread.main(ActivityThread.java:7325)
at java.lang.reflect.Method.invoke(Native Method)
at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:1230)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1120)
2. I have checked loadStateFlow / listener logic and changed it to listen only remote errors using loadState.mediator.refersh. But still, in offline mode application shows empty list. I have also removed the loadStateFlow / listener but still, it's not working in offline mode. It is not fetching data available in databa.
jo...@gmail.com <jo...@gmail.com> #4
Project: platform/frameworks/support
Branch: androidx-master-dev
commit b5e4aa03a057d56a55ffc6abf250ce8a34e5071b
Author: Dustin Lam <dustinlam@google.com>
Date: Wed Jun 17 00:50:31 2020
Allow local REFRESH even if remote REFRESH fails
Bug: 158892717
Test: ./gradlew paging:paging-common:test
Change-Id: I38b1b1784af935cfbd8b937d9f4ab372f59619ed
M paging/common/src/main/kotlin/androidx/paging/PageFetcherSnapshot.kt
M paging/common/src/main/kotlin/androidx/paging/PagerState.kt
M paging/common/src/main/kotlin/androidx/paging/ViewportHint.kt
M paging/common/src/test/kotlin/androidx/paging/CachingTest.kt
M paging/common/src/test/kotlin/androidx/paging/PageFetcherSnapshotTest.kt
M paging/common/src/test/kotlin/androidx/paging/TestPagingSourceExt.kt
M testutils/testutils-paging/src/main/java/androidx/paging/TestPagingSource.kt
https://android-review.googlesource.com/1341068
Branch: androidx-master-dev
commit b5e4aa03a057d56a55ffc6abf250ce8a34e5071b
Author: Dustin Lam <dustinlam@google.com>
Date: Wed Jun 17 00:50:31 2020
Allow local REFRESH even if remote REFRESH fails
Bug: 158892717
Test: ./gradlew paging:paging-common:test
Change-Id: I38b1b1784af935cfbd8b937d9f4ab372f59619ed
M paging/common/src/main/kotlin/androidx/paging/PageFetcherSnapshot.kt
M paging/common/src/main/kotlin/androidx/paging/PagerState.kt
M paging/common/src/main/kotlin/androidx/paging/ViewportHint.kt
M paging/common/src/test/kotlin/androidx/paging/CachingTest.kt
M paging/common/src/test/kotlin/androidx/paging/PageFetcherSnapshotTest.kt
M paging/common/src/test/kotlin/androidx/paging/TestPagingSourceExt.kt
M testutils/testutils-paging/src/main/java/androidx/paging/TestPagingSource.kt
Description
It would be desirable to:
- have newer, updated 3D tiles; or at least be able to request an update;
- have the correct timestamp information for 3D tiles (when was it created?)
Reproducing the issue:
this is an area I know where the information from 2D and 3D tiles do not match and the timestamps are shown as the same:
Switch the location from 3D globe/2D satellite or request it from the API as 3D/2D tiles. Note the timestamp states 2023 for both pictures.