Material3: Checkbox: disabledBorderColor is used instead of disabledUncheckedColor by internal fun borderColor() for ToggleableState.Off [291943198]

Fixed

Bug

Status Update

No update yet.

Description

[Deleted User]

created issue #1

Jul 20, 2023 08:55AM

Jetpack Compose version: androidx-compose-bom = "2023.04.01"
Jetpack Compose component used: Checkbox
Android Studio Build: AS Hedgehog | 2023.1.1 Canary 12 Build #AI-231.9161.38.2311.10457801,
Kotlin version: 1.8.22

Steps to Reproduce or Code Sample to Reproduce:

I pass the following colors to androidx.compose.material3.TriStateCheckbox:

    checkedColor = MyTheme.colors.primary, 
    uncheckedColor = MyTheme.colors.outline,
    checkmarkColor = MyTheme.colors.onPrimary, 
    disabledCheckedColor = MyTheme.colors.primary.dim3,
    disabledUncheckedColor = MyTheme.colors.outline.dim3,
)

However the result is that in desabled unchecked state the checkbox has lighter primary color instead of the expected lighter outline color (screenshot attached: most right checkbox is disabled unckecked state, second from the right is enabled unchecked).

CheckboxDefaults.colors() doc says:

disabledUncheckedColor - color that will be used for the box and border when disabled and not checked

However in internal fun borderColor() for disabled uncheck State disabledBorderColor is used instead which leads to incorrect design:

val target = if (enabled) {
   ….
} else {
    when (state) {
        ToggleableState.Indeterminate -> disabledIndeterminateBorderColor
        ToggleableState.On, ToggleableState.Off -> disabledBorderColor
    }
}
```

image.png

8.2 KB

View

Download

Comments

co...@google.com <co...@google.com> Jul 20, 2023 07:15PM

Reassigned to sg...@google.com.

sg...@google.com <sg...@google.com> Jul 21, 2023 04:02AM

Accepted by sg...@google.com.

ap...@google.com <ap...@google.com> #2Jul 21, 2023 06:10PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main

commit d1aba6064d4c1aedfd10ec75fd8d181fcb37c947
Author: Matvei Malkov <malkov@google.com>
Date: Mon Feb 07 18:31:52 2022

Missing pieces for adaptive compose material3: drawer items

material3 provides navigation rail with items, bottom navigation with items, but the drawer without items, evven though there are specs for it.

This CL add a NavigationDrawerItem and some related APIs around it

Bug: 218286829
Test: will be added
Relnote: NavigationDrawerItem is added that represents a single destination within the drawers
Change-Id: Ic396fe99d1f26080a3e3a9d2ed505e72008c85aa

M compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/NavigationDrawer.kt
M compose/material3/material3/samples/src/main/java/androidx/compose/material3/samples/DrawerSamples.kt
M compose/material3/material3/api/public_plus_experimental_current.txt
A compose/material3/material3/src/androidAndroidTest/kotlin/androidx/compose/material3/NavigationDrawerItemScreenshotTest.kt
A compose/material3/material3/src/androidAndroidTest/kotlin/androidx/compose/material3/NavigationDrawerItemTest.kt

https://android-review.googlesource.com/1974464

na...@google.com <na...@google.com> #3Aug 10, 2023 03:47PM

Project: platform/frameworks/support
Branch: androidx-main

commit ec4e83f16c8a226c381001b61679a0ff189d4dcb
Author: Matvei Malkov <malkov@google.com>
Date: Mon Feb 07 17:29:43 2022

Missing pieces for adaptive compose material3: drawers for large screens

This CL adds two different kinds of drawer specifically for large screens: permanent standard drawer and dismissible standard drawer.

Bug: 218286829
Relnote: PermanentNavigationDrawer and DismissibleNavigationDrawer have been added as experiental APIs. Those are the drawers suitable well for large screen devices.
Test: added new for new API
Change-Id: I5f8abcd6137f0819ceccae0f8cacd2a44af5ad2e

A compose/material3/material3/src/androidAndroidTest/kotlin/androidx/compose/material3/PermanentNavigationDrawerTest.kt
M compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/NavigationDrawer.kt
A compose/material3/material3/src/androidAndroidTest/kotlin/androidx/compose/material3/DismissibleNavigationDrawerTest.kt
M compose/material3/material3/samples/src/main/java/androidx/compose/material3/samples/DrawerSamples.kt
M compose/material3/material3/api/public_plus_experimental_current.txt
M compose/material3/material3/integration-tests/material3-catalog/src/main/java/androidx/compose/material3/catalog/library/model/Examples.kt

https://android-review.googlesource.com/1974463

Issue 291943198