JVM_IR evaluate expression fails to evaluate fragments with SAM wrappers [294485700]

Fixed

Bug

Status Update

No update yet.

Description

ag...@google.com

created issue #1

Aug 4, 2023 07:45AM

Background: Evaluate expression in Android Studio currently uses the non-IR evaluator. That is based on the old JVM backend which will be removed. Therefore, we need to make sure that Android Studio works with the IR evaluator.

To reproduce, make sure that you run android studio with the debugger.kotlin.evaluator.use.jvm.ir.backend=true option.

In a Kotlin Android application add the following Java code:

I.java

public interface I {
  public String foo();
}

Consume.java

public class Consume {
  public static String bar(I i) {
    return i.foo();
  }
}

Debug the android application. At a breakpoint, evaluate the following fragment:

Consume.bar { "OK" }

Evaluation fails with the message Can not evaluate the expression: INVOKEDYNAMIC is not supported.

Comments

ag...@google.com <ag...@google.com> #2Aug 4, 2023 07:59AM

Initial debugging on an Android O+ device shows the following steps. We compile the fragment which gives us class files containing invoke-dynamic instructions as expected. Since the class files contain features that are not supported by eval4j, we hit the code path where we dex the class files, load the dex classes in a class loader on the device, and use the debugger to invoke the fragment method. However, that invocation fails. When that invocation fails, we fall back to using eval4j even though we know it will not work. That then leads to the error.

We should figure out why the invocation fails. It shouldn't.

ag...@google.com <ag...@google.com> #3Aug 4, 2023 08:07AM

Assigned to ag...@google.com.

Oh, no wonder. We have configured the dexer to not make sure that things work on android: https://cs.android.com/android-studio/platform/tools/adt/idea/+/mirror-goog-studio-main:android-kotlin/idea-android/src/org/jetbrains/kotlin/android/debugger/AndroidDexerImpl.kt;l=56?q=AndroidDexerImpl&ss=android-studio (which used to probably be OK as the Kotlin compiler never generated lambdas using invoke-dynamic and default and static interface methods are natively supported on Android O+)

We need to make sure that we enable desugaring, at least on this path where we know we are on Android O+ so that evaluate expression will succeed.

Message last modified on Aug 4, 2023 09:06AM

ac...@google.com <ac...@google.com> #4Aug 4, 2023 05:19PM

> Evaluate expression in Android Studio currently uses the non-IR evaluator.

I am a bit surprised by this. I figure Kristoffer was doing all that work and was upstreaming fixes to switch over.

Now it makes sense. Live Edit has:

compilerConfiguration.put(JVMConfigurationKeys.SAM_CONVERSIONS, JvmClosureGenerationScheme.CLASS)
compilerConfiguration.put(JVMConfigurationKeys.LAMBDAS, JvmClosureGenerationScheme.CLASS)

so we didn't see this even as we needed the IR backend but K2 isn't respecting that flag (and have future plans to remove it)

ag...@google.com <ag...@google.com> #5Aug 7, 2023 06:14AM

Evaluate expression in Android Studio currently uses the non-IR evaluator.

I am a bit surprised by this. I figure Kristoffer was doing all that work and was upstreaming fixes to switch over.

Kristoffer implemented evaluate expression support for IR backend in the Kotlin compiler and IntelliJ. It has been a bit of a journey to get it turned on by default. It is now the default in IntelliJ, so it should be in studio as well soon.

Speaking of which, I just noticed: https://b.corp.google.com/issues/286558843 which was fixed by disabling the IR evaluator in studio. There is an upstream issue for the problem. However, it looks like it is triggered by the compose lowerings, so we should attempt to help with that.

ag...@google.com <ag...@google.com> #6Aug 7, 2023 06:15AM

Marked as fixed.

Fix for this issue: https://googleplex-android-review.git.corp.google.com/c/platform/tools/adt/idea/+/24308959

Issue 294485700