Studio fails to handle included builds that are symlinked [295337712]

Fixed

Bug

Status Update

No update yet.

Description

yb...@google.com

created issue #1

Aug 10, 2023 04:50PM

In the AndroidX github build, we symlink a buildSrc folder. Starting on Hedgehog canary 15, project import fails with an error:

Build not found: BuildId(buildRoot=/Users/yboyar/src/androidx/collection/buildSrc) 
available builds {BuildId(buildRoot=/Users/yboyar/src/androidx/collection)=:, BuildId(buildRoot=/Users/yboyar/src/androidx/buildSrc)=:buildSrc, BuildId(buildRoot=/Users/yboyar/src/androidx/playground-common/playground-plugin)=:playground-plugin}

It fails to find buildRoot=/Users/yboyar/src/androidx/collection/buildSrc but that folder is actually a symlink to /Users/yboyar/src/androidx/buildSrc which is in the list of available builds. It seems like some code resolves it to cannonical path but others doesn't, causing the issue.

To reproduce:

clone AndroidX github: https://github.com/androidX/androidx cd collection && ./gradlew studio

Android Studio Hedgehog | 2023.1.1 Canary 15
Build #AI-231.9225.16.2311.10572941, built on July 27, 2023
Runtime version: 17.0.7+0-17.0.7b1000.6-10550314 aarch64
VM: OpenJDK 64-Bit Server VM by JetBrains s.r.o.
macOS 13.5
GC: G1 Young Generation, G1 Old Generation
Memory: 4096M
Cores: 10
Registry:
    external.system.auto.import.disabled=true
    ide.text.editor.with.preview.show.floating.toolbar=false

Comments

yb...@google.com <yb...@google.com> #2Aug 10, 2023 04:52PM

FYI, gradle works fine, it is just studio that fails to import the project.

I think this is where it broke:

https://cs.android.com/android-studio/platform/tools/adt/idea/+/f9375204decab6b200c1439b77330880100c5a04

Message last modified on Aug 10, 2023 04:52PM

xi...@google.com <xi...@google.com> Aug 10, 2023 07:27PM

Assigned to an...@google.com.

au...@google.com <au...@google.com> #3Aug 10, 2023 07:31PM

I don't think this is under android studio editing, this seems to be a gradle sync problem

ga...@google.com <ga...@google.com> #4Aug 11, 2023 10:37AM

Reassigned to ga...@google.com.

The issue can be reproduced by:

creating a new project in H C15
create nested_build with nested_build/settings.gradle
run ln -s nested_build/ nested_symbolic
in $rootProject/settings.gradle add: includeBuild("nested_symbolic")

Sync fails with:

Build not found: BuildId(buildRoot=/usr/local/google/home/gavra/AndroidStudioProjects/MyApplication18/nested_symbolic) 
available builds {BuildId(buildRoot=/usr/local/google/home/gavra/AndroidStudioProjects/MyApplication18)=:, BuildId(buildRoot=/usr/local/google/home/gavra/AndroidStudioProjects/MyApplication18/nested_build)=:nested_symbolic}

The issue is that there is a mix of canonical and non-canonical paths during import.

ga...@google.com <ga...@google.com> #5Aug 14, 2023 03:04PM

This is going to be fun:

we can fix this particular issue in Android Studio, but...
importing non-Android Gradle project that uses symlinked included builds in IDEA fails, because...
some APIs in Gradle return canonical path (e.g. Project.projectDir) while others (e.g. org.gradle.tooling.model.BuildIdentifier#getRootDir) do not canonicalize paths.

ga...@google.com <ga...@google.com> #6Aug 15, 2023 11:21AM

Marked as fixed.

The fix landed in Studio - ag/I2634cc214b0348c5c2a282294077c44def5e9fcf.

Tracking the IDEA change and adding a test in http://b/295882834.

au...@google.com <au...@google.com> #7Aug 15, 2023 08:18PM

Status: Assigned (reopened)

Could we land this in AS H since this is a regression from AS G

ga...@google.com <ga...@google.com> #8Aug 16, 2023 08:36AM