Recovery stress test experienced upper level restart [301573605]

WAI

Bug

Status Update

No update yet.

Description

xi...@xiaomi.corp-partner.google.com

created issue #1

Sep 22, 2023 01:18PM

U version, recently replicated multiple SF NE restarts

Process uptime: 281s
Cmdline: /system/bin/surfaceflinger
pid: 2082, tid: 2082, name: surfaceflinger >>> /system/bin/surfaceflinger <<<
uid: 1000
tagged_addr_ctrl: 0000000000000001 (PR_TAGGED_ADDR_ENABLE)
pac_enabled_keys: 000000000000000f (PR_PAC_APIAKEY, PR_PAC_APIBKEY, PR_PAC_APDAKEY, PR_PAC_APDBKEY)
signal 11 (SIGSEGV), code 1 (SEGV_MAPERR), fault addr 0x0000000000000000
Cause: null pointer dereference
x0 b400007a568f1000 x1 b400007a568f1008 x2 b400007a568b9900 x3 0000000000000009
x4 0000000000000000 x5 0000000000000004 x6 000000496ae35a39 x7 0000004969a05a3d
x8 0000000000000000 x9 b400007a213b6000 x10 b400007a56805f10 x11 0000000000000001
x12 ffffff80ffffffd0 x13 0000004968aa2921 x14 00000049689ea6a1 x15 0000000000000000
x16 0000000000000001 x17 0000007ad740f7c8 x18 0000007ae4b16000 x19 b400007a56871878
x20 b400007a568f1000 x21 b400007a568204c0 x22 b400007a568204c0 x23 b400007a568fba80
x24 b400007a568fba98 x25 b400007a5680a0d8 x26 0000007ae4634000 x27 b400007a56871798
x28 000000496b2f021b x29 0000007fe1e524c0
lr 0000007ad7413c5c sp 0000007fe1e524c0 pc 0000000000000000 pst 0000000020001800

13 total frames
backtrace:
#00 pc 0000000000000000 <unknown>
#01 pc 00000000003c2c58 /system/lib64/libsurfaceflinger.so (android::frametimeline::impl::FrameTimeline::DisplayFrame::~DisplayFrame()+140) (BuildId: 630056256d7da18d5d0473e20eb29bf7)
#02 pc 00000000003be8ac /system/lib64/libsurfaceflinger.so (android::frametimeline::impl::FrameTimeline::finalizeCurrentDisplayFrame()+228) (BuildId: 630056256d7da18d5d0473e20eb29bf7)
#03 pc 00000000003be4a8 /system/lib64/libsurfaceflinger.so (android::frametimeline::impl::FrameTimeline::setSfPresent(long, std::__1::shared_ptr<android::FenceTime> const&, std::__1::shared_ptr<android::FenceTime> const&)+556) (BuildId: 630056256d7da18d5d0473e20eb29bf7)
#04 pc 0000000000312fe8 /system/lib64/libsurfaceflinger.so (android::SurfaceFlinger::postComposition(long)+1336) (BuildId: 630056256d7da18d5d0473e20eb29bf7)
#05 pc 0000000000311c1c /system/lib64/libsurfaceflinger.so (android::SurfaceFlinger::composite(android::TimePoint, android::VsyncId)+3496) (BuildId: 630056256d7da18d5d0473e20eb29bf7)
#06 pc 00000000002e7ed8 /system/lib64/libsurfaceflinger.so (android::scheduler::Scheduler::onFrameSignal(android::ICompositor&, android::VsyncId, android::TimePoint)+92) (BuildId: 630056256d7da18d5d0473e20eb29bf7)
#07 pc 0000000000018a60 /system/lib64/libutils.so (android::Looper::pollInner(int)+380) (BuildId: f77e8a7cc4315a777d187d5c714e8155)
#08 pc 0000000000018880 /system/lib64/libutils.so (android::Looper::pollOnce(int, int*, int*, void**)+124) (BuildId: f77e8a7cc4315a777d187d5c714e8155)
#09 pc 00000000002d7770 /system/lib64/libsurfaceflinger.so (android::impl::MessageQueue::waitMessage()+88) (BuildId: 630056256d7da18d5d0473e20eb29bf7)
#10 pc 00000000002e7e74 /system/lib64/libsurfaceflinger.so (android::scheduler::Scheduler::run()+32) (BuildId: 630056256d7da18d5d0473e20eb29bf7)
#11 pc 000000000001980c /system/bin/surfaceflinger (main+1816) (BuildId: 50b0afdf8786842d373cc71e5021b655)
#12 pc 000000000008d99c /apex/com.android.runtime/lib64/bionic/libc.so (__libc_init+108) (BuildId: 1e3ca19bcae05c01b019c85f3f422e56)

1276 void FrameTimeline::finalizeCurrentDisplayFrame() {
//std::scoped_lock lock(mMutex); //This may require locking
1277 while (mDisplayFrames.size() >= mMaxDisplayFrames) {
1278 // We maintain only a fixed number of frames' data. Pop older frames
1279 mDisplayFrames.pop_front();
1280 }
1281 mDisplayFrames.push_back(mCurrentDisplayFrame);
1282 mCurrentDisplayFrame.reset();
1283 mCurrentDisplayFrame = std::make_shared<DisplayFrame>(mTimeStats, mJankClassificationThresholds,
1284 &mTraceCookieCounter);
1285 }

In the FrameTimeline.cpp file, other places where mDisplayFrames are used have locks added. Should locks also be added to this function to ensure thread safety? thanks

Comments

vi...@google.com <vi...@google.com> Sep 23, 2023 03:50AM

Assigned to an...@google.com.

js...@google.com <js...@google.com> #2Sep 26, 2023 08:00PM

Reassigned to ad...@google.com.

For clarity, are you requesting this as a developer or as a user?

ad...@google.com <ad...@google.com> #3Sep 26, 2023 08:24PM

Reassigned to xi...@xiaomi.corp-partner.google.com.

im tester .. but this bug is confirmed by developer as source bug not ROM..

On Sun, May 14, 2023 at 8:56 PM <buganizer-system@google.com> wrote:

- Show quoted text -

xi...@xiaomi.corp-partner.google.com <xi...@xiaomi.corp-partner.google.com> #4Sep 27, 2023 02:48AM

Thank you for reporting this issue. For us to further investigate this issue, please provide the following additional information:

What steps are needed to reproduce this issue? Frequency of occurrence?

Which device did you use to reproduce this issue?

Can you confirm if this issue is reproducible on a Pixel/Nexus device?

Screen Record of the Issue
Please capture screen record or video of the issue using following steps:

adb shell screenrecord /sdcard/video.mp4
Subsequently use following command to pull the recorded file:
adb pull /sdcard/video.mp4
Attach the file to this issue.

Android bug report (to be captured after reproducing the issue)
For steps to capture a bug report, please refer:

https://developer.android.com/studio/debug/bug-report#bugreportdevice

Alternate method
Navigate to “Developer options”, ensure “USB debugging” is enabled, then enable “Bug report shortcut”. Capture bug report by holding the power button and selecting the “Take bug report” option.

Note: Please upload the bug report and screenshot to google drive and share the folder to android-bugreport@google.com, then share the link here.

xi...@xiaomi.corp-partner.google.com <xi...@xiaomi.corp-partner.google.com> #5Nov 3, 2023 02:51AM

Please provide the requested information to proceed further. Unfortunately the issue will be closed within 7 days if there is no further update.

ad...@google.com <ad...@google.com> #6Nov 3, 2023 03:42AM

-What steps are needed to reproduce this issue? Frequency of occurrence?
this happens almost 3 times of 5 times when u pull notification panel down ..occurs sometimes not all times. u just need to pull notification panel down after and after to see it(while animation scalings is set to 0)
-Which device did you use to reproduce this issue?
Xiaomi Redmi note 4X .. almost every A13 AOSP custom ROMs .. (Lineage OS, CrDroid, VoltageOS, PixelOS, ...)
-Can you confirm if this issue is reproducible on a Pixel/Nexus device?
no its not Google device.. and i dont have Pixel/Nexus to test it
since i flashed Feb build i dont have that issue anymore to take report or video .. but i will flash last one again and will take a video and report. also the screen shots are attached in first post here..

https://drive.google.com/drive/folders/1WMQazgZHaYIocQmFblWhQQphSiyA4pWy

xi...@xiaomi.corp-partner.google.com <xi...@xiaomi.corp-partner.google.com> #7Nov 4, 2023 06:36AM

update: Video and report zip also added to G-Drive ..
also one thing to mention.. this glitch happens more when no notifications is there.. as u can see now capturing screen is there and this happend 2-3 times but when there is nothing in notification panel it happens more..

ad...@google.com <ad...@google.com> Nov 6, 2023 06:15PM

Status: Won't Fix (Intended Behavior)