Bug: PagingData.empty() should not emit a LoadState.Loading refresh state [301833847]

Fixed

Bug

Status Update

No update yet.

Description

ch...@gmail.com

created issue #1

Sep 25, 2023 03:19AM

Component used: androidx.paging:paging-compose
Version used: 3.2.1
Devices/Android versions reproduced on: Pixel 6 Pro API 32 emulator

val emptyApi = MutableStateFlow(PagingData.empty<String>()).collectAsLazyPagingItems()
val emptyList = MutableStateFlow(PagingData.from(emptyList<String>())).collectAsLazyPagingItems()
assertThat(emptyApi.loadState.refresh).isInstanceOf(LoadState.Loading::class.java)
assertThat(emptyList.loadState.refresh).isNotInstanceOf(LoadState.Loading::class.java)

That last line shouldn't pass. Both empty the API call and from(emptyList()) should be marked as not loading. Ian mentioned the difference was in the cachedPageEvent that's in the from method, but not the empty one.

For what it's worth, I would consider this a breaking API change. In places where people were relying on empty to be an initial loading state to show a progress indicator, it won't if this bug is fixed.

As an alternative, maybe expose a PagingData.loading() which does what empty does now.

Comments

cl...@google.com <cl...@google.com> #2Oct 10, 2023 08:31PM

Marked as fixed.

Thank you for your patience, we have rolled back a change in the Google 3D Tiles API service. Could you check on your end if this fixes your issue?

to...@marginalen.se <to...@marginalen.se> #3Mar 21, 2024 07:15AM

Thank you for your prompt response and for rolling back the recent change
in the *Google 3D Tiles API service*. I have tested it on my end, and I can
confirm that the issue is now resolved.

I truly appreciate your quick action in addressing this matter. Your
support is invaluable, and I'm grateful for the efficiency and dedication
of your team.

Thanks again for your help!

*Best regards,Mohammad*

On Fri, Feb 14, 2025 at 7:17 AM <buganizer-system@google.com> wrote:

- Show quoted text -

cl...@google.com <cl...@google.com> #4Mar 22, 2024 01:09AM

Thank you for the confirmation.

Note however that we plan to restart the rollout soon. IIUC the version 2.7.13 of Blosm was released with a fix: could you confirm with the developer that this version of the plugin would continue working if we were to restart the rollout now?

Issue 301833847

Description

Issue summary

Comments

cl...@google.com <cl...@google.com> #2Oct 10, 2023 08:31PM

to...@marginalen.se <to...@marginalen.se> #3Mar 21, 2024 07:15AM

cl...@google.com <cl...@google.com> #4Mar 22, 2024 01:09AM

Add comment

Issue metadata