Fixed
Status Update
Comments
ap...@google.com <ap...@google.com> #2
Sergio shared a WIP CL to calculate more correct bounds. You can see in the screenshot attached here that it does a better job of tightening the bounds around the object (the yellow box), but that it misses some of the curves which expand beyond these tighter bounds. In particular, note the two triangles and the two blob shapes (rotated round rects).
I've attached another 2 screenshots from the ShapeEditor view of one of the blobs, showing the shape and controls/anchors. You can see that the tighter bounds (yellow rectangle) are constrained to the anchors, but the curves at the end go beyond those points and exceed the bounds.
I've attached another 2 screenshots from the ShapeEditor view of one of the blobs, showing the shape and controls/anchors. You can see that the tighter bounds (yellow rectangle) are constrained to the anchors, but the curves at the end go beyond those points and exceed the bounds.
pr...@google.com <pr...@google.com> #3
Part of the problem is that the min/max values are assigned the anchors to begin with. That would cause the problem we're seeing in #2, because these new bounds are constrained to the rectangle created by the anchor points, even if the control points cause curves to go outside of those bounds.
But that's not all of the problem here. When I changed those min/max values to use the control points instead, the bounds expanded to be essentially the same as the estimated bounds from before. So there's more to it.
But that's not all of the problem here. When I changed those min/max values to use the control points instead, the bounds expanded to be essentially the same as the estimated bounds from before. So there's more to it.
Description
In addition to
Mode.First
andMode.Sum
, could we addMode.Max
similarly as with memory metric?This way I could find for example the longest
onDraw
section to be able to figure out where to dive further