Fixed
Status Update
Comments
kl...@google.com <kl...@google.com>
ap...@google.com <ap...@google.com> #2
Project: platform/frameworks/support
Branch: androidx-main
commit ed90c9a382eb2afe65b62765519e6256edc76195
Author: Siyamed Sinir <siyamed@google.com>
Date: Thu Apr 15 11:12:47 2021
Add ParagraphStyle/SpanStyle Saver
Preparation for TextFieldValue/AnnotatedString Savers.
- After a concern about dependencies collected all
savers to the same file un ui-text.
- We want to make those savers public, however since
the module of those Savers requires discussion,
will move the Savers in another CL.
RelNote: "Added TextUnit constructor function
TextUnit(value: Float, type: TextUnitType)"
Test: Added tests
Test: ./gradlew compose:ui:ui-text:test
Test: ./gradlew compose:ui:ui-text:cAT
Bug: 178446304
Change-Id: I7eccedda948c374d0cab1e883a56294aa9007b68
M compose/ui/ui-text/api/1.0.0-beta06.txt
M compose/ui/ui-text/api/current.txt
M compose/ui/ui-text/api/public_plus_experimental_1.0.0-beta06.txt
M compose/ui/ui-text/api/public_plus_experimental_current.txt
M compose/ui/ui-text/api/restricted_1.0.0-beta06.txt
M compose/ui/ui-text/api/restricted_current.txt
A compose/ui/ui-text/src/commonMain/kotlin/androidx/compose/ui/text/Savers.kt
A compose/ui/ui-text/src/test/java/androidx/compose/ui/text/SaversTest.kt
M compose/ui/ui-unit/api/public_plus_experimental_1.0.0-beta06.txt
M compose/ui/ui-unit/api/public_plus_experimental_current.txt
M compose/ui/ui-unit/src/commonMain/kotlin/androidx/compose/ui/unit/TextUnit.kt
https://android-review.googlesource.com/1675372
Branch: androidx-main
commit ed90c9a382eb2afe65b62765519e6256edc76195
Author: Siyamed Sinir <siyamed@google.com>
Date: Thu Apr 15 11:12:47 2021
Add ParagraphStyle/SpanStyle Saver
Preparation for TextFieldValue/AnnotatedString Savers.
- After a concern about dependencies collected all
savers to the same file un ui-text.
- We want to make those savers public, however since
the module of those Savers requires discussion,
will move the Savers in another CL.
RelNote: "Added TextUnit constructor function
TextUnit(value: Float, type: TextUnitType)"
Test: Added tests
Test: ./gradlew compose:ui:ui-text:test
Test: ./gradlew compose:ui:ui-text:cAT
Bug: 178446304
Change-Id: I7eccedda948c374d0cab1e883a56294aa9007b68
M compose/ui/ui-text/api/1.0.0-beta06.txt
M compose/ui/ui-text/api/current.txt
M compose/ui/ui-text/api/public_plus_experimental_1.0.0-beta06.txt
M compose/ui/ui-text/api/public_plus_experimental_current.txt
M compose/ui/ui-text/api/restricted_1.0.0-beta06.txt
M compose/ui/ui-text/api/restricted_current.txt
A compose/ui/ui-text/src/commonMain/kotlin/androidx/compose/ui/text/Savers.kt
A compose/ui/ui-text/src/test/java/androidx/compose/ui/text/SaversTest.kt
M compose/ui/ui-unit/api/public_plus_experimental_1.0.0-beta06.txt
M compose/ui/ui-unit/api/public_plus_experimental_current.txt
M compose/ui/ui-unit/src/commonMain/kotlin/androidx/compose/ui/unit/TextUnit.kt
pr...@google.com <pr...@google.com> #3
Project: platform/frameworks/support
Branch: androidx-main
commit 3e6425cb44d32cd39f9bc7e1daacd78dfaa56552
Author: Siyamed Sinir <siyamed@google.com>
Date: Fri Apr 16 23:52:31 2021
Add LocaleList.Saver
Test: Added tests
Test: ./gradlew compose:ui:ui-text:test
Test: ./gradlew compose:ui:ui-text:cAT
Bug: 178446304
Change-Id: I24412b7f8e19191e2450c7241e256fd0fa47e9f7
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/textfield/TextFieldTest.kt
M compose/ui/ui-text/src/commonMain/kotlin/androidx/compose/ui/text/Savers.kt
M compose/ui/ui-text/src/test/java/androidx/compose/ui/text/SaversTest.kt
M compose/ui/ui-text/src/test/java/androidx/compose/ui/text/input/TextFieldValueTest.kt
https://android-review.googlesource.com/1678467
Branch: androidx-main
commit 3e6425cb44d32cd39f9bc7e1daacd78dfaa56552
Author: Siyamed Sinir <siyamed@google.com>
Date: Fri Apr 16 23:52:31 2021
Add LocaleList.Saver
Test: Added tests
Test: ./gradlew compose:ui:ui-text:test
Test: ./gradlew compose:ui:ui-text:cAT
Bug: 178446304
Change-Id: I24412b7f8e19191e2450c7241e256fd0fa47e9f7
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/textfield/TextFieldTest.kt
M compose/ui/ui-text/src/commonMain/kotlin/androidx/compose/ui/text/Savers.kt
M compose/ui/ui-text/src/test/java/androidx/compose/ui/text/SaversTest.kt
M compose/ui/ui-text/src/test/java/androidx/compose/ui/text/input/TextFieldValueTest.kt
Description
Sometimes we will get flaky test failures in Espresso when running code like the following:
composeTestRule.waitUntilExactlyOneExists(hasTestTag("someTag")).assertIsDisplayed()
Similarly, we will also see flaky failures when trying to click on a node:
composeTestRule.waitUntilExactlyOneExists(hasTestTag("someTag")).performClick()
The
performClick
call will execute, yet nothing will happen.Adding manual calls to
android.os.SystemClock.sleep()
, and/or using a while loop to repeatedly runassertIsDisplayed
addresses the issues for us but I believe there should be a public API for this.Link to kotlinlang Slack discussion: