Fixed
Status Update
Comments
bl...@google.com <bl...@google.com>
bl...@google.com <bl...@google.com>
an...@google.com <an...@google.com> #2
Should we transform it from
fun <FileTypeT: FileSystemLocation> add(
type: MultipleArtifact<FileTypeT>,
artifact: FileTypeT
)
to
fun <FileTypeT: FileSystemLocation, Appendable> add(
type: MultipleArtifact<FileTypeT>,
artifactProvider: Provider<FileTypeT>
)
should we also share with Artifacts interface: ArtifactsImpl.appendTo ArtifactsImpl.appendAll. They are not in use right now. Maybe part of another ticket?
mo...@google.com <mo...@google.com> #3
I don't think we can just move it to use a Provider<> as the original bug called for adding a file.
plus this add() would become just like to OperationRequest::toAppendTo no ?
Description
It seems NewApi linter does not understand if I assign
isAtleastU() && otherCondition()
to theprivate final boolean foo
in the constructor and haveif(foo) {//call U API}
.Linter was happy if I use local variable.
Actual code I hit this issue is that NewApi linter was not happy with patchset 16 but happy with patchset 17.
https://android-review.googlesource.com/c/platform/packages/modules/Connectivity/+/2764846/16..17/service/src/com/android/server/ConnectivityService.java
Linter was not happy with(patchset 16)
But Linter was happy with(patchset 17)
Also, Linter was happy with