Status Update
Comments
mi...@swiftkey.com <mi...@swiftkey.com> #2
Considering dynamic feature flavors and base app module flavors have to match, it would be great if this 'just worked', but I'm happy if there's a way to set it manually.
sp...@google.com <sp...@google.com>
je...@google.com <je...@google.com>
cm...@google.com <cm...@google.com> #3
There is code in studio that means this should 'just work' (the variant picked in dynamic features should just follow the main app) that has likely regressed.
cm...@google.com <cm...@google.com> #4
Ahmet - I know you were working on this area with the improved variant selection - is it possible that regressed selecting the variant in dynamic features that matches their base application?
mi...@swiftkey.com <mi...@swiftkey.com> #5
Just a note that this is still the case in Android Studio Iguana 8.3.0-rc02.
It also happens when I click the "Re-import with defaults" button. All the dynamic features get switched to the first alphabetically which it claims are the defaults.
It does work correctly when switching the variant of the app module though. All the dynamic features modules switch to the correct matching variant. However, we have a test module which stays on the old variant still.
mi...@swiftkey.com <mi...@swiftkey.com> #6
I have updated to Android Studio Koala 8.5.0 and Android Studio is still unable to pick the correct default variants for dynamic feature modules. These are often getting reset and causing two builds of our project whenever we try to run which is a huge time sync. Please consider taking a look at this issue. Thanks.
ak...@google.com <ak...@google.com> #7
Michael, thanks for the report. Do you know if this is a regression, or has it just never worked for you? It seems like it used to work pre 8.2, I just wanted to make sure. Replying to #4, it's entirely possible we regressed something that's not covered by tests.
I will have a look at this when I have some time.
mi...@swiftkey.com <mi...@swiftkey.com> #8
I don't recall it ever working, but I could be wrong.
Thanks
ak...@google.com <ak...@google.com> #9
I looked into this and now know why this is happening, and happy to report at least I didn't break it :) I will shortly send a fix.
mi...@swiftkey.com <mi...@swiftkey.com> #10
Thanks! I look forward to testing it out :)
ak...@google.com <ak...@google.com> #11
Please verify the fix on your end and mark the issue as "Fixed (Verified)" when you do so. Thanks!
mi...@swiftkey.com <mi...@swiftkey.com> #12
Thanks, I'll check it out when available.
Probably should have mentioned this earlier, but we actually have a similar issue with test modules. I guess it should pick up the default module from the targetProjectPath, but we also get the first alphabetically for those.
ak...@google.com <ak...@google.com> #13
Can you file a separate bug with some rudimentary repro steps for tracking purposes? Thanks!
mi...@swiftkey.com <mi...@swiftkey.com> #14
I've created a ticket over here for test modules
Thanks again
mi...@swiftkey.com <mi...@swiftkey.com> #15
Just tried this out in "Android Studio Ladybug | 2024.1.1 Nightly 2024-07-07" and it worked. Thank you!
ak...@google.com <ak...@google.com> #16
Glad to hear it's working. I will have a look at the other one too when I have some cycles.
an...@google.com <an...@google.com> #17
Thank you for your patience while our engineering team worked to resolve this issue. A fix for this issue is now available in:
- Android Studio Ladybug | 2024.1.3 Canary 1
- Android Gradle Plugin 8.7.0-alpha01
We encourage you to try the latest update.
If you notice further issues or have questions, please file a new bug report.
Thank you for taking the time to submit feedback — we really appreciate it!
Description
DESCRIBE THE ISSUE IN DETAIL:
STEPS TO REPRODUCE:
I believe someone needs to add
to DynamicFeatureProductFlavor. It already exists on ApplicationProductFlavor and LibraryProductFlavor. Thanks!
Studio Build: Version of Gradle Plugin: 8.1.2 Version of Gradle: 8.2.1 Version of Java: 17 OS: Mac Os