Fixed
Status Update
No update yet.
Comments
ra...@google.com
This lint check should apply to:
- onCreateView()
- onViewCreated()
- onActivityCreated()
- onViewStateRestored()
As all of those are called each time the fragment's view is created.
- onCreateView()
- onViewCreated()
- onActivityCreated()
- onViewStateRestored()
As all of those are called each time the fragment's view is created.
ra...@google.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit d26126d23175fc55c77788b95989f1ecc873eb9c
Author: Matthew Fraschilla <fraschilla@google.com>
Date: Mon Oct 07 13:05:15 2019
Add lint check for unsafe livedata observe in Fragments
A Fragment's lifecycle can last longer than its view resulting in
LiveData objects being observed longer than intended. This change
introduces a lint check to warn developers that they should use the
getViewLifecyclOwner() method as the LifecycleOwner when observing
LiveData objects.
Test: new FragmentLiveDataObserveDetectorTest
Bug: 137122478
Change-Id: If002f6be74d9b943f1b43cf2515b20337489b704
A fragment/fragment-lint/src/main/java/androidx/fragment/lint/FragmentLiveDataObserverDetector.kt
A fragment/fragment-lint/src/main/java/androidx/fragment/lint/LintUtils.kt
A fragment/fragment-lint/src/test/java/androidx/fragment/lint/FragmentLiveDataObserveDetectorTest.kt
A fragment/fragment-lint/src/test/java/androidx/fragment/lint/stubs/Stubs.kt
https://android-review.googlesource.com/1137099
https://goto.google.com/android-sha1/d26126d23175fc55c77788b95989f1ecc873eb9c
Branch: androidx-master-dev
commit d26126d23175fc55c77788b95989f1ecc873eb9c
Author: Matthew Fraschilla <fraschilla@google.com>
Date: Mon Oct 07 13:05:15 2019
Add lint check for unsafe livedata observe in Fragments
A Fragment's lifecycle can last longer than its view resulting in
LiveData objects being observed longer than intended. This change
introduces a lint check to warn developers that they should use the
getViewLifecyclOwner() method as the LifecycleOwner when observing
LiveData objects.
Test: new FragmentLiveDataObserveDetectorTest
Bug: 137122478
Change-Id: If002f6be74d9b943f1b43cf2515b20337489b704
A fragment/fragment-lint/src/main/java/androidx/fragment/lint/FragmentLiveDataObserverDetector.kt
A fragment/fragment-lint/src/main/java/androidx/fragment/lint/LintUtils.kt
A fragment/fragment-lint/src/test/java/androidx/fragment/lint/FragmentLiveDataObserveDetectorTest.kt
A fragment/fragment-lint/src/test/java/androidx/fragment/lint/stubs/Stubs.kt
Description
pepelsbey commented on Sep 16
Describe the bug
The following articles have videos that could not be played in Firefox on any platform because they’re encoded as HEVC/H.265:
To Reproduce
Steps to reproduce the behavior:
Expected behavior
Videos available in Firefox
Screenshots
Desktop:
Smartphone:
Additional context
Firefox
tropicadri commented last week
I am the author of the article, however I don't own the videos, they come from this article:https://developer.chrome.com/blog/entry-exit-animations/ I'm guessing they don't work there either? I'll pass the issue to Una in case she can fix them. Thanks.
pepelsbey commented last week
Yes, the pictures are broken in another article, too.
una linked a pull request 3 days ago that will close this issue