Using the spread operator for varargs with an array of zero length throws a ComposeRuntimeError [310004740]

Fixed

Bug

Status Update

No update yet.

Description

je...@gmail.com

created issue #1

Nov 10, 2023 04:40AM

Jetpack Compose version: Compose compiler versions 1.5.4
Jetpack Compose component used: N/A
Android Studio Build: Reproduced using Giraffe and Hedgehog
Kotlin version: 1.9.20

Steps to Reproduce or Code Sample to Reproduce:

Run the CrashMe() composable below:

@Composable
fun CrashMe() {
    var shouldCrash by remember { mutableStateOf(false) }

    LaunchedEffect(Unit) {
        delay(5000)
        shouldCrash = true
    }

    val dogList = if (shouldCrash) {
        listOf()
    } else {
        listOf(
            "bulldog",
            "poodle",
            "beagle"
        )
    }
    val dogs = dogList.toTypedArray()
    Arf(*dogs)
}

@Composable
fun Arf(vararg woof: String) {
    Log.i("Hello, doggies")
    for (bark in woof) {
        Log.i("woof: $woof")
    }
}

Stack trace (if applicable):

 FATAL EXCEPTION: main

 Process: com.jazarimusic.voloco, PID: 6665
 androidx.compose.runtime.ComposeRuntimeError: Compose Runtime internal error. Unexpected or incorrect use of the Compose internal runtime API (Expected to be at the end of a group). Please report to Google or use https://goo.gle/compose-feedback
 	at androidx.compose.runtime.ComposerKt.composeRuntimeError(Composer.kt:4557)
 	at androidx.compose.runtime.SlotWriter.endGroup(SlotTable.kt:3525)
 	at androidx.compose.runtime.ComposerKt$endGroupInstance$1.invoke(Composer.kt:4465)
 	at androidx.compose.runtime.ComposerKt$endGroupInstance$1.invoke(Composer.kt:4465)
 	at androidx.compose.runtime.CompositionImpl.applyChangesInLocked(Composition.kt:818)
 	at androidx.compose.runtime.CompositionImpl.applyChanges(Composition.kt:849)
 	at androidx.compose.runtime.Recomposer$runRecomposeAndApplyChanges$2$1.invoke(Recomposer.kt:625)
 	at androidx.compose.runtime.Recomposer$runRecomposeAndApplyChanges$2$1.invoke(Recomposer.kt:537)
 	at androidx.compose.ui.platform.AndroidUiFrameClock$withFrameNanos$2$callback$1.doFrame(AndroidUiFrameClock.android.kt:41)
 	at androidx.compose.ui.platform.AndroidUiDispatcher.performFrameDispatch(AndroidUiDispatcher.android.kt:109)
 	at androidx.compose.ui.platform.AndroidUiDispatcher.access$performFrameDispatch(AndroidUiDispatcher.android.kt:41)
 	at androidx.compose.ui.platform.AndroidUiDispatcher$dispatchCallback$1.doFrame(AndroidUiDispatcher.android.kt:69)
 	at android.view.Choreographer$CallbackRecord.run(Choreographer.java:1341)
 	at android.view.Choreographer$CallbackRecord.run(Choreographer.java:1352)
 	at android.view.Choreographer.doCallbacks(Choreographer.java:952)
 	at android.view.Choreographer.doFrame(Choreographer.java:878)
 	at android.view.Choreographer$FrameDisplayEventReceiver.run(Choreographer.java:1326)
 	at android.os.Handler.handleCallback(Handler.java:958)
 	at android.os.Handler.dispatchMessage(Handler.java:99)
 	at android.os.Looper.loopOnce(Looper.java:205)
 	at android.os.Looper.loop(Looper.java:294)
 	at android.app.ActivityThread.main(ActivityThread.java:8194)
 	at java.lang.reflect.Method.invoke(Native Method)
 	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:552)
 	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:971)
 	Suppressed: kotlinx.coroutines.internal.DiagnosticCoroutineContextException: [androidx.compose.runtime.PausableMonotonicFrameClock@8b028ae, androidx.compose.ui.platform.MotionDurationScaleImpl@3fa864f, StandaloneCoroutine{Cancelling}@6b171dc, AndroidUiDispatcher@666b2e5]

Comments

as...@google.com <as...@google.com> Nov 10, 2023 02:12PM

Reassigned to as...@google.com.

as...@google.com <as...@google.com> #2Nov 10, 2023 04:54PM

Reassigned to ch...@google.com.

Hi, was this a regression after you upgrade your NDK or upgrade your Android Studio?

as...@google.com <as...@google.com> #3Nov 10, 2023 04:57PM

Neither of them. There were no change to AS (4.1-RC1) nor NDK versions.

I just changed my old scripts in build.gradle to the android recommended method i.e.

externalNativeBuild { ndkBuild { path file('jni/Android.mk') } }

If I reverted the change to my old script, everything is working again. The old scripts uses

ndk.dir=/opt/android/android-sdk/ndk-bundle

as defined in local.properties file

The source.properties files indicate the version as:

Pkg.Desc = Android NDK Pkg.Revision = 21.3.6528147

al...@google.com <al...@google.com> #4Nov 21, 2024 07:06PM

Hi, the problem is that when Android Gradle Plugin executes ndk-build, it is missing the '-C' + projectDir + '/jni' part in your custom task. Therefore, the current working directory is the module root (parent of the jni directory). Hence the error.

The fix is to add the following to your build.gradle

android {
    ...
    defaultConfig {
        ...
        externalNativeBuild {
            ndkBuild {
                arguments "-Cjni"
            }
        }
    }
}

Please reopen the bug if you have further issues. Thanks!

ch...@google.com <ch...@google.com> #5Jan 10, 2025 10:26PM

Reassigned to as...@google.com.

Please provide the full syntax for the externalNativeBuild scripts. gradle sync throws the following error message when I added the recommended argument statement to the script (or change to arguments('-Cjni'))

A problem occurred evaluating project ':aTalk'.

No signature of method: build_6xrerbyg3j4aatiomvrbavr6i.android() is applicable for argument types: (build_6xrerbyg3j4aatiomvrbavr6i$_run_closure4) values: [build_6xrerbyg3j4aatiomvrbavr6i$_run_closure4@497bb461]

externalNativeBuild {
    ndkBuild {
        path file('jni/Android.mk')
        arguments "-Cjni"
    }
}

as...@google.com <as...@google.com> #6Jan 23, 2025 09:20PM

Marked as fixed.

There are actually two different types of exteranlNativeBuild blocks. The block in #4 needs to be put inside defaultConfig. So you would end up with something like

android {
    ...
    defaultConfig {
        ...
        externalNativeBuild {
            ndkBuild {
                arguments "-Cjni"
            }
        }
    }
    ...
    externalNativeBuild {
        ndkBuild {
            path file('jni/Android.mk')
        }
    }
}

Issue 310004740