IssueTracker

I'm investigating a bug in the application that happens mainly on AOSP based ROMs and it seems that I found some controversy between documentation and code.

First of all, let's see the doc on TelecommManager for getUserSelectedOutgoingPhoneAccount() method. The doc says that the caller requires only Manifest.permission.READ_PHONE_STATE.

Here is implementation of this method. It forwards the call to the actual Service implementation supplying it with the calling package name.

Here is the actual implementation in the service. In line 155 we can see a call to the isDialerOrPrivileged method. First of all, the second argument is the string "getDefaultOutgoingPhoneAccount" which is going to be in error message and misleads the following log analysis because this is the name of the neighbouring method.

But the main trouble is that isDialerOrPrivileged checks for READ_PRIVILEGED_PHONE_STATE and fails otherwise. This contradicts to the documentation which requires only READ_PHONE_STATE permission.

How this applies to the bug which I'm investigating? Well, the app tries to produce the ringtone and fails to do so with the following stacktrace:

java.lang.SecurityException: getDefaultOutgoingPhoneAccount: Neither user 10412 nor current process has android.permission.READ_PRIVILEGED_PHONE_STATE.
android.os.Parcel.createExceptionOrNull(Parcel.java:3028)
android.os.Parcel.createException(Parcel.java:3012)
android.os.Parcel.readException(Parcel.java:2995)
android.os.Parcel.readException(Parcel.java:2937)
com.android.internal.telecom.ITelecomService$Stub$Proxy.getUserSelectedOutgoingPhoneAccount(ITelecomService.java:1492)
android.telecom.TelecomManager.getUserSelectedOutgoingPhoneAccount(TelecomManager.java:1138)
android.media.RingtoneManager.getDefaultPhoneAccountHandle(RingtoneManager.java:921)
android.media.RingtoneManager.getCacheForType(RingtoneManager.java:1082)
android.media.MediaPlayer.setDataSource(MediaPlayer.java:1084)
android.media.MediaPlayer.setDataSource(MediaPlayer.java:1023)

See the getDefaultOutgoingPhoneAccount in the first line? This is the wrong second argument passed to the isDialerOrPrivileged method. The actual method called is getUserSelectedOutgoingPhoneAccount which is reported on the 6th line.