TraceSectionMetric label parameter should be after mode [315830077]

Fixed

Feature Request

Status Update

No update yet.

Description

ml...@google.com

created issue #1

Dec 11, 2023 07:39PM

Component used: Macrobench 1.3.0-SNAPSHOT

Sorry, should've found this in the aosp/2853596 .

I think the label param should be after the mode param, because it forces using mode with named argument, or needs to be defined.

// works
TraceSectionMetric("Jit Compiling %")
TraceSectionMetric("Jit Compiling %", "jit_compiling"),
TraceSectionMetric("Jit Compiling %", "jit_compiling", Mode.Sum),

// doesn't work
TraceSectionMetric("installApk%", Mode.First)

// works, but requires named args
TraceSectionMetric("installApk%", mode=Mode.First, targetPackageOnly=false)

I suggest putting the label as the last argument, because it's the least likely to be defined.

Comments

ap...@google.com <ap...@google.com> #2Mar 25, 2024 09:24PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main

commit e00e48d640640748691e944f3e38091f8fa7e725
Author: Chris Craik <ccraik@google.com>
Date: Thu Mar 21 14:18:46 2024

TraceSectionMetric API improvements

Fixes: 315830077
Fixes: 322167531
Test: TraceSectionMetricTest
Relnote: "Added TraceSectionMetric.Average and .Count, and reordered
args so the more common argument (mode) was earlier in the arg list,
reducing need for specifying parameter names."

Also adds sample for TraceSectionMetric, and remove
no-longer-important internal shader metrics.

Change-Id: Ibf0b0b5a791460b6d37a4ef43dc369d6c8414ab7

M benchmark/benchmark-macro/api/current.txt
M benchmark/benchmark-macro/api/restricted_current.txt
M benchmark/benchmark-macro/src/androidTest/java/androidx/benchmark/macro/TraceSectionMetricTest.kt
M benchmark/benchmark-macro/src/main/java/androidx/benchmark/macro/Metric.kt
M compose/integration-tests/macrobenchmark/src/main/java/androidx/compose/integration/macrobenchmark/SmallListStartupBenchmark.kt
M compose/integration-tests/macrobenchmark/src/main/java/androidx/compose/integration/macrobenchmark/TrivialPerfettoSdkBenchmark.kt
M compose/integration-tests/macrobenchmark/src/main/java/androidx/compose/integration/macrobenchmark/TrivialStartupPerfettoSdkBenchmark.kt
M testutils/testutils-macrobenchmark/src/main/java/androidx/testutils/MacrobenchUtils.kt

https://android-review.googlesource.com/3008896

na...@google.com <na...@google.com> #3Apr 17, 2024 05:17PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.benchmark:benchmark-macro:1.3.0-alpha03

Issue 315830077

Description

Issue summary

Comments

ap...@google.com <ap...@google.com> #2Mar 25, 2024 09:24PM

na...@google.com <na...@google.com> #3Apr 17, 2024 05:17PM

Add comment

Issue metadata