Status Update
No update yet.
Comments
ma...@google.com
se...@google.com
I think there are a number of existing issues already requesting this (particularly for the nullability annotations). The blocker for this is that metalava needs to support typeuse annotations, and it doesn't yet (and it's a nontrivial amount of work; there is partial support in there behind a compile-time flag, but it's not complete.)
da...@gmail.com
Kotlin's AnnotationTarget.TYPE maps to Java's ElementType.TYPE_USE, which was added in SDK 26. If we use this in Java code, we will likely need to do one of the following:
- Require
minSdkVersion=26-- which is too high at this point in time - Advise clients to enable core library desugaring -- which I think still has client usability issues
- Advise clients to ignore
javacclass resolution warnings -- which we're already getting flak for with Kotlin
Tor, do you see any better option here?
da...@well.co
And, of course, that Metalava doesn't support typeuse annotations yet. But we (AndroidX) have more control over when that happens.
se...@google.com
I think all of the androidx annotations are compile or class retention, not runtime retention, so there probably aren't any minSdkVersion requirements?
ap...@google.com
Ah, yes, good point -- the errors I saw for other annotations were due to Kotlin's Metadata which is runtime retention. We may still need to add Proguard rules, though, to avoid resolution warnings coming out of bytecode optimizers.
Description
It states:
They can be dismissed by:
Using a close affordance within the bottom sheet’s top app bar, if available
Display a close affordance in a full-screen modal bottom sheet.
The above is the link of what to do in that situation but I think there is more clarification needed and maybe there is multiple ways Material recommends to do this?
Is this saying there should be a collapse icon in the app bar as I do not see it. Should we include an x icon in the content of the bottomsheet / replace the drag handle with it?
The full expanded modal bottomsheet on the material sample app maintains a drag handle and does not merge into the top bar (see screenshot)