Full height Modal Bottom Sheet best practices clarification and doc update request [321877275]

Assigned

Bug

Status Update

No update yet.

Description

da...@gmail.com

created issue #1

Jan 23, 2024 05:27PM

Reviewing the modal bottom sheet spec here I am not clear on exactly what happens in different cases where the modal bottom sheet is full height

https://m3.material.io/components/bottom-sheets/guidelines#22deb8a2-3513-4a2e-aa47-c64875e15e12

It states:

They can be dismissed by:

Using a close affordance within the bottom sheet’s top app bar, if available

Display a close affordance in a full-screen modal bottom sheet.

The above is the link of what to do in that situation but I think there is more clarification needed and maybe there is multiple ways Material recommends to do this?

Is this saying there should be a collapse icon in the app bar as I do not see it. Should we include an x icon in the content of the bottomsheet / replace the drag handle with it?

The full expanded modal bottomsheet on the material sample app maintains a drag handle and does not merge into the top bar (see screenshot)

Screenshot_20240123-112546.png

108 KB

View

Download

Comments

ma...@google.com <ma...@google.com> Jan 23, 2024 09:11PM

Reassigned to ma...@google.com.

se...@google.com <se...@google.com> #2May 15, 2024 07:29PM

Project: platform/frameworks/support
Branch: androidx-main

commit e40004b9e772b5e4e66a8dcdc3d2e2a1628108ad
Author: José Figueroa Santos <serniebanders@google.com>
Date: Tue Mar 21 14:39:09 2023

[M3][BottomSheetScaffold] Adds Hidden state boolean flag to sheet state.

This enables standardBottomSheet to implement a fully Hidden state should the user choose to.

Additionally adds documentation to SheetState.requireOffset(), and updates BottomSheetDefaults.MinimizedShape -> BottomSheetDefaults.HiddenShape

Bug: 274463511
Bug: 273870234
Test: Tests updated Hidden functionality for BottomSheetScaffold
Test: Preserves existing unit tests where Hidden state does not exist
RelNote: SheetState now has optional skipHiddenState parameter
RelNote: rememberStandardBottomSheetState now has optional skipHiddenState parameter
RelNote: BottomSheetScaffold now has a defined Hidden anchor, though it is disabled by default
RelNote: SheetState.requireOffset documentation has been updated
RelNote: BottomSheetDefaults.MinimizedShape has been renamed as BottomSheetDefaults.HiddenShape
Change-Id: I839f464c556eafb1b6fd823134da46943475919d

M compose/material3/material3/api/public_plus_experimental_1.1.0-beta01.txt
M compose/material3/material3/api/public_plus_experimental_current.txt
M compose/material3/material3/src/androidAndroidTest/kotlin/androidx/compose/material3/BottomSheetScaffoldTest.kt
M compose/material3/material3/src/androidAndroidTest/kotlin/androidx/compose/material3/ModalBottomSheetTest.kt
M compose/material3/material3/src/androidMain/kotlin/androidx/compose/material3/Strings.android.kt
M compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/BottomSheetScaffold.kt
M compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/ModalBottomSheet.kt
M compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/SheetDefaults.kt
M compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/Strings.kt
M compose/material3/material3/src/desktopMain/kotlin/androidx/compose/material3/Strings.desktop.kt

https://android-review.googlesource.com/2500395

da...@gmail.com <da...@gmail.com> #3May 16, 2024 12:33AM

Resolved as of next release. Please note the default behavior for BottomSheetScaffold will still be to not allow Hidden value, but this can be overriden with a new flag for the State object. This is because StandardBottomSheet by design should generally coexist with the UI, in a Partially or fully expanded state.

da...@well.co <da...@well.co> #4May 21, 2024 02:17PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.compose.material3:material3:1.1.0-beta02

se...@google.com <se...@google.com> #5Jul 24, 2024 06:38PM

Reassigned to lu...@google.com.

I'm facing this issue again in the new version of material3 1.2.0.alpha-05, It was working fine until alpha-04 but the moment I change it to 05 the app crashes and I get this error. I am also facing this issue if I change the foundation version from 1.6.0-alpha02 to 1.6.0-alpha03

ap...@google.com <ap...@google.com> #6Oct 2, 2024 07:56PM

Same here as described in #5 the issue seems back in 1.2.0-alpha05 and was working fine on 1.2.0-alpha04 and before. However, this time it doesn't seem to be working even with the defaults (which uses PartiallyExpanded as initialState internally). I've created a new bug ticket for this: b/296707223.

Issue 321877275