Lint K2 UAST: pointer already disposed [325146674]

WAI

Bug

Status Update

No update yet.

Description

za...@gmail.com

created issue #1

Feb 14, 2024 06:55AM

When using useK2Uast in Lint (version 8.4.0-alph09), I see the following crash in this PR for the MoshiUsageDetector.valid_adapters test.

To run: hardcode the param to setUseK2Uast() in BaseSlackLintTest then run the test.

class org.jetbrains.kotlin.analysis.api.fir.symbols.pointers.KtFirMemberFunctionSymbolPointer pointer already disposed
org.jetbrains.kotlin.utils.exceptions.KotlinIllegalArgumentExceptionWithAttachments: class org.jetbrains.kotlin.analysis.api.fir.symbols.pointers.KtFirMemberFunctionSymbolPointer pointer already disposed
	at org.jetbrains.kotlin.light.classes.symbol.SymbolLightUtilsKt.restoreSymbolOrThrowIfDisposed(symbolLightUtils.kt:440)
	at org.jetbrains.kotlin.light.classes.symbol.annotations.SymbolAnnotationsProvider.annotationInfos(SymbolAnnotationsProvider.kt:103)
	at org.jetbrains.kotlin.light.classes.symbol.annotations.GranularAnnotationsBox.getOrComputeCachedAnnotations(GranularAnnotationsBox.kt:28)
	at org.jetbrains.kotlin.light.classes.symbol.annotations.GranularAnnotationsBox.annotationsArray(GranularAnnotationsBox.kt:44)
	at org.jetbrains.kotlin.light.classes.symbol.modifierLists.SymbolLightModifierList.getAnnotations(SymbolLightModifierList.kt:49)
	at com.intellij.psi.PsiJvmConversionHelper.getListAnnotations(PsiJvmConversionHelper.java:47)
	at com.intellij.psi.PsiModifierListOwner.getAnnotations(PsiModifierListOwner.java:36)
	at com.intellij.psi.PsiJvmModifiersOwner.getAnnotations(PsiJvmModifiersOwner.java:21)
	at org.jetbrains.uast.kotlin.FirKotlinUastResolveProviderService.getPsiAnnotations(FirKotlinUastResolveProviderService.kt:187)
	at org.jetbrains.uast.kotlin.KotlinUMethod.getUAnnotations(KotlinUMethod.kt:75)
	at org.jetbrains.uast.UMethod.accept(UMethod.kt:43)
	at org.jetbrains.uast.internal.ImplementationUtilsKt.acceptList(implementationUtils.kt:15)
	at org.jetbrains.uast.kotlin.AbstractKotlinUClass.accept(AbstractKotlinUClass.kt:171)
	at org.jetbrains.uast.internal.ImplementationUtilsKt.acceptList(implementationUtils.kt:15)
	at org.jetbrains.uast.UFile.accept(UFile.kt:89)
	at com.android.tools.lint.detector.api.UastLintUtilsKt.acceptSourceFile(UastLintUtils.kt:932)
	at com.android.tools.lint.checks.infrastructure.ResolveCheckerKt.checkFile(ResolveChecker.kt:103)
	at com.android.tools.lint.checks.infrastructure.TestLintClient$2.parse(TestLintClient.java:902)
	at com.android.tools.lint.client.api.UElementVisitor.visitFile(UElementVisitor.kt:233)
	at com.android.tools.lint.client.api.LintDriver$visitUastDetectors$1.run(LintDriver.kt:2184)
	at com.android.tools.lint.client.api.LintClient.runReadAction(LintClient.kt:1802)
	at com.android.tools.lint.checks.infrastructure.TestLintClient.runReadAction(TestLintClient.java:915)
	at com.android.tools.lint.client.api.LintDriver$LintClientWrapper.runReadAction(LintDriver.kt:2900)
	at com.android.tools.lint.client.api.LintDriver.visitUastDetectors(LintDriver.kt:2184)
	at com.android.tools.lint.client.api.LintDriver.visitUast(LintDriver.kt:2146)
	at com.android.tools.lint.client.api.LintDriver.runFileDetectors(LintDriver.kt:1392)
	at com.android.tools.lint.client.api.LintDriver.checkProject(LintDriver.kt:1157)
	at com.android.tools.lint.client.api.LintDriver.checkProjectRoot(LintDriver.kt:628)
	at com.android.tools.lint.client.api.LintDriver.access$checkProjectRoot(LintDriver.kt:177)
	at com.android.tools.lint.client.api.LintDriver$analyze$1.invoke(LintDriver.kt:430)
	at com.android.tools.lint.client.api.LintDriver$analyze$1.invoke(LintDriver.kt:427)
	at com.android.tools.lint.client.api.LintDriver.doAnalyze(LintDriver.kt:507)
	at com.android.tools.lint.client.api.LintDriver.doAnalyze$default(LintDriver.kt:483)
	at com.android.tools.lint.client.api.LintDriver.analyze(LintDriver.kt:427)
	at com.android.tools.lint.checks.infrastructure.TestLintClient.analyze(TestLintClient.java:675)
	at com.android.tools.lint.checks.infrastructure.TestLintClient.analyze(TestLintClient.java:606)
	at com.android.tools.lint.checks.infrastructure.TestLintClient.checkLint(TestLintClient.java:338)
	at com.android.tools.lint.checks.infrastructure.TestLintRunner.checkLint(TestLintRunner.kt:334)
	at com.android.tools.lint.checks.infrastructure.TestLintRunner.runMode(TestLintRunner.kt:285)
	at com.android.tools.lint.checks.infrastructure.TestLintRunner.runMode(TestLintRunner.kt:233)
	at com.android.tools.lint.checks.infrastructure.TestLintRunner.runMode$default(TestLintRunner.kt:202)
	at com.android.tools.lint.checks.infrastructure.TestLintRunner.run(TestLintRunner.kt:139)
	at com.android.tools.lint.checks.infrastructure.TestLintTask.run(TestLintTask.java:1126)
	at slack.lint.MoshiUsageDetectorTest.valid_adapters(MoshiUsageDetectorTest.kt:1221)

Comments

ar...@google.com <ar...@google.com> Feb 15, 2024 01:15AM

Assigned to an...@google.com.

js...@google.com <js...@google.com> Feb 15, 2024 05:14AM

Reassigned to js...@google.com.

js...@google.com <js...@google.com> #2Feb 16, 2024 08:26AM

Status: Won't Fix (Intended Behavior)

Setting a debugging point on that KotlinIllegalArgumentExceptionWithAttachments, I spotted that that KtFirMemberFunctionSymbolPointer is data class's synthetic member, component1; tried to reproduce that in upstream Kotlin repo (SLC, symbol light class, level), IntelliJ repo (UAST level), and Lint level, no luck.

Then noticed that... https://github.com/slackhq/slack-lints/blob/main/slack-lint-checks/src/test/java/slack/lint/MoshiUsageDetectorTest.kt#L1197-L1204

          @AdaptedBy(NotAnAdapter::class)
          class Example3

          @JsonClass(generateAdapter = true)
          data class Example3(
            @AdaptedBy(CustomAdapter::class) val value1: String,
            @AdaptedBy(NotAnAdapter::class) val value2: String
          )

If you rename one of them to a different class name, things go well.

Update: note that there is Example4 below them...

Message last modified on Feb 16, 2024 08:31AM

za...@gmail.com <za...@gmail.com> #3Feb 16, 2024 10:25PM

Ah! Good spot, sorry for the false alarm!

js...@google.com <js...@google.com> #4Feb 16, 2024 10:47PM

This is just another example of how generous K1's error handling is, but maybe too much. :)

On the flip side, K2's error handling is far behind to catch up... Who can imagine symbol restoration in Analysis API is actually caused by duplicate class names?!

jw...@squareup.com <jw...@squareup.com> #5Oct 17, 2024 05:29PM

I ran into this same crash today upgrading Okio. https://github.com/square/okio/actions/runs/11387764679/job/31683136228?pr=1535

Would you consider adding debug information to the exception message? I suspect our project might have duplicate declarations, but I don’t know where to look to find 'em.

js...@google.com <js...@google.com> #6Oct 17, 2024 06:11PM

^ Yeah, fair request. I filed https://youtrack.jetbrains.com/issue/KT-72386