Assigned
Status Update
No update yet.
Comments
ap...@google.com
Project: chromiumos/platform2
Branch: main
commit 60dd096f85bf6e62c0246a09b8af16d280134747
Author: Dmitry Torokhov <dtor@chromium.org>
Date: Fri Feb 09 22:18:54 2024
system_api: concierge: add VmStartingUpSignal definition
Concierge was using ExtendedVmInfo as a payload to VmStartingUpSignal.
However at the time this signal is emitted VM is not fully constructed
yet and VmInfo is not fully populated. To avoid confusion what parts of
VM info are available at what point, let's use dedicated structure for
the payload.
BUG=b:325620275
TEST=CQ
Change-Id: Ieed1824b4cbd4cede088f6fe94d8056282e59864
Reviewed-on:https://chromium-review.googlesource.com/c/chromiumos/platform2/+/5304737
Reviewed-by: Junichi Uekawa <uekawa@chromium.org>
Auto-Submit: Dmitry Torokhov <dtor@chromium.org>
Tested-by: Dmitry Torokhov <dtor@chromium.org>
Commit-Queue: Junichi Uekawa <uekawa@chromium.org>
M system_api/dbus/vm_concierge/concierge_service.proto
https://chromium-review.googlesource.com/5304737
Branch: main
commit 60dd096f85bf6e62c0246a09b8af16d280134747
Author: Dmitry Torokhov <dtor@chromium.org>
Date: Fri Feb 09 22:18:54 2024
system_api: concierge: add VmStartingUpSignal definition
Concierge was using ExtendedVmInfo as a payload to VmStartingUpSignal.
However at the time this signal is emitted VM is not fully constructed
yet and VmInfo is not fully populated. To avoid confusion what parts of
VM info are available at what point, let's use dedicated structure for
the payload.
BUG=b:325620275
TEST=CQ
Change-Id: Ieed1824b4cbd4cede088f6fe94d8056282e59864
Reviewed-on:
Reviewed-by: Junichi Uekawa <uekawa@chromium.org>
Auto-Submit: Dmitry Torokhov <dtor@chromium.org>
Tested-by: Dmitry Torokhov <dtor@chromium.org>
Commit-Queue: Junichi Uekawa <uekawa@chromium.org>
M system_api/dbus/vm_concierge/concierge_service.proto
ap...@google.com
Project: chromiumos/platform2
Branch: main
commit 779a77f7592fe7d38eaf44c1e96495c529fccf22
Author: Dmitry Torokhov <dtor@chromium.org>
Date: Fri Feb 09 22:18:54 2024
vm_tools: concierge: use VmStartingUpSignal proto
Concierge was using ExtendedVmInfo as a payload to VmStartingUpSignal.
However at the time this signal is emitted VM is not fully constructed
yet and VmInfo is not fully populated. To avoid confusion what parts of
VM info are available at what point, let's use dedicated structure for
the payload.
BUG=b:325620275
TEST=CQ, run several VMs and inspect the logs to ensure that the new
signal is parsed properly.
Change-Id: Ifae2ac537c03e15639a09cd36b0c16d4edcfc42b
Reviewed-on:https://chromium-review.googlesource.com/c/chromiumos/platform2/+/5304738
Auto-Submit: Dmitry Torokhov <dtor@chromium.org>
Reviewed-by: Junichi Uekawa <uekawa@chromium.org>
Tested-by: Dmitry Torokhov <dtor@chromium.org>
Commit-Queue: Dmitry Torokhov <dtor@chromium.org>
M vm_tools/concierge/service.cc
M vm_tools/dbus_bindings/org.chromium.VmConcierge.xml
M vm_tools/syslog/log_pipe.cc
https://chromium-review.googlesource.com/5304738
Branch: main
commit 779a77f7592fe7d38eaf44c1e96495c529fccf22
Author: Dmitry Torokhov <dtor@chromium.org>
Date: Fri Feb 09 22:18:54 2024
vm_tools: concierge: use VmStartingUpSignal proto
Concierge was using ExtendedVmInfo as a payload to VmStartingUpSignal.
However at the time this signal is emitted VM is not fully constructed
yet and VmInfo is not fully populated. To avoid confusion what parts of
VM info are available at what point, let's use dedicated structure for
the payload.
BUG=b:325620275
TEST=CQ, run several VMs and inspect the logs to ensure that the new
signal is parsed properly.
Change-Id: Ifae2ac537c03e15639a09cd36b0c16d4edcfc42b
Reviewed-on:
Auto-Submit: Dmitry Torokhov <dtor@chromium.org>
Reviewed-by: Junichi Uekawa <uekawa@chromium.org>
Tested-by: Dmitry Torokhov <dtor@chromium.org>
Commit-Queue: Dmitry Torokhov <dtor@chromium.org>
M vm_tools/concierge/service.cc
M vm_tools/dbus_bindings/org.chromium.VmConcierge.xml
M vm_tools/syslog/log_pipe.cc
Description