SourceDirectories.addGeneratedSourceDirectory is not friendly to multiple variants [327399383]

Assigned

Bug

Status Update

No update yet.

Description

xa...@google.com

created issue #1

Feb 28, 2024 04:22PM

SourceDirectories.addGeneratedSourceDirectory works the same way as the artifact API and takes over the output for the tasks. For example in the addCustomSourceFolders recipe, even though we set the output to a specific location (toml/gen), running the verification task shows that the location is changed to build/generated/toml/debugAddCustomSources.

It does in fact work if you pass this to multiple variants. For instance changing the recipe to something like this:

val addSourceTaskProvider =  project.tasks.register<AddCustomSources>("addCustomSources") {
    outputFolder.set(File(project.layout.buildDirectory.asFile.get(), "toml/gen"))
}

androidComponents.onVariants { variant ->

    variant.sources.getByName("toml").also {
        // adding custom folders (static and generated) to `toml` source type
        it.addGeneratedSourceDirectory(addSourceTaskProvider, AddCustomSources::outputFolder)
    }
}

will in fact works. However the look of the API make it looks like it would not work.

Part of this is the way some of our other APIs work (for example transforms on Artifact are very variant specific).

At the very least we should document that it can in fact be used for multiple variantss. We should also consider making it more obvious (maybe the API just needs to receive a Provider<Directory>, though I think there are potentially issue as the location should be in build/?)

Comments

ma...@gmail.com <ma...@gmail.com> #2Feb 28, 2024 04:34PM

Hi, thanks for reaching out and reporting this issue! Can you check and verify if you're seeing the same error when using API explorer link?

je...@google.com <je...@google.com> Aug 29, 2024 05:23PM

Accepted by je...@google.com.

je...@google.com <je...@google.com> #3Aug 29, 2024 07:52PM

Hi,

Thank you for quick response. Yes, I actually copied curl code above from the API explorer.

I also tried with Python code below:

request = youtube.search().list(
    part="snippet",
    maxResults=50,
    order="viewCount",
    publishedAfter="2024-09-01T00:00:00Z",
    q="artificial intelligence",
    videoPaidProductPlacement="true",
)
response = request.execute()
return response

This also gave me invalid parameter error:

TypeError: Got an unexpected keyword argument videoPaidProductPlacement

je...@google.com <je...@google.com> #4Sep 4, 2024 10:13PM

Marked as fixed.

Hello,

I wanted to check if there are any updates regarding this issue, as it is critical for my application. Could you share whether it's planned to be resolved and if there is an estimated timeline for a fix?

I would greatly appreciate any insights you can provide.

Thank you for your time and support.

an...@google.com <an...@google.com> #5Sep 9, 2024 10:44PM

Thank you for your patience while our engineering team worked to resolve this issue. A fix for this issue is now available in:

Android Studio Ladybug Feature Drop | 2024.2.2 Canary 1
Android Gradle Plugin 8.8.0-alpha01

We encourage you to try the latest update.

If you notice further issues or have questions, please file a new bug report.

Thank you for taking the time to submit feedback — we really appreciate it!

je...@google.com <je...@google.com> #6Sep 16, 2024 06:32PM

Status: Assigned (reopened)

after more conversations, we decided that we might want to go to a different direction to continue providing a good IDE experience. I will rollback the change mentioned above until we can design something that fits the requirements.

Issue 327399383