IssueTracker

When trying to test out the misc-include-cleaner fix to see how well it would (or wouldn't) work on my package, I discovered that the fix doesn't actually work because when attempting to log a warning about overlapping fixes it instead crashes with an exception:

lint_package: Unhandled exception:
Traceback (most recent call last):
  File "/mnt/host/source/chromite/bin/lint_package", line 213, in <module>
    DoMain()
  File "/mnt/host/source/chromite/bin/lint_package", line 209, in DoMain
    commandline.ScriptWrapperMain(FindTarget)
  File "/mnt/host/source/chromite/lib/commandline.py", line 1571, in ScriptWrapperMain
    ret = target(argv[1:])
  File "/mnt/host/source/chromite/scripts/lint_package.py", line 563, in main
    fixed_lints, modified_files = apply_fixes(
  File "/mnt/host/source/chromite/scripts/lint_package.py", line 269, in apply_fixes
    fixes_by_file, lints_fixed = get_noconflict_fixes(lints, allowed_subdirs)
  File "/mnt/host/source/chromite/scripts/lint_package.py", line 196, in get_noconflict_fixes
    "\n\t".join(files_with_overlap),
TypeError: sequence item 0: expected str instance, PosixPath found

Now the fixes probably wouldn't have quite worked the way I wanted anyway due to some of them being discarded due to overlap, but the crash means it doesn't even get that far, it just fails.

In this particular case the command I was trying to run was:

lint_package --board=${BOARD} --apply-fixes --filter-names=misc-include-cleaner \
    --restrict-fix-subdirs=cryptohome chromeos-base/cryptohome

However, I suspect you could reproduce this with any --apply-fixes command that had overlapping suggestions.