Status Update
Comments
du...@google.com <du...@google.com> #2
George - any chance you have an opinion here? My guess is that we could add this, but probably don't want to as we need to draw the line somewhere.
d-...@yandex-team.ru <d-...@yandex-team.ru> #3
py...@gmail.com <py...@gmail.com> #4
I just filed
mo...@google.com <mo...@google.com> #5
There is a script to add value class
collections generateValueClassCollections.sh
that works for both sets and lists. I think it is reasonable to expose these.
I do think it is reasonable to expose the packedValue
for value types so that this can be done.
mo...@google.com <mo...@google.com> #6
Dustin, do you have a recommendation for exposing the scripts/templates?
du...@google.com <du...@google.com> #7
Exposing packedValue seems reasonable to me. George already put up a CL for this here: aosp/3094908
ap...@google.com <ap...@google.com> #8
Branch: androidx-main
commit 2c947e6474a89b230eb6f7acae460a9059b006c1
Author: George Mount <mount@google.com>
Date: Tue May 21 09:21:11 2024
Expose packedValue properties of IntIntPair and FloatFloatPair
Fixes: 331853566
Relnote: "Exposed the packedValue internal representation for IntIntPair
and FloatFloatPair."
Test: new tests
Change-Id: Ifeb75cb8ea63d2b5c23d78640fd76bf81ec4f090
M collection/collection/api/current.txt
M collection/collection/api/restricted_current.txt
M collection/collection/src/commonMain/kotlin/androidx/collection/FloatFloatPair.kt
M collection/collection/src/commonMain/kotlin/androidx/collection/IntIntPair.kt
M collection/collection/src/commonTest/kotlin/androidx/collection/PairTest.kt
pr...@google.com <pr...@google.com> #9
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.collection:collection:1.5.0-alpha01
androidx.collection:collection-iosarm64:1.5.0-alpha01
androidx.collection:collection-iossimulatorarm64:1.5.0-alpha01
androidx.collection:collection-iosx64:1.5.0-alpha01
androidx.collection:collection-jvm:1.5.0-alpha01
androidx.collection:collection-linuxarm64:1.5.0-alpha01
androidx.collection:collection-linuxx64:1.5.0-alpha01
androidx.collection:collection-macosarm64:1.5.0-alpha01
androidx.collection:collection-macosx64:1.5.0-alpha01
androidx.collection:collection-tvosarm64:1.5.0-alpha01
androidx.collection:collection-tvossimulatorarm64:1.5.0-alpha01
androidx.collection:collection-tvosx64:1.5.0-alpha01
androidx.collection:collection-watchosarm32:1.5.0-alpha01
androidx.collection:collection-watchosarm64:1.5.0-alpha01
androidx.collection:collection-watchossimulatorarm64:1.5.0-alpha01
androidx.collection:collection-watchosx64:1.5.0-alpha01
Description
Version used: 1.4.0
Devices/Android versions reproduced on: any
It would be beneficial to have the ability to utilize primitive pairs within collections. At present, there is no means to store numerous pairs that are internally represented as the Long type (IntIntPair, FloatFloatPair) within a MutableLongMap. Therefore, in instances where we require storing multiple pairs, an ArrayList or a MutableObjectList is currently utilized, which leads to unnecessary boxing/unboxing operations.
It would be beneficial to provide public access to the internal pair's Long value or to generate an IntIntPairList and FloatFloatPairList classes within the library.