Fixed
Status Update
Comments
ap...@google.com <ap...@google.com> #2
Project: platform/frameworks/support
Branch: androidx-main
commit 0c3513cf9260158fc725aff0523a97274440a72c
Author: elifbilgin <elifbilgin@google.com>
Date: Mon Apr 15 22:28:29 2024
Adding access to the content array in list collections.
Bug: 333903173
Test: ./gradlew collection:collection:test
Relnote: Adding access to the content array in list collections.
Change-Id: I899d56ce4bc69e1a0be296995627ff9a8f3204cb
M collection/collection/api/current.txt
M collection/collection/api/restricted_current.txt
M collection/collection/src/commonMain/kotlin/androidx/collection/DoubleList.kt
M collection/collection/src/commonMain/kotlin/androidx/collection/FloatList.kt
M collection/collection/src/commonMain/kotlin/androidx/collection/IntList.kt
M collection/collection/src/commonMain/kotlin/androidx/collection/LongList.kt
M collection/collection/template/PKeyList.kt.template
https://android-review.googlesource.com/3042177
Branch: androidx-main
commit 0c3513cf9260158fc725aff0523a97274440a72c
Author: elifbilgin <elifbilgin@google.com>
Date: Mon Apr 15 22:28:29 2024
Adding access to the content array in list collections.
Bug: 333903173
Test: ./gradlew collection:collection:test
Relnote: Adding access to the content array in list collections.
Change-Id: I899d56ce4bc69e1a0be296995627ff9a8f3204cb
M collection/collection/api/current.txt
M collection/collection/api/restricted_current.txt
M collection/collection/src/commonMain/kotlin/androidx/collection/DoubleList.kt
M collection/collection/src/commonMain/kotlin/androidx/collection/FloatList.kt
M collection/collection/src/commonMain/kotlin/androidx/collection/IntList.kt
M collection/collection/src/commonMain/kotlin/androidx/collection/LongList.kt
M collection/collection/template/PKeyList.kt.template
ap...@google.com <ap...@google.com> #3
Project: platform/frameworks/support
Branch: androidx-main
commit 97574c45af87fe40f28eeff44a4b3e4e6b0837aa
Author: elifbilgin <elifbilgin@google.com>
Date: Tue Mar 19 19:04:27 2024
Migrating ArrayQueryResultAdapter to use driver APIs.
This CL refactors the ArrayQueryResultAdapter to delegate
to the ListQueryResultAdapter, since SQLStatement API's
do not allow access to the row count as Android's Cursor
did. This workaround is also beneficial in reducing
boilerplate code as well as removing the special handling
of the nullable array types, since the List adapter can
handle this scenario.
The only downside is the conversion from list to an array
is not ideal, but we can circle back to it if we have a
better solution in the future.
Bug: 299168035
Bug: 333903173
Test: DaoKotlinCodeGenTest & BaseSimpleQueryTest
Change-Id: I4fe55163496005ed33de32b61e7c4d39c7a647df
M room/integration-tests/multiplatformtestapp/src/commonTest/kotlin/androidx/room/integration/multiplatformtestapp/test/BaseQueryTest.kt
M room/integration-tests/multiplatformtestapp/src/commonTest/kotlin/androidx/room/integration/multiplatformtestapp/test/SampleDatabase.kt
M room/room-compiler/src/main/kotlin/androidx/room/processor/ProcessorErrors.kt
M room/room-compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/room-compiler/src/main/kotlin/androidx/room/solver/query/result/ArrayQueryResultAdapter.kt
M room/room-compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
M room/room-compiler/src/test/kotlin/androidx/room/writer/DaoKotlinCodeGenTest.kt
M room/room-compiler/src/test/test-data/daoWriter/output/javac/ComplexDao.java
M room/room-compiler/src/test/test-data/daoWriter/output/ksp/ComplexDao.java
M room/room-compiler/src/test/test-data/kotlinCodeGen/queryResultAdapter_array.kt
https://android-review.googlesource.com/3008655
Branch: androidx-main
commit 97574c45af87fe40f28eeff44a4b3e4e6b0837aa
Author: elifbilgin <elifbilgin@google.com>
Date: Tue Mar 19 19:04:27 2024
Migrating ArrayQueryResultAdapter to use driver APIs.
This CL refactors the ArrayQueryResultAdapter to delegate
to the ListQueryResultAdapter, since SQLStatement API's
do not allow access to the row count as Android's Cursor
did. This workaround is also beneficial in reducing
boilerplate code as well as removing the special handling
of the nullable array types, since the List adapter can
handle this scenario.
The only downside is the conversion from list to an array
is not ideal, but we can circle back to it if we have a
better solution in the future.
Bug: 299168035
Bug: 333903173
Test: DaoKotlinCodeGenTest & BaseSimpleQueryTest
Change-Id: I4fe55163496005ed33de32b61e7c4d39c7a647df
M room/integration-tests/multiplatformtestapp/src/commonTest/kotlin/androidx/room/integration/multiplatformtestapp/test/BaseQueryTest.kt
M room/integration-tests/multiplatformtestapp/src/commonTest/kotlin/androidx/room/integration/multiplatformtestapp/test/SampleDatabase.kt
M room/room-compiler/src/main/kotlin/androidx/room/processor/ProcessorErrors.kt
M room/room-compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/room-compiler/src/main/kotlin/androidx/room/solver/query/result/ArrayQueryResultAdapter.kt
M room/room-compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
M room/room-compiler/src/test/kotlin/androidx/room/writer/DaoKotlinCodeGenTest.kt
M room/room-compiler/src/test/test-data/daoWriter/output/javac/ComplexDao.java
M room/room-compiler/src/test/test-data/daoWriter/output/ksp/ComplexDao.java
M room/room-compiler/src/test/test-data/kotlinCodeGen/queryResultAdapter_array.kt
el...@google.com <el...@google.com>
pr...@google.com <pr...@google.com> #4
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.collection:collection:1.5.0-alpha01
androidx.collection:collection-iosarm64:1.5.0-alpha01
androidx.collection:collection-iossimulatorarm64:1.5.0-alpha01
androidx.collection:collection-iosx64:1.5.0-alpha01
androidx.collection:collection-jvm:1.5.0-alpha01
androidx.collection:collection-linuxarm64:1.5.0-alpha01
androidx.collection:collection-linuxx64:1.5.0-alpha01
androidx.collection:collection-macosarm64:1.5.0-alpha01
androidx.collection:collection-macosx64:1.5.0-alpha01
androidx.collection:collection-tvosarm64:1.5.0-alpha01
androidx.collection:collection-tvossimulatorarm64:1.5.0-alpha01
androidx.collection:collection-tvosx64:1.5.0-alpha01
androidx.collection:collection-watchosarm32:1.5.0-alpha01
androidx.collection:collection-watchosarm64:1.5.0-alpha01
androidx.collection:collection-watchossimulatorarm64:1.5.0-alpha01
androidx.collection:collection-watchosx64:1.5.0-alpha01
Description