Refactor llvm_local_bisection for new LLVM_NEXT_HASH location [334943107]

Assigned

Feature Request

Status Update

No update yet.

Description

gb...@google.com

created issue #1

Apr 15, 2024 06:36PM

https://chromium-review.googlesource.com/c/chromiumos/overlays/chromiumos-overlay/+/5454530 removes the LLVM_NEXT_HASH variable from our ebuilds. The llvm_local_bisection.sh script should be updated to instead use update_chromeos_llvm_hash.py and the new force-stabilization script.

Jordan volunteered to do this, so cutting a bug that Bugjuggler can assign to them once all of the above is landed.

Comments

gb...@google.com <gb...@google.com> #2Apr 15, 2024 06:36PM

Assigned to bu...@google.com.

CCing +tomhughes and +inglorion, as requested by Bob

bu...@google.com <bu...@google.com> #3Apr 15, 2024 06:36PM

Accepted by bu...@google.com.

Updated title to reflect that it's not just bloonchipper, but all fpmcu-unittests packages.

bu...@google.com <bu...@google.com> Apr 19, 2024 04:52AM

Assigned to aj...@google.com.

bl...@google.com <bl...@google.com> #4Jul 12, 2024 05:03AM

The title says fails to build because std::auto_ptr was removed, but I don't think we're using std::auto_ptr anywhere (at least not intentionally), and I don't see it mentioned in the error message.

For this error,

/usr/bin/../include/c++/v1/__config:821:8: error: "No thread API"
  821 | #      error "No thread API"
      |        ^

We do build libc++ with thread support disabled, since the EC OS does not support threads.

bl...@google.com <bl...@google.com> #5Oct 4, 2024 05:32AM

Ah, yes, sorry. Title was from the other bugs that took this same format (there's a lot of them!). Updated.

This is roughly the line in the current llvm

And at the LLVM Next. It doesn't look like much has changed in the config itself, but something could have changed in the libcxx CMake.

So I'm guessing for whatever reason, _LIBCPP_HAS_NO_THREADS is 0 for the ECs.

bl...@google.com <bl...@google.com> #6Dec 27, 2024 07:02AM

Setting V=1, I believe I have the commandline invocation that causes this:

make[1]: Entering directory '/build/amd64-generic/tmp/portage/chromeos-base/chromeos-fpmcu-bloonchipper-unittests-0.0.1-r893/work/chromeos-fpmcu-bloonchipper-unittests-0.0.1/platform/ec'
/usr/bin/ccache armv7m-cros-eabi-clang -E -P -DSECTION_IS_RO= -Itest -DTEST_BUILD= -imacros abort.tasklist -Iboard/bloonchipper -DBOARD_BLOONCHIPPER= -Ibaseboard/bloonchipper -DBASEBOARD_BLOONCHIPPER= -D_MAKEFILE= -imacros ec.tasklist include/task_filter.h
/usr/bin/ccache armv7m-cros-eabi-clang -E -P -DSECTION_IS_RW= -Itest -DTEST_BUILD= -imacros abort.tasklist -Iboard/bloonchipper -DBOARD_BLOONCHIPPER= -Ibaseboard/bloonchipper -DBASEBOARD_BLOONCHIPPER= -D_MAKEFILE= -imacros ec.tasklist include/task_filter.h
/usr/bin/ccache armv7m-cros-eabi-clang -E -DOUTDIR=build/bloonchipper/abort/RO -DCHIP=stm32 -DBOARD_TASKFILE=ec.tasklist -DBOARD=bloonchipper -DCORE=cortex-m -DPROJECT=abort -DCHIP_VARIANT=stm32f412 -DCHIP_FAMILY=STM32F4 -DBOARD_BLOONCHIPPER= -DCHIP_STM32= -DCORE_CORTEX_M= -DCHIP_VARIANT_STM32F412= -DCHIP_FAMILY_STM32F4= -DFINAL_OUTDIR=build/bloonchipper/abort -DPROTOBUF_MIN_PROTOC_VERSION=0 -DHAS_BASEBOARD= -DBASEBOARD_BLOONCHIPPER= -Iinclude  -Icore/cortex-m/include  -Iinclude/driver  -Ibuild/bloonchipper/abort  -Ifuzz  -Itest  -Ithird_party  -I. -DTEST_BUILD= -DTEST_LEGACY_BUILD= -DTEST_TASKFILE=abort.tasklist   -DTEST_abort= -DTEST_ABORT=        -Iinclude/driver  -DSECTION_IS_RO= -DSECTION=RO -DHAS_TASK_RWSIG= -DHAS_TASK_FPSENSOR_RW= -fno-PIC -DCHROMIUM_EC= -DHAS_TASK_HOOKS= -DHAS_TASK_HOSTCMD= -DHAS_TASK_CONSOLE= -DHAS_TASK_TEST= -P -dM -Ichip/stm32 -Ibaseboard/bloonchipper -Iboard/bloonchipper  include/config.h | grep -o "#define \(CONFIG\|VARIANT\)_[A-Z0-9_]*" | cut -c9- | sort
/usr/bin/ccache armv7m-cros-eabi-clang -E -DOUTDIR=build/bloonchipper/abort/RW -DCHIP=stm32 -DBOARD_TASKFILE=ec.tasklist -DBOARD=bloonchipper -DCORE=cortex-m -DPROJECT=abort -DCHIP_VARIANT=stm32f412 -DCHIP_FAMILY=STM32F4 -DBOARD_BLOONCHIPPER= -DCHIP_STM32= -DCORE_CORTEX_M= -DCHIP_VARIANT_STM32F412= -DCHIP_FAMILY_STM32F4= -DFINAL_OUTDIR=build/bloonchipper/abort -DPROTOBUF_MIN_PROTOC_VERSION=0 -DHAS_BASEBOARD= -DBASEBOARD_BLOONCHIPPER= -Iinclude  -Icore/cortex-m/include  -Iinclude/driver  -Ibuild/bloonchipper/abort  -Ifuzz  -Itest  -Ithird_party  -I. -DTEST_BUILD= -DTEST_LEGACY_BUILD= -DTEST_TASKFILE=abort.tasklist   -DTEST_abort= -DTEST_ABORT=        -Iinclude/driver  -DSECTION_IS_RW= -DSECTION=RW -DHAS_TASK_FPSENSOR= -DHAS_TASK_RWSIG_RO= -fno-PIC -DCHROMIUM_EC= -DHAS_TASK_HOOKS= -DHAS_TASK_HOSTCMD= -DHAS_TASK_CONSOLE= -DHAS_TASK_TEST= -P -dM -Ichip/stm32 -Ibaseboard/bloonchipper -Iboard/bloonchipper  include/config.h | grep -o "#define \(CONFIG\|VARIANT\)_[A-Z0-9_]*" | cut -c9- | sort
echo "CONFIG_RW_MEM_OFF" | /usr/bin/ccache armv7m-cros-eabi-clang -E -DOUTDIR=build/bloonchipper/abort/ -DCHIP=stm32 -DBOARD_TASKFILE=ec.tasklist -DBOARD=bloonchipper -DCORE=cortex-m -DPROJECT=abort -DCHIP_VARIANT=stm32f412 -DCHIP_FAMILY=STM32F4 -DBOARD_BLOONCHIPPER= -DCHIP_STM32= -DCORE_CORTEX_M= -DCHIP_VARIANT_STM32F412= -DCHIP_FAMILY_STM32F4= -DFINAL_OUTDIR=build/bloonchipper/abort -DPROTOBUF_MIN_PROTOC_VERSION=0 -DHAS_BASEBOARD= -DBASEBOARD_BLOONCHIPPER= -Iinclude  -Icore/cortex-m/include  -Iinclude/driver  -Ibuild/bloonchipper/abort  -Ifuzz  -Itest  -Ithird_party  -I. -DTEST_BUILD= -DTEST_LEGACY_BUILD= -DTEST_TASKFILE=abort.tasklist   -DTEST_abort= -DTEST_ABORT=        -Iinclude/driver  -DSECTION_IS_= -DSECTION=  -fno-PIC -DCHROMIUM_EC= -DHAS_TASK_HOOKS= -DHAS_TASK_HOSTCMD= -DHAS_TASK_CONSOLE= -DHAS_TASK_TEST=  -P -Ichip/stm32 -Ibaseboard/bloonchipper -Iboard/bloonchipper  -imacros include/config.h -
echo "CONFIG_RW_SIZE" | /usr/bin/ccache armv7m-cros-eabi-clang -E -DOUTDIR=build/bloonchipper/abort/ -DCHIP=stm32 -DBOARD_TASKFILE=ec.tasklist -DBOARD=bloonchipper -DCORE=cortex-m -DPROJECT=abort -DCHIP_VARIANT=stm32f412 -DCHIP_FAMILY=STM32F4 -DBOARD_BLOONCHIPPER= -DCHIP_STM32= -DCORE_CORTEX_M= -DCHIP_VARIANT_STM32F412= -DCHIP_FAMILY_STM32F4= -DFINAL_OUTDIR=build/bloonchipper/abort -DPROTOBUF_MIN_PROTOC_VERSION=0 -DHAS_BASEBOARD= -DBASEBOARD_BLOONCHIPPER= -Iinclude  -Icore/cortex-m/include  -Iinclude/driver  -Ibuild/bloonchipper/abort  -Ifuzz  -Itest  -Ithird_party  -I. -DTEST_BUILD= -DTEST_LEGACY_BUILD= -DTEST_TASKFILE=abort.tasklist   -DTEST_abort= -DTEST_ABORT=        -Iinclude/driver  -DSECTION_IS_= -DSECTION=  -fno-PIC -DCHROMIUM_EC= -DHAS_TASK_HOOKS= -DHAS_TASK_HOSTCMD= -DHAS_TASK_CONSOLE= -DHAS_TASK_TEST=  -P -Ichip/stm32 -Ibaseboard/bloonchipper -Iboard/bloonchipper  -imacros include/config.h -
echo "CONFIG_PROGRAM_MEMORY_BASE" | /usr/bin/ccache armv7m-cros-eabi-clang -E -DOUTDIR=build/bloonchipper/abort/ -DCHIP=stm32 -DBOARD_TASKFILE=ec.tasklist -DBOARD=bloonchipper -DCORE=cortex-m -DPROJECT=abort -DCHIP_VARIANT=stm32f412 -DCHIP_FAMILY=STM32F4 -DBOARD_BLOONCHIPPER= -DCHIP_STM32= -DCORE_CORTEX_M= -DCHIP_VARIANT_STM32F412= -DCHIP_FAMILY_STM32F4= -DFINAL_OUTDIR=build/bloonchipper/abort -DPROTOBUF_MIN_PROTOC_VERSION=0 -DHAS_BASEBOARD= -DBASEBOARD_BLOONCHIPPER= -Iinclude  -Icore/cortex-m/include  -Iinclude/driver  -Ibuild/bloonchipper/abort  -Ifuzz  -Itest  -Ithird_party  -I. -DTEST_BUILD= -DTEST_LEGACY_BUILD= -DTEST_TASKFILE=abort.tasklist   -DTEST_abort= -DTEST_ABORT=        -Iinclude/driver  -DSECTION_IS_= -DSECTION=  -fno-PIC -DCHROMIUM_EC= -DHAS_TASK_HOOKS= -DHAS_TASK_HOSTCMD= -DHAS_TASK_CONSOLE= -DHAS_TASK_TEST=  -P -Ichip/stm32 -Ibaseboard/bloonchipper -Iboard/bloonchipper  -imacros include/config.h -
armv7m-cros-eabi-clang++ -std=gnu++2a -DOUTDIR=build/bloonchipper/abort/RW -DCHIP=stm32 -DBOARD_TASKFILE=ec.tasklist -DBOARD=bloonchipper -DCORE=cortex-m -DPROJECT=abort -DCHIP_VARIANT=stm32f412 -DCHIP_FAMILY=STM32F4 -DBOARD_BLOONCHIPPER= -DCHIP_STM32= -DCORE_CORTEX_M= -DCHIP_VARIANT_STM32F412= -DCHIP_FAMILY_STM32F4= -DFINAL_OUTDIR=build/bloonchipper/abort -DPROTOBUF_MIN_PROTOC_VERSION=0 -DHAS_BASEBOARD= -DBASEBOARD_BLOONCHIPPER= -Iinclude  -Icore/cortex-m/include  -Iinclude/driver  -Icore/cortex-m  -Ichip/stm32  -Ibaseboard/bloonchipper  -Iboard/bloonchipper  -Icommon  -Ifuzz  -Ipower  -Itest  -Icts/common  -Icts/  -Ibuild/bloonchipper/abort/gen  -I../ec-private  -Icommon  -Icommon/fpsensor  -Icommon/mock  -Icommon/spi  -Icommon/spi/flash_reg  -Icommon/spi/flash_reg/private  -Icommon/spi/flash_reg/public  -Icommon/spi/flash_reg/src  -Icommon/usbc  -Icommon/vboot  -Idriver  -Idriver/battery  -Idriver/bc12  -Idriver/cec  -Idriver/charger  -Idriver/fingerprint  -Idriver/fingerprint/egis  -Idriver/fingerprint/egis/platform  -Idriver/fingerprint/egis/platform/inc  -Idriver/fingerprint/egis/platform/src  -Idriver/fingerprint/elan  -Idriver/fingerprint/fpc  -Idriver/fingerprint/fpc/bep  -Idriver/fingerprint/fpc/libfp  -Idriver/ioexpander  -Idriver/led  -Idriver/nfc  -Idriver/ppc  -Idriver/retimer  -Idriver/sha256  -Idriver/tcpm  -Idriver/temp_sensor  -Idriver/usb_mux  -Idriver/wpc  -Ilibc  -Ithird_party/boringssl/common  -Icrypto  -Ibuild/bloonchipper/abort  -Ifuzz  -Itest  -Ithird_party  -Ispi/flash_regpublic  -I. -DTEST_BUILD= -DTEST_LEGACY_BUILD= -DTEST_TASKFILE=abort.tasklist   -DTEST_abort= -DTEST_ABORT=        -Iinclude/driver  -DSECTION_IS_RW= -DSECTION=RW -DHAS_TASK_FPSENSOR= -DHAS_TASK_RWSIG_RO= -fno-PIC -DCHROMIUM_EC= -DHAS_TASK_HOOKS= -DHAS_TASK_HOSTCMD= -DHAS_TASK_CONSOLE= -DHAS_TASK_TEST=  -I../../third_party/boringssl -I../../third_party/boringssl/include -I/build/amd64-generic/tmp/portage/chromeos-base/chromeos-fpmcu-bloonchipper-unittests-0.0.1-r893/work/chromeos-fpmcu-bloonchipper-unittests-0.0.1/platform/ec/third_party/boringssl/include -DCROS_EC -mcpu=cortex-m4 -mcpu=cortex-m4 -mthumb -Oz             -Wl,-mllvm -Wl,-inline-threshold=-10 -mno-unaligned-access -mfloat-abi=hard -flto -g  -Wall -Wundef -Wno-trigraphs -Wno-format-security -Wno-address-of-packed-member -fno-common -fno-strict-aliasing -fno-strict-overflow -Wimplicit-fallthrough -fno-exceptions -fno-unwind-tables -fno-asynchronous-unwind-tables -Werror -ftrapv -Werror=uninitialized -Wno-unused-function  -ffunction-sections -fno-delete-null-pointer-checks -fno-PIC -Wvla -Wall -Wundef -Wno-trigraphs -Wno-format-security -Wno-address-of-packed-member -fno-common -fno-strict-aliasing -fno-strict-overflow -Wimplicit-fallthrough -fno-exceptions -fno-unwind-tables -fno-asynchronous-unwind-tables -Werror -ftrapv -Werror=uninitialized -Wno-unused-function -DPROTOBUF_INLINE_NOT_IN_HEADERS=0 -MMD -MP -MF build/bloonchipper/abort/RW/common/fpsensor/fpsensor.o.d -c common/fpsensor/fpsensor.cc -MT build/bloonchipper/abort/RW/common/fpsensor/fpsensor.o -o build/bloonchipper/abort/RW/common/fpsensor/fpsensor.o
In file included from common/fpsensor/fpsensor.cc:7:
In file included from core/cortex-m/atomic.h:12:
In file included from include/common.h:11:
In file included from include/compile_time_macros.h:12:
In file included from /usr/bin/../include/c++/v1/type_traits:420:
/usr/bin/../include/c++/v1/__config:821:8: error: "No thread API"
  821 | #      error "No thread API"
      |        ^

Issue 334943107