Status Update
Comments
gb...@google.com <gb...@google.com> #2
Much like
Bugjuggler:
ap...@google.com <ap...@google.com> #3
ap...@google.com <ap...@google.com> #4
Project: chromiumos/overlays/chromiumos-overlay
Branch: main
Author: George Burgess IV <
Link:
rust-bootstrap: land 1.84.1
Expand for full commit details
rust-bootstrap: land 1.84.1
Starting on b/393504523 led to rust_uprev.py uploading the 1.84.1 src
tarball. Might as well have the SDK builder generate artifacts for this
before we need them.
BUG=b:398823143
TEST=sudo emerge rust-bootstrap:1.84.1
Change-Id: I5e42be00977dc147175ff7b478fad09b3da2b898
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/overlays/chromiumos-overlay/+/6299951
Reviewed-by: Bob Haarman <inglorion@chromium.org>
Commit-Queue: George Burgess <gbiv@chromium.org>
Tested-by: George Burgess <gbiv@chromium.org>
Files:
- M
dev-lang/rust-bootstrap/Manifest
- A
dev-lang/rust-bootstrap/rust-bootstrap-1.84.1.ebuild
Hash: 8f7f449916a64f5c296b57c174d18bf5a5aae074
Date: Mon Feb 24 11:14:06 2025
ap...@google.com <ap...@google.com> #5
Project: chromiumos/overlays/chromiumos-overlay
Branch: firmware-android-15949.B
Author: George Burgess IV <
Link:
rust-bootstrap: land 1.84.1 Android Bringup: See
Expand for full commit details
rust-bootstrap: land 1.84.1
Android Bringup: See http://go/android-fw-sync
Starting on b/393504523 led to rust_uprev.py uploading the 1.84.1 src
tarball. Might as well have the SDK builder generate artifacts for this
before we need them.
BUG=b:398823143
TEST=sudo emerge rust-bootstrap:1.84.1
(cherry picked from commit 8f7f449916a64f5c296b57c174d18bf5a5aae074)
Change-Id: I5e42be00977dc147175ff7b478fad09b3da2b898
Original-Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/overlays/chromiumos-overlay/+/6299951
Original-Reviewed-by: Bob Haarman <inglorion@chromium.org>
Original-Commit-Queue: George Burgess <gbiv@chromium.org>
Original-Tested-by: George Burgess <gbiv@chromium.org>
GitOrigin-RevId: 8f7f449916a64f5c296b57c174d18bf5a5aae074
Cr-Build-Id: 8721817788610407729
Cr-Build-Url: https://cr-buildbucket.appspot.com/build/8721817788610407729
Copybot-Job-Name: android-main-chromiumos-overlay-copybot-downstream
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/overlays/chromiumos-overlay/+/6307951
Commit-Queue: ChromeOS Prod (Robot) <chromeos-ci-prod@chromeos-bot.iam.gserviceaccount.com>
Bot-Commit: ChromeOS Prod (Robot) <chromeos-ci-prod@chromeos-bot.iam.gserviceaccount.com>
Tested-by: ChromeOS Prod (Robot) <chromeos-ci-prod@chromeos-bot.iam.gserviceaccount.com>
Files:
- M
dev-lang/rust-bootstrap/Manifest
- A
dev-lang/rust-bootstrap/rust-bootstrap-1.84.1.ebuild
Hash: a88800da9da8ebef7ea5d0e2ee415482cdc4b02a
Date: Mon Feb 24 11:14:06 2025
ap...@google.com <ap...@google.com> #6
Project: chromiumos/overlays/chromiumos-overlay
Branch: firmware-android-15949.B
Author: George Burgess IV <
Link:
dev-go: add RDEPEND to DEPEND in perfetto-protos Android Bringup: See
Expand for full commit details
dev-go: add RDEPEND to DEPEND in perfetto-protos
Android Bringup: See http://go/android-fw-sync
Bazel builders are angry that perfetto-protos can't find protobuf files
in the new Go version. Adding this to DEPEND makes them less angry.
BUG=b:339458385
TEST=CQ
(cherry picked from commit a8d86a705188830b08c186bb55cb1dd9c0f4045c)
Change-Id: I014962b606700a71064fd1bba94f182fde57dade
Original-Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/overlays/chromiumos-overlay/+/6282227
Original-Reviewed-by: Raul Rangel <rrangel@chromium.org>
Original-Commit-Queue: George Burgess <gbiv@chromium.org>
Original-Tested-by: George Burgess <gbiv@chromium.org>
GitOrigin-RevId: a8d86a705188830b08c186bb55cb1dd9c0f4045c
Cr-Build-Id: 8722361371463434193
Cr-Build-Url: https://cr-buildbucket.appspot.com/build/8722361371463434193
Copybot-Job-Name: android-main-chromiumos-overlay-copybot-downstream
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/overlays/chromiumos-overlay/+/6290421
Commit-Queue: ChromeOS Prod (Robot) <chromeos-ci-prod@chromeos-bot.iam.gserviceaccount.com>
Tested-by: ChromeOS Prod (Robot) <chromeos-ci-prod@chromeos-bot.iam.gserviceaccount.com>
Bot-Commit: ChromeOS Prod (Robot) <chromeos-ci-prod@chromeos-bot.iam.gserviceaccount.com>
Files:
- M
dev-go/perfetto-protos/perfetto-protos-9999.ebuild
Hash: c09ce85e17301ba508a02678f227436373687ecc
Date: Wed Feb 19 09:35:10 2025
ap...@google.com <ap...@google.com> #7
Project: chromiumos/overlays/chromiumos-overlay
Branch: main
Author: George Burgess IV <
Link:
perfetto: manually uprev
Expand for full commit details
perfetto: manually uprev
The uprev process for this last succeeded on the 6th:
https://screenshot.googleplex.com/8idoeb6XQmpkfvo
This rolls a DEPEND fix into perfetto-protos to unblock the Go upgrade
(crrev.com/c/6282227) and nop uprevs the perfetto ebuild to be
consistent with what pupr does.
BUG=b:339458385
TEST=CQ
Change-Id: I439ff5ed4eebfbf0fc6119bf51cb1e3f1d016b04
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/overlays/chromiumos-overlay/+/6288578
Reviewed-by: Raul Rangel <rrangel@chromium.org>
Tested-by: George Burgess <gbiv@chromium.org>
Commit-Queue: George Burgess <gbiv@chromium.org>
Files:
- M
chromeos-base/perfetto/perfetto-48.1-r60.ebuild
- M
dev-go/perfetto-protos/perfetto-protos-48.1-r60.ebuild
Hash: 14149958b0a89063002f60b81a251a71d243026f
Date: Fri Feb 21 10:31:05 2025
ap...@google.com <ap...@google.com> #8
Project: chromiumos/overlays/chromiumos-overlay
Branch: firmware-android-15949.B
Author: George Burgess IV <
Link:
perfetto: manually uprev Android Bringup: See
Expand for full commit details
perfetto: manually uprev
Android Bringup: See http://go/android-fw-sync
The uprev process for this last succeeded on the 6th:
https://screenshot.googleplex.com/8idoeb6XQmpkfvo
This rolls a DEPEND fix into perfetto-protos to unblock the Go upgrade
(crrev.com/c/6282227) and nop uprevs the perfetto ebuild to be
consistent with what pupr does.
BUG=b:339458385
TEST=CQ
(cherry picked from commit 14149958b0a89063002f60b81a251a71d243026f)
Change-Id: I439ff5ed4eebfbf0fc6119bf51cb1e3f1d016b04
Original-Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/overlays/chromiumos-overlay/+/6288578
Original-Reviewed-by: Raul Rangel <rrangel@chromium.org>
Original-Tested-by: George Burgess <gbiv@chromium.org>
Original-Commit-Queue: George Burgess <gbiv@chromium.org>
GitOrigin-RevId: 14149958b0a89063002f60b81a251a71d243026f
Cr-Build-Id: 8722270772549947217
Cr-Build-Url: https://cr-buildbucket.appspot.com/build/8722270772549947217
Copybot-Job-Name: android-main-chromiumos-overlay-copybot-downstream
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/overlays/chromiumos-overlay/+/6292616
Bot-Commit: ChromeOS Prod (Robot) <chromeos-ci-prod@chromeos-bot.iam.gserviceaccount.com>
Tested-by: ChromeOS Prod (Robot) <chromeos-ci-prod@chromeos-bot.iam.gserviceaccount.com>
Commit-Queue: ChromeOS Prod (Robot) <chromeos-ci-prod@chromeos-bot.iam.gserviceaccount.com>
Files:
- M
chromeos-base/perfetto/perfetto-48.1-r60.ebuild
- M
dev-go/perfetto-protos/perfetto-protos-48.1-r60.ebuild
Hash: 1c4252f5d249ec582defcac914e9db05b46f1dfa
Date: Fri Feb 21 10:31:05 2025
ap...@google.com <ap...@google.com> #9
Project: chromiumos/overlays/chromiumos-overlay
Branch: main
Author: Adrian Ratiu <
Link:
eclass/cros-go: don't die on expected circular deps
Expand for full commit details
eclass/cros-go: don't die on expected circular deps
Some Go packgaes have expected circular dependencies
like like genproto -> gcp-bignum -> genproto.
Newer versions of Go significantly reworked how the
"go list" command verifies transitive dependencies,
in both GOPATH and modules mode, with the result that
if any transitive deps are missing it exists non-zero.
We already know the ebuilds being affected by this, as
they are marked by CROS_GO_SKIP_DEP_CHECK, so don't die
if it is set.
BUG=b:339458385
TEST=Full SDK builds with both Go 1.20 and Go 1.23; CQ.
Change-Id: I59f88243aa4db5bfa511e525e65ad3cbe7ec6645
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/overlays/chromiumos-overlay/+/6169134
Reviewed-by: George Burgess <gbiv@chromium.org>
Tested-by: Adrian Ratiu <adrian.ratiu@collabora.corp-partner.google.com>
Commit-Queue: Adrian Ratiu <adrian.ratiu@collabora.corp-partner.google.com>
Reviewed-by: Mike Frysinger <vapier@chromium.org>
Auto-Submit: Adrian Ratiu <adrian.ratiu@collabora.corp-partner.google.com>
Files:
- M
eclass/cros-go.eclass
Hash: 87d122dbaa8c163ab5b9010c7e14d5a35cfe2fc9
Date: Fri Jan 10 13:16:58 2025
ap...@google.com <ap...@google.com> #10
Project: chromiumos/overlays/chromiumos-overlay
Branch: main
Author: Adrian Ratiu <
Link:
eclass/cros-go: fix wrong GOPATH in cros-go list
Expand for full commit details
eclass/cros-go: fix wrong GOPATH in cros-go list
Prior to 1.23 if a package was not found, the complier
would check the default go path for it. Now it will
check strictly for packages in the GOPATH variable,
so we need to ensure all search paths are added to it.
BUG=b:339458385
TEST=Local builds with go 1.20 and go 1.23; CQ.
Change-Id: Ic39e525bc00bac426d0fd32e6f0c991623b01e57
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/overlays/chromiumos-overlay/+/6169133
Auto-Submit: Adrian Ratiu <adrian.ratiu@collabora.corp-partner.google.com>
Reviewed-by: George Burgess <gbiv@chromium.org>
Commit-Queue: Adrian Ratiu <adrian.ratiu@collabora.corp-partner.google.com>
Tested-by: Adrian Ratiu <adrian.ratiu@collabora.corp-partner.google.com>
Reviewed-by: Bob Haarman <inglorion@chromium.org>
Files:
- M
eclass/cros-go.eclass
Hash: b1c8025c5a5f7ce8c3d77697580fb19c05f288d9
Date: Thu Jan 09 20:58:24 2025
ap...@google.com <ap...@google.com> #11
Project: chromiumos/overlays/chromiumos-overlay
Branch: main
Author: Adrian Ratiu <
Link:
dev-lang/go: bump 1.20.10 -> 1.23.4
Expand for full commit details
dev-lang/go: bump 1.20.10 -> 1.23.4
Newer versions of Go have a rule for determining the
minimum version of the bootstrap compiler [1]:
Go version 1.N will require a Go 1.M compiler, where
M is N-2 rounded down to an even number. Example:
Go 1.24 and 1.25 require Go 1.22.
For our current upgrade, 1.23.4, we bump the bootstrap
compiler to 1.20.6.
The following patches have been dropped because the
issues are fixed in 1.23.4:
fix-cve-2023-39326.patch
fix-cve-2023-45285.patch
fix-cve-2024-24790.patch
BUG=b:339458385
TEST=Full SDK builds, Tast tests build & run, CQ.
[1] Link: https://go.dev/doc/install/source
Cq-Depend: chromium:6169133, chromium:6169134
Change-Id: I39250d48f4e4349a8d95d60135915a5a1478e414
Disallow-Recycled-Builds: test-failures
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/overlays/chromiumos-overlay/+/6169135
Commit-Queue: Adrian Ratiu <adrian.ratiu@collabora.corp-partner.google.com>
Tested-by: Adrian Ratiu <adrian.ratiu@collabora.corp-partner.google.com>
Reviewed-by: Jordan Abrahams-Whitehead <ajordanr@google.com>
Auto-Submit: Adrian Ratiu <adrian.ratiu@collabora.corp-partner.google.com>
Files:
- M
dev-lang/go/Manifest
- D
dev-lang/go/files/fix-cve-2023-39326.patch
- D
dev-lang/go/files/fix-cve-2023-45285.patch
- D
dev-lang/go/files/fix-cve-2024-24790.patch
- D
dev-lang/go/go-1.20.10-r4.ebuild
- A
dev-lang/go/go-1.23.4-r1.ebuild
- M
dev-lang/go/go-1.23.4.ebuild
Hash: 9391fcf15a9beb8774a2aeb9e74807d0c6695976
Date: Wed Jan 08 13:10:24 2025
ap...@google.com <ap...@google.com> #12
Project: chromiumos/overlays/chromiumos-overlay
Branch: firmware-android-15949.B
Author: Adrian Ratiu <
Link:
eclass/cros-go: fix wrong GOPATH in cros-go list Android Bringup: See
Expand for full commit details
eclass/cros-go: fix wrong GOPATH in cros-go list
Android Bringup: See http://go/android-fw-sync
Prior to 1.23 if a package was not found, the complier
would check the default go path for it. Now it will
check strictly for packages in the GOPATH variable,
so we need to ensure all search paths are added to it.
BUG=b:339458385
TEST=Local builds with go 1.20 and go 1.23; CQ.
(cherry picked from commit b1c8025c5a5f7ce8c3d77697580fb19c05f288d9)
Change-Id: Ic39e525bc00bac426d0fd32e6f0c991623b01e57
Original-Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/overlays/chromiumos-overlay/+/6169133
Original-Auto-Submit: Adrian Ratiu <adrian.ratiu@collabora.corp-partner.google.com>
Original-Reviewed-by: George Burgess <gbiv@chromium.org>
Original-Commit-Queue: Adrian Ratiu <adrian.ratiu@collabora.corp-partner.google.com>
Original-Tested-by: Adrian Ratiu <adrian.ratiu@collabora.corp-partner.google.com>
Original-Reviewed-by: Bob Haarman <inglorion@chromium.org>
GitOrigin-RevId: b1c8025c5a5f7ce8c3d77697580fb19c05f288d9
Cr-Build-Id: 8721206256222107313
Cr-Build-Url: https://cr-buildbucket.appspot.com/build/8721206256222107313
Copybot-Job-Name: android-main-chromiumos-overlay-copybot-downstream
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/overlays/chromiumos-overlay/+/6331326
Tested-by: ChromeOS Prod (Robot) <chromeos-ci-prod@chromeos-bot.iam.gserviceaccount.com>
Bot-Commit: ChromeOS Prod (Robot) <chromeos-ci-prod@chromeos-bot.iam.gserviceaccount.com>
Commit-Queue: ChromeOS Prod (Robot) <chromeos-ci-prod@chromeos-bot.iam.gserviceaccount.com>
Files:
- M
eclass/cros-go.eclass
Hash: 6689722e5c9130ff5eca5268fd89c53de451f8f2
Date: Thu Jan 09 20:58:24 2025
ap...@google.com <ap...@google.com> #13
Project: chromiumos/overlays/chromiumos-overlay
Branch: firmware-android-15949.B
Author: Adrian Ratiu <
Link:
eclass/cros-go: don't die on expected circular deps Android Bringup: See
Expand for full commit details
eclass/cros-go: don't die on expected circular deps
Android Bringup: See http://go/android-fw-sync
Some Go packgaes have expected circular dependencies
like like genproto -> gcp-bignum -> genproto.
Newer versions of Go significantly reworked how the
"go list" command verifies transitive dependencies,
in both GOPATH and modules mode, with the result that
if any transitive deps are missing it exists non-zero.
We already know the ebuilds being affected by this, as
they are marked by CROS_GO_SKIP_DEP_CHECK, so don't die
if it is set.
BUG=b:339458385
TEST=Full SDK builds with both Go 1.20 and Go 1.23; CQ.
(cherry picked from commit 87d122dbaa8c163ab5b9010c7e14d5a35cfe2fc9)
Change-Id: I59f88243aa4db5bfa511e525e65ad3cbe7ec6645
Original-Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/overlays/chromiumos-overlay/+/6169134
Original-Reviewed-by: George Burgess <gbiv@chromium.org>
Original-Tested-by: Adrian Ratiu <adrian.ratiu@collabora.corp-partner.google.com>
Original-Commit-Queue: Adrian Ratiu <adrian.ratiu@collabora.corp-partner.google.com>
Original-Reviewed-by: Mike Frysinger <vapier@chromium.org>
Original-Auto-Submit: Adrian Ratiu <adrian.ratiu@collabora.corp-partner.google.com>
GitOrigin-RevId: 87d122dbaa8c163ab5b9010c7e14d5a35cfe2fc9
Cr-Build-Id: 8721206256222107313
Cr-Build-Url: https://cr-buildbucket.appspot.com/build/8721206256222107313
Copybot-Job-Name: android-main-chromiumos-overlay-copybot-downstream
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/overlays/chromiumos-overlay/+/6331327
Commit-Queue: ChromeOS Prod (Robot) <chromeos-ci-prod@chromeos-bot.iam.gserviceaccount.com>
Tested-by: ChromeOS Prod (Robot) <chromeos-ci-prod@chromeos-bot.iam.gserviceaccount.com>
Bot-Commit: ChromeOS Prod (Robot) <chromeos-ci-prod@chromeos-bot.iam.gserviceaccount.com>
Files:
- M
eclass/cros-go.eclass
Hash: 120190fcb818a7cbf9b186f882f25b10de8703f3
Date: Fri Jan 10 13:16:58 2025
ap...@google.com <ap...@google.com> #14
Project: chromiumos/overlays/chromiumos-overlay
Branch: firmware-android-15949.B
Author: Adrian Ratiu <
Link:
dev-lang/go: bump 1.20.10 -> 1.23.4 Android Bringup: See
Expand for full commit details
dev-lang/go: bump 1.20.10 -> 1.23.4
Android Bringup: See http://go/android-fw-sync
Newer versions of Go have a rule for determining the
minimum version of the bootstrap compiler [1]:
Go version 1.N will require a Go 1.M compiler, where
M is N-2 rounded down to an even number. Example:
Go 1.24 and 1.25 require Go 1.22.
For our current upgrade, 1.23.4, we bump the bootstrap
compiler to 1.20.6.
The following patches have been dropped because the
issues are fixed in 1.23.4:
fix-cve-2023-39326.patch
fix-cve-2023-45285.patch
fix-cve-2024-24790.patch
BUG=b:339458385
TEST=Full SDK builds, Tast tests build & run, CQ.
[1] Link: https://go.dev/doc/install/source
(cherry picked from commit 9391fcf15a9beb8774a2aeb9e74807d0c6695976)
Cq-Depend: chromium:6169133, chromium:6169134
Change-Id: I39250d48f4e4349a8d95d60135915a5a1478e414
Original-Disallow-Recycled-Builds: test-failures
Original-Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/overlays/chromiumos-overlay/+/6169135
Original-Commit-Queue: Adrian Ratiu <adrian.ratiu@collabora.corp-partner.google.com>
Original-Tested-by: Adrian Ratiu <adrian.ratiu@collabora.corp-partner.google.com>
Original-Reviewed-by: Jordan Abrahams-Whitehead <ajordanr@google.com>
Original-Auto-Submit: Adrian Ratiu <adrian.ratiu@collabora.corp-partner.google.com>
GitOrigin-RevId: 9391fcf15a9beb8774a2aeb9e74807d0c6695976
Cr-Build-Id: 8721206256222107313
Cr-Build-Url: https://cr-buildbucket.appspot.com/build/8721206256222107313
Copybot-Job-Name: android-main-chromiumos-overlay-copybot-downstream
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/overlays/chromiumos-overlay/+/6331328
Commit-Queue: ChromeOS Prod (Robot) <chromeos-ci-prod@chromeos-bot.iam.gserviceaccount.com>
Bot-Commit: ChromeOS Prod (Robot) <chromeos-ci-prod@chromeos-bot.iam.gserviceaccount.com>
Tested-by: ChromeOS Prod (Robot) <chromeos-ci-prod@chromeos-bot.iam.gserviceaccount.com>
Files:
- M
dev-lang/go/Manifest
- D
dev-lang/go/files/fix-cve-2023-39326.patch
- D
dev-lang/go/files/fix-cve-2023-45285.patch
- D
dev-lang/go/files/fix-cve-2024-24790.patch
- D
dev-lang/go/go-1.20.10-r4.ebuild
- A
dev-lang/go/go-1.23.4-r1.ebuild
- M
dev-lang/go/go-1.23.4.ebuild
Hash: 0eeb567cad1f3aef0c6a91d6a725193ee762a631
Date: Wed Jan 08 13:10:24 2025
ad...@collabora.corp-partner.google.com <ad...@collabora.corp-partner.google.com> #15
I think we can c lose this because we landed Go 1.23 a few days ago.
(I do not have permission to close myself).
Description
Once the modules migration concludes we should look at upgrading Golang inside the chroot to an upto date version.