Status Update
Comments
bl...@google.com <bl...@google.com> #2
Much like
Bugjuggler:
c-...@google.com <c-...@google.com>
aj...@google.com <aj...@google.com> #3
ja...@google.com <ja...@google.com> #4
Project: chromiumos/overlays/chromiumos-overlay
Branch: main
Author: George Burgess IV <
Link:
rust-bootstrap: land 1.84.1
Expand for full commit details
rust-bootstrap: land 1.84.1
Starting on b/393504523 led to rust_uprev.py uploading the 1.84.1 src
tarball. Might as well have the SDK builder generate artifacts for this
before we need them.
BUG=b:398823143
TEST=sudo emerge rust-bootstrap:1.84.1
Change-Id: I5e42be00977dc147175ff7b478fad09b3da2b898
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/overlays/chromiumos-overlay/+/6299951
Reviewed-by: Bob Haarman <inglorion@chromium.org>
Commit-Queue: George Burgess <gbiv@chromium.org>
Tested-by: George Burgess <gbiv@chromium.org>
Files:
- M
dev-lang/rust-bootstrap/Manifest
- A
dev-lang/rust-bootstrap/rust-bootstrap-1.84.1.ebuild
Hash: 8f7f449916a64f5c296b57c174d18bf5a5aae074
Date: Mon Feb 24 11:14:06 2025
ja...@google.com <ja...@google.com> #5
Project: chromiumos/overlays/chromiumos-overlay
Branch: firmware-android-15949.B
Author: George Burgess IV <
Link:
rust-bootstrap: land 1.84.1 Android Bringup: See
Expand for full commit details
rust-bootstrap: land 1.84.1
Android Bringup: See http://go/android-fw-sync
Starting on b/393504523 led to rust_uprev.py uploading the 1.84.1 src
tarball. Might as well have the SDK builder generate artifacts for this
before we need them.
BUG=b:398823143
TEST=sudo emerge rust-bootstrap:1.84.1
(cherry picked from commit 8f7f449916a64f5c296b57c174d18bf5a5aae074)
Change-Id: I5e42be00977dc147175ff7b478fad09b3da2b898
Original-Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/overlays/chromiumos-overlay/+/6299951
Original-Reviewed-by: Bob Haarman <inglorion@chromium.org>
Original-Commit-Queue: George Burgess <gbiv@chromium.org>
Original-Tested-by: George Burgess <gbiv@chromium.org>
GitOrigin-RevId: 8f7f449916a64f5c296b57c174d18bf5a5aae074
Cr-Build-Id: 8721817788610407729
Cr-Build-Url: https://cr-buildbucket.appspot.com/build/8721817788610407729
Copybot-Job-Name: android-main-chromiumos-overlay-copybot-downstream
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/overlays/chromiumos-overlay/+/6307951
Commit-Queue: ChromeOS Prod (Robot) <chromeos-ci-prod@chromeos-bot.iam.gserviceaccount.com>
Bot-Commit: ChromeOS Prod (Robot) <chromeos-ci-prod@chromeos-bot.iam.gserviceaccount.com>
Tested-by: ChromeOS Prod (Robot) <chromeos-ci-prod@chromeos-bot.iam.gserviceaccount.com>
Files:
- M
dev-lang/rust-bootstrap/Manifest
- A
dev-lang/rust-bootstrap/rust-bootstrap-1.84.1.ebuild
Hash: a88800da9da8ebef7ea5d0e2ee415482cdc4b02a
Date: Mon Feb 24 11:14:06 2025
ry...@google.com <ry...@google.com> #6
Reassigning this to Chris since I think he found a solid workaround. Chris please let me know if there's any way I can be of help for any longer term fixes here.
cd...@google.com <cd...@google.com> #7
Yeah, the work around involved using the replace directive to shorten the name when calling into the package. For something like the CTP module which changed from being located at dev-util/src/chromiumos/ctp to dev-util/src/go.chromium.org/chromiumos/ctp with the module name go.chromium.org/chromiumos/ctp, this required using:
replace go.chromium.org/chromiumos/ctp => go.chromium.org/chromiumos/platform/dev-util/src/go.chromium.org/chromiumos/ctp latest
.
I looked into using vanity URLs to rectify the pathing, but since that grabs the repository at its root, it expects modules to be named as path/to/module
starting from the repo.
While this workaround will enable devs to continue their work, it still does hinder the public viewing side of the package as go get
bl...@google.com <bl...@google.com> #8
Automated by Blunderbuss job chromeos-toolchain-blunderbuss for config chromeos_blunderbuss_config for component 1038090.
bl...@google.com <bl...@google.com> #9
(Attention: @cd...@google.com)
Automated by Blunderbuss job chromeos-toolchain-blunderbuss for config chromeos_blunderbuss_config for component 1038090.
bl...@google.com <bl...@google.com> #10
(Attention: @cd...@google.com)
Automated by Blunderbuss job chromeos-toolchain-blunderbuss for config chromeos_blunderbuss_config for component 1038090.
Description
cdelagarza@ noticed that changes he made to CTP are no longer propagating to the go module's public package .
This seems to be related tohttps://chromium-review.googlesource.com/c/chromiumos/platform/dev-util/+/5419374 which modified the directory for ctp as a part of the Golang Modules Migration.
It also appears that the
config/go
package is affected in the same way.