Compose compiler from Kotlin 2.0.0 breaks recomposition in some cases. [342089957]

Duplicate

of 340582180

Bug

Status Update

No update yet.

Description

to...@gmail.com

created issue #1

May 22, 2024 01:31PM

Jetpack Compose version: 1.7 snapshot Jetpack Compose component used: many Android Studio Build: Koala feature drop C2 Kotlin version: 2.0.0

The following code no more behave normally, changes to bottomSheetNavigator.openBottomSheet no more trigger a recomposition and the display of the bottomsheet.

See below for a working workaround by hosting the state outside of the remember.

import android.annotation.SuppressLint
import android.os.Build
import androidx.compose.foundation.layout.Spacer
import androidx.compose.foundation.layout.WindowInsets
import androidx.compose.foundation.layout.WindowInsetsSides
import androidx.compose.foundation.layout.height
import androidx.compose.foundation.layout.only
import androidx.compose.foundation.layout.systemBars
import androidx.compose.foundation.shape.RoundedCornerShape
import androidx.compose.material3.MaterialTheme
import androidx.compose.material3.contentColorFor
import androidx.compose.runtime.Composable
import androidx.compose.runtime.CompositionLocalProvider
import androidx.compose.runtime.LaunchedEffect
import androidx.compose.runtime.ProvidableCompositionLocal
import androidx.compose.runtime.getValue
import androidx.compose.runtime.mutableStateOf
import androidx.compose.runtime.remember
import androidx.compose.runtime.rememberCoroutineScope
import androidx.compose.runtime.setValue
import androidx.compose.runtime.staticCompositionLocalOf
import androidx.compose.ui.Modifier
import androidx.compose.ui.graphics.Color
import androidx.compose.ui.graphics.Shape
import androidx.compose.ui.platform.LocalConfiguration
import androidx.compose.ui.unit.dp
import cafe.adriel.voyager.core.annotation.InternalVoyagerApi
import cafe.adriel.voyager.core.screen.Screen
import cafe.adriel.voyager.core.stack.Stack
import cafe.adriel.voyager.navigator.CurrentScreen
import cafe.adriel.voyager.navigator.Navigator
import cafe.adriel.voyager.navigator.compositionUniqueId
import kotlinx.coroutines.CoroutineScope
import kotlinx.coroutines.launch

typealias BottomSheetNavigatorContent = @Composable (bottomSheetNavigator: BottomSheetNavigator) -> Unit

@SuppressLint("ComposeCompositionLocalUsage")
val LocalBottomSheetNavigator: ProvidableCompositionLocal<BottomSheetNavigator> =
    staticCompositionLocalOf { error("BottomSheetNavigator not initialized") }

@OptIn(InternalVoyagerApi::class)
@Composable
fun BottomSheetNavigator(
    modifier: Modifier = Modifier,
    key: String = compositionUniqueId(),
    scrimColor: Color = MaterialTheme.colorScheme.scrim.copy(alpha = 0.62f),
    sheetShape: Shape = RoundedCornerShape(topStart = 8.dp, topEnd = 8.dp, bottomEnd = 0.dp, bottomStart = 0.dp),
    sheetBackgroundColor: Color = MaterialTheme.colorScheme.surfaceContainerLowest,
    sheetContentColor: Color = contentColorFor(sheetBackgroundColor),
    sheetContent: BottomSheetNavigatorContent = { CurrentScreen() },
    content: @Composable (bottomSheetNavigator: BottomSheetNavigator) -> Unit,
) {
    val coroutineScope = rememberCoroutineScope()
    val sheetState = rememberModalBottomSheetState(skipPartiallyExpanded = true)

    Navigator(HiddenBottomSheetScreen, onBackPressed = null, key = key) { navigator ->
        val bottomSheetNavigator = remember(navigator, sheetState, coroutineScope) {
            BottomSheetNavigator(navigator, sheetState, coroutineScope)
        }

        LaunchedEffect(LocalConfiguration.current.orientation) {
            bottomSheetNavigator.hide()
        }

        CompositionLocalProvider(LocalBottomSheetNavigator provides bottomSheetNavigator) {
            if (bottomSheetNavigator.openBottomSheet) {
                ModalBottomSheet(
                    modifier = modifier,
                    scrimColor = scrimColor,
                    sheetState = sheetState,
                    containerColor = sheetBackgroundColor,
                    contentColor = sheetContentColor,
                    shape = sheetShape,
                    dragHandle = null,
                    windowInsets = if (Build.VERSION.SDK_INT < Build.VERSION_CODES.R) {
                        WindowInsets.systemBars.only(WindowInsetsSides.Vertical)
                    } else {
                        WindowInsets.systemBars.only(WindowInsetsSides.Top)
                    },
                    onDismissRequest = { bottomSheetNavigator.quickHide() },
                    content = {
                        bottomSheetNavigator.SaveableState("currentBottomSheet") {
                            sheetContent(bottomSheetNavigator)
                        }
                    },
                )
            }
            content(bottomSheetNavigator)
        }
    }
}

class BottomSheetNavigator internal constructor(
    private val navigator: Navigator,
    private val sheetState: SheetState,
    private val coroutineScope: CoroutineScope,
) : Stack<Screen> by navigator {

    var openBottomSheet by mutableStateOf(false)

    val isVisible: Boolean
        get() = sheetState.isVisible

    fun show(screen: Screen) {
        coroutineScope.launch {
            replaceAll(screen)
            openBottomSheet = true
        }
    }

    internal fun quickHide() {
        openBottomSheet = false
        replaceAll(HiddenBottomSheetScreen)
    }

    fun hide() {
        coroutineScope.launch {
            sheetState.hide()
            replaceAll(HiddenBottomSheetScreen)
            openBottomSheet = false
        }
    }

    @Composable
    fun SaveableState(
        key: String,
        content: @Composable () -> Unit,
    ) {
        navigator.saveableState(key, content = content)
    }
}

private object HiddenBottomSheetScreen : Screen {
    private fun readResolve(): Any = HiddenBottomSheetScreen

    @Composable
    override fun Content() {
        Spacer(modifier = Modifier.height(1.dp))
    }
}

Workaround


import android.annotation.SuppressLint
import android.os.Build
import androidx.compose.foundation.layout.Spacer
import androidx.compose.foundation.layout.WindowInsets
import androidx.compose.foundation.layout.WindowInsetsSides
import androidx.compose.foundation.layout.height
import androidx.compose.foundation.layout.only
import androidx.compose.foundation.layout.systemBars
import androidx.compose.foundation.shape.RoundedCornerShape
import androidx.compose.material3.MaterialTheme
import androidx.compose.material3.contentColorFor
import androidx.compose.runtime.Composable
import androidx.compose.runtime.CompositionLocalProvider
import androidx.compose.runtime.LaunchedEffect
import androidx.compose.runtime.ProvidableCompositionLocal
import androidx.compose.runtime.getValue
import androidx.compose.runtime.mutableStateOf
import androidx.compose.runtime.remember
import androidx.compose.runtime.rememberCoroutineScope
import androidx.compose.runtime.setValue
import androidx.compose.runtime.staticCompositionLocalOf
import androidx.compose.ui.Modifier
import androidx.compose.ui.graphics.Color
import androidx.compose.ui.graphics.Shape
import androidx.compose.ui.platform.LocalConfiguration
import androidx.compose.ui.unit.dp
import cafe.adriel.voyager.core.annotation.InternalVoyagerApi
import cafe.adriel.voyager.core.screen.Screen
import cafe.adriel.voyager.core.stack.Stack
import cafe.adriel.voyager.navigator.CurrentScreen
import cafe.adriel.voyager.navigator.Navigator
import cafe.adriel.voyager.navigator.compositionUniqueId
import kotlinx.coroutines.CoroutineScope
import kotlinx.coroutines.launch

typealias BottomSheetNavigatorContent = @Composable (bottomSheetNavigator: BottomSheetNavigator) -> Unit

@SuppressLint("ComposeCompositionLocalUsage")
val LocalBottomSheetNavigator: ProvidableCompositionLocal<BottomSheetNavigator> =
    staticCompositionLocalOf { error("BottomSheetNavigator not initialized") }

@OptIn(InternalVoyagerApi::class)
@Composable
fun BottomSheetNavigator(
    modifier: Modifier = Modifier,
    key: String = compositionUniqueId(),
    scrimColor: Color = MaterialTheme.colorScheme.scrim.copy(alpha = 0.62f),
    sheetShape: Shape = RoundedCornerShape(topStart = 8.dp, topEnd = 8.dp, bottomEnd = 0.dp, bottomStart = 0.dp),
    sheetBackgroundColor: Color = MaterialTheme.colorScheme.surfaceContainerLowest,
    sheetContentColor: Color = contentColorFor(sheetBackgroundColor),
    sheetContent: BottomSheetNavigatorContent = { CurrentScreen() },
    content: @Composable (bottomSheetNavigator: BottomSheetNavigator) -> Unit,
) {
    val coroutineScope = rememberCoroutineScope()
    val sheetState = rememberModalBottomSheetState(skipPartiallyExpanded = true)
    var openBottomSheet by remember { mutableStateOf(false) }
    Navigator(HiddenBottomSheetScreen, onBackPressed = null, key = key) { navigator ->
        val bottomSheetNavigator = remember(navigator, sheetState, coroutineScope) {
            BottomSheetNavigator(navigator, sheetState, coroutineScope, { openBottomSheet = true }, { openBottomSheet = false })
        }
        LaunchedEffect(LocalConfiguration.current.orientation) {
            bottomSheetNavigator.hide()
        }

        CompositionLocalProvider(LocalBottomSheetNavigator provides bottomSheetNavigator) {
            if (openBottomSheet) {
                ModalBottomSheet(
                    modifier = modifier,
                    scrimColor = scrimColor,
                    sheetState = sheetState,
                    containerColor = sheetBackgroundColor,
                    contentColor = sheetContentColor,
                    shape = sheetShape,
                    dragHandle = null,
                    windowInsets = if (Build.VERSION.SDK_INT < Build.VERSION_CODES.R) {
                        WindowInsets.systemBars.only(WindowInsetsSides.Vertical)
                    } else {
                        WindowInsets.systemBars.only(WindowInsetsSides.Top)
                    },
                    onDismissRequest = { bottomSheetNavigator.quickHide() },
                    content = {
                        bottomSheetNavigator.SaveableState("currentBottomSheet") {
                            sheetContent(bottomSheetNavigator)
                        }
                    },
                )
            }
            content(bottomSheetNavigator)
        }
    }
}

class BottomSheetNavigator internal constructor(
    private val navigator: Navigator,
    private val sheetState: SheetState,
    private val coroutineScope: CoroutineScope,
    private val open: () -> Unit,
    private val close: () -> Unit,
) : Stack<Screen> by navigator {

    val isVisible: Boolean
        get() = sheetState.isVisible

    fun show(screen: Screen) {
        coroutineScope.launch {
            replaceAll(screen)
            open()
        }
    }

    internal fun quickHide() {
        close()
        replaceAll(HiddenBottomSheetScreen)
    }

    fun hide() {
        coroutineScope.launch {
            sheetState.hide()
            replaceAll(HiddenBottomSheetScreen)
            close()
        }
    }

    @Composable
    fun SaveableState(
        key: String,
        content: @Composable () -> Unit,
    ) {
        navigator.saveableState(key, content = content)
    }
}

private object HiddenBottomSheetScreen : Screen {
    private fun readResolve(): Any = HiddenBottomSheetScreen

    @Composable
    override fun Content() {
        Spacer(modifier = Modifier.height(1.dp))
    }
}

Comments

sp...@gmail.com <sp...@gmail.com> #2May 24, 2024 01:03PM

Will this solve the problem?

val sheetState = rememberModalBottomSheetState(
    skipPartiallyExpanded = true,
    // manual lambda memoization
    confirmValueChange = remember {
        { true }
    }
)

If yes, then the problem may be related to https://issuetracker.google.com/issues/340582180

as...@google.com <as...@google.com> May 28, 2024 11:23AM

Status: Duplicate of

340582180

Issue 342089957

Description

Issue summary

Comments

sp...@gmail.com <sp...@gmail.com> #2May 24, 2024 01:03PM

as...@google.com <as...@google.com> May 28, 2024 11:23AM

Add comment

Issue metadata