Devise and implement a llvm-project patch workflow that tracks patches through GoB git branches [343568613]

Assigned

Project

Status Update

No update yet.

Description

aj...@google.com

created issue #1

May 30, 2024 02:05AM

At present, we keep track of patches solely through single metadata files called PATCHES.json. This has worked for quite a while, but as we've streamlined the patching process through -9999 Live ebuilds and patch-sync setup_for_workon.py, PATCHES.json gets updated at a rate that it's become tedious to rebase.

Even more frustrating, each llvm project must have its own PATCHES.json--if they are combined, PUPr ebuild uprevving does not know they are changed.

Through some internal discussion and feedback from the ChromeOS Build team, we think we can implement a solution which uses Chromium Git-on-Borg branches/tags (GoB).

Here's some prior discussion on the topic.

Comments

aj...@google.com <aj...@google.com> #2Jun 3, 2024 09:12PM

Much like b/374244552 and b/381493048, this is blocked on a new-enough LLVM

Bugjuggler: b/368393962; wait 2d -> gbiv

Message last modified on Jun 3, 2024 09:49PM

aj...@google.com <aj...@google.com> #3Jun 3, 2024 09:13PM

Hi. I've received your bug and will wait for

b/368393962

to be resolved, and then wait 2 days and then assign the bug to gbiv.

gb...@google.com <gb...@google.com> #4Jun 3, 2024 09:16PM

Project: chromiumos/overlays/chromiumos-overlay
Branch: main
Author: George Burgess IV <gbiv@google.com>
Link: https://chromium-review.googlesource.com/6299951

rust-bootstrap: land 1.84.1

Expand for full commit details

rust-bootstrap: land 1.84.1 
 
Starting on b/393504523 led to rust_uprev.py uploading the 1.84.1 src 
tarball. Might as well have the SDK builder generate artifacts for this 
before we need them. 
 
BUG=b:398823143 
TEST=sudo emerge rust-bootstrap:1.84.1 
 
Change-Id: I5e42be00977dc147175ff7b478fad09b3da2b898 
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/overlays/chromiumos-overlay/+/6299951 
Reviewed-by: Bob Haarman <inglorion@chromium.org> 
Commit-Queue: George Burgess <gbiv@chromium.org> 
Tested-by: George Burgess <gbiv@chromium.org>

Files:

M dev-lang/rust-bootstrap/Manifest
A dev-lang/rust-bootstrap/rust-bootstrap-1.84.1.ebuild

Hash: 8f7f449916a64f5c296b57c174d18bf5a5aae074
Date: Mon Feb 24 11:14:06 2025

aj...@google.com <aj...@google.com> #5Jun 3, 2024 09:21PM

Project: chromiumos/overlays/chromiumos-overlay
Branch: firmware-android-15949.B
Author: George Burgess IV <gbiv@google.com-copybot-pick>
Link: https://chromium-review.googlesource.com/6307951

rust-bootstrap: land 1.84.1 Android Bringup: See http://go/android-fw-sync

Expand for full commit details

rust-bootstrap: land 1.84.1 
Android Bringup: See http://go/android-fw-sync 
 
Starting on b/393504523 led to rust_uprev.py uploading the 1.84.1 src 
tarball. Might as well have the SDK builder generate artifacts for this 
before we need them. 
 
BUG=b:398823143 
TEST=sudo emerge rust-bootstrap:1.84.1 
 
(cherry picked from commit 8f7f449916a64f5c296b57c174d18bf5a5aae074) 
 
Change-Id: I5e42be00977dc147175ff7b478fad09b3da2b898 
Original-Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/overlays/chromiumos-overlay/+/6299951 
Original-Reviewed-by: Bob Haarman <inglorion@chromium.org> 
Original-Commit-Queue: George Burgess <gbiv@chromium.org> 
Original-Tested-by: George Burgess <gbiv@chromium.org> 
GitOrigin-RevId: 8f7f449916a64f5c296b57c174d18bf5a5aae074 
Cr-Build-Id: 8721817788610407729 
Cr-Build-Url: https://cr-buildbucket.appspot.com/build/8721817788610407729 
Copybot-Job-Name: android-main-chromiumos-overlay-copybot-downstream 
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/overlays/chromiumos-overlay/+/6307951 
Commit-Queue: ChromeOS Prod (Robot) <chromeos-ci-prod@chromeos-bot.iam.gserviceaccount.com> 
Bot-Commit: ChromeOS Prod (Robot) <chromeos-ci-prod@chromeos-bot.iam.gserviceaccount.com> 
Tested-by: ChromeOS Prod (Robot) <chromeos-ci-prod@chromeos-bot.iam.gserviceaccount.com>

Files:

M dev-lang/rust-bootstrap/Manifest
A dev-lang/rust-bootstrap/rust-bootstrap-1.84.1.ebuild

Hash: a88800da9da8ebef7ea5d0e2ee415482cdc4b02a
Date: Mon Feb 24 11:14:06 2025

Message last modified on Jun 3, 2024 09:22PM

ap...@google.com <ap...@google.com> #6Jun 3, 2024 11:19PM

[Details redacted due to bug visibility]

Change-Id: I11755088109ca0b4880162aac18f9dece2c1999b

https://chrome-internal-review.googlesource.com/7347408

ap...@google.com <ap...@google.com> #7Jun 7, 2024 09:14PM

Project: chromiumos/third_party/toolchain-utils
Branch: main

commit bb2278911caa6718078fefbfac04d9f69f089425
Author: Jordan R Abrahams-Whitehead <ajordanr@google.com>
Date: Thu Jun 06 00:06:56 2024

toolchain-utils: Add useful git utils to git_utils

This commit does 3 things:

1. Move git_format_patch from get_patch into git_utils,
as now "format_patch" (kept a wrapper for mocking).
2. Adds new git utilities to git_utils, such as
get_message_subject, get_commit_metadata, merge_base,
branch_list, and commits_between.
3. Adds some minor testing for git_utils_test.py

BUG=b:343568613
TEST=run_python_tests.py

Change-Id: Iabd8dd34b6db102877ad8571cb1a2c6b6df6f996
Reviewed-on:

https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/5602231
Tested-by: Jordan Abrahams-Whitehead <ajordanr@google.com>
Reviewed-by: George Burgess <gbiv@chromium.org>
Commit-Queue: Jordan Abrahams-Whitehead <ajordanr@google.com>

M cros_utils/git_utils.py
M cros_utils/git_utils_test.py
M llvm_tools/get_patch.py
M llvm_tools/get_patch_test.py

https://chromium-review.googlesource.com/5602231

ap...@google.com <ap...@google.com> #8Jun 12, 2024 09:08PM

Project: chromiumos/third_party/toolchain-utils
Branch: main

commit 5dbd8092cca4d22abe5106e487f7f780adefe254
Author: Jordan R Abrahams-Whitehead <ajordanr@google.com>
Date: Fri Jun 07 18:25:39 2024

llvm_tools: Add create_patch_file

This adds a new script which allows us to create
and edit a PATCHES.json file from LLVM commits
on ChromiumOS branches.

Additionally, this adds minor testing for the
new script.

BUG=b:343568613
TEST=py/bin/llvm_tools/create_patch_file.py \
--patch-dir ../chromiumos-overlay/sys-devel/llvm/files
TEST=run_python_tests.py

Change-Id: I1446fc56291c4b838af1e5c0632e6d72b1500742
Reviewed-on:

https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/5604057
Commit-Queue: Jordan Abrahams-Whitehead <ajordanr@google.com>
Tested-by: Jordan Abrahams-Whitehead <ajordanr@google.com>
Reviewed-by: George Burgess <gbiv@chromium.org>

A llvm_tools/create_patch_file.py
A llvm_tools/create_patch_file_test.py
A py/bin/llvm_tools/create_patch_file.py

https://chromium-review.googlesource.com/5604057

ap...@google.com <ap...@google.com> #9Jun 14, 2024 08:16PM

Project: chromiumos/third_party/toolchain-utils
Branch: main

commit caae51d4f788eca657d0cb4b3ebd0f7a1a4b6f7c
Author: Jordan R Abrahams-Whitehead <ajordanr@google.com>
Date: Mon Jun 10 21:25:05 2024

llvm_tools: chromiumos_apply for CrOS LLVM branches

With the new planned workflow for branch patches, we
need a mechanism to apply the patches with a set footer.
This footer should contain relevant information about the
patch, so that when it's represented inside PATCHES.json,
the values are accurate.

BUG=b:343568613
TEST=py/bin/llvm_tools/patch_manager.py \
--svn_version 516547 \
--patch_metadata_file \
$(realpath \
../chromiumos-overlay/sys-devel/llvm/files/PATCHES.json) \
--src_path ../llvm-project/

Change-Id: Iea3f5b359fef9cd6b27d5452b7abbe89206e282e
Reviewed-on:

https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/5617493
Tested-by: Jordan Abrahams-Whitehead <ajordanr@google.com>
Commit-Queue: Jordan Abrahams-Whitehead <ajordanr@google.com>
Reviewed-by: George Burgess <gbiv@chromium.org>

M llvm_tools/patch_manager.py
M llvm_tools/patch_utils.py

https://chromium-review.googlesource.com/5617493

ap...@google.com <ap...@google.com> #10Jun 14, 2024 09:02PM

Project: chromiumos/third_party/toolchain-utils
Branch: main

commit f358b3bffa1147322e3e299abc300d40f264aa96
Author: Jordan R Abrahams-Whitehead <ajordanr@google.com>
Date: Wed Jun 12 21:48:30 2024

llvm_tools: Strip Change-Id from commit messages

We don't want to store Change-Ids in the patch contents.
Strip them from the commits.

BUG=b:343568613
TEST=py/bin/llvm_tools/create_patch_file.py \
--patch-dir ../chromiumos-overlay/sys-devel/llvm/files
TEST=run_python_tests.py

Change-Id: I6793c251496589ccc3bb698357e1e2bbc13e48f0
Reviewed-on:

https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/5630705
Reviewed-by: Bob Haarman <inglorion@chromium.org>
Tested-by: Jordan Abrahams-Whitehead <ajordanr@google.com>
Reviewed-by: George Burgess <gbiv@chromium.org>
Commit-Queue: Jordan Abrahams-Whitehead <ajordanr@google.com>

M llvm_tools/create_patch_file.py
M llvm_tools/create_patch_file_test.py

https://chromium-review.googlesource.com/5630705

ap...@google.com <ap...@google.com> #11Jun 17, 2024 06:22PM

Project: chromiumos/overlays/chromiumos-overlay
Branch: main

commit 067f8282aada83736d623d64cbfb9276543e85cd
Author: Jordan R Abrahams-Whitehead <ajordanr@google.com>
Date: Fri Jun 14 23:53:05 2024

sys-devel: Restructure all patches for git am

The `git am` application process requires a fairly
strict patch format. The easiest way to get these patch
formats is through `git format-patch`. Additionally,
many patches are renamed to better match their autogenerated
format-patch names.

This commit also introduces the concept of "original_sha"
metadata entries.

We can always add metadata entries without worry, as they
are always preserved by our tooling by design--yet are
never required.

Many of these changes will be overwritten the next
time we run create_patch_file.py, but we need to get
the patches in a state that we can even apply them
as a series of commits.

BUG=b:343568613
TEST=./py/bin/llvm_tools/patch_manager.py \
--chromiumos_apply \
--src_path ../llvm-project/ \
--patch_metadata_file \
../chromiumos-overlay/sys-devel/llvm/files/PATCHES.json \
--svn_version 516547

Change-Id: I1a65b3d4a2cca78019d1fffb98619fd59d8b49a3
Reviewed-on:

https://chromium-review.googlesource.com/c/chromiumos/overlays/chromiumos-overlay/+/5634880
Tested-by: Jordan Abrahams-Whitehead <ajordanr@google.com>
Commit-Queue: Jordan Abrahams-Whitehead <ajordanr@google.com>
Reviewed-by: George Burgess <gbiv@chromium.org>

M sys-devel/llvm/files/Adds-a-allowlist-of-packages-that-have-known-memory-v5.patch
M sys-devel/llvm/files/BOLT-Increase-max-allocation-size-to-allow-BOLTing-clang-and-rustc.patch
M sys-devel/llvm/files/Disable-Cast-Assertion.patch
M sys-devel/llvm/files/Disable-vfork-fork-events.patch
M sys-devel/llvm/files/Ignore-inlinable-calls-if-unrolling-is-forced.patch
M sys-devel/llvm/files/PATCHES.json
M sys-devel/llvm/files/cherry/339faffd053b60bee3515fe7c4cca5e76f2cf427.patch
M sys-devel/llvm/files/cherry/7e34ee5291b935a1e37cd1b132552187d5c784d0.patch
M sys-devel/llvm/files/cherry/801c78d5b474c2319aa8ead44db7ba8cacac4714.patch
M sys-devel/llvm/files/cherry/955dd8800b4745784bf6da948ec7992d5b75b4d7.patch
M sys-devel/llvm/files/cherry/af2bf86a372cacf5f536bae06e2f2d3886eefb7b.patch
M sys-devel/llvm/files/cherry/ed86e740effaf1de540820a145a9df44eaf0df0e.patch
M sys-devel/llvm/files/cherry/f1ac559534788f8dd42191b60dfdf9cc56b39fd4.patch
M sys-devel/llvm/files/clang-12.0-asan-default-path.patch
M sys-devel/llvm/files/compiler-rt-un-unset-compiler_rt_build_crt.patch
M sys-devel/llvm/files/disable-querying-git-in-benchmarking-code.patch
M sys-devel/llvm/files/inline-cost-skip-threshold-checks.patch
M sys-devel/llvm/files/libcxx-crash-when-dereferencing-nullopt-v3.patch
M sys-devel/llvm/files/lld-10.0-invoke-name-v2.patch
M sys-devel/llvm/files/llvm-17.0-invocation.patch
M sys-devel/llvm/files/llvm-3.9-dwarf-version.patch
M sys-devel/llvm/files/llvm-8.0-clang-executable-detection.v2.patch
M sys-devel/llvm/files/scudo-Add-baseline-Scudo-config-for-ChromeOS-v2.patch

https://chromium-review.googlesource.com/5634880

ap...@google.com <ap...@google.com> #12Jun 18, 2024 11:23PM

Project: chromiumos/third_party/toolchain-utils
Branch: main

commit 95796977ec5bd5b3bec4764aab426b6dffae035a
Author: Jordan R Abrahams-Whitehead <ajordanr@google.com>
Date: Mon Jun 17 19:50:05 2024

llvm_tools: Fix writing to cherry/ subdirs

The parent of each atomic_write call must exist prior to calling
the atomic_write call. When testing, I found that this broke
when the cherry/ patch subdirectory didn't exist.

Not likely a problem in real-world usage, but it's a nice fix
for testing.

BUG=b:343568613
TEST=py/bin/llvm_tools/create_patch_file.py \
--patch-dir patches_test

Change-Id: I060c3c98c9651c6bbec7dde7150aeb076f6edab1
Reviewed-on:

https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/5636515
Reviewed-by: George Burgess <gbiv@chromium.org>
Tested-by: Jordan Abrahams-Whitehead <ajordanr@google.com>
Commit-Queue: Jordan Abrahams-Whitehead <ajordanr@google.com>

M llvm_tools/create_patch_file.py

https://chromium-review.googlesource.com/5636515

ap...@google.com <ap...@google.com> #13Jun 18, 2024 11:23PM

Project: chromiumos/third_party/toolchain-utils
Branch: main

commit ef5e5e51b24f7d6862165c87fa1fbb0827d92fba
Author: Jordan R Abrahams-Whitehead <ajordanr@google.com>
Date: Mon Jun 17 19:25:28 2024

llvm_tools: Add support for original_sha

The intent of original_sha is to preserve the upstream SHA
(or some other preserve-worthy SHA) in the commit metadata
info.

We are free to add entries to "metadata", as Patch Sync and
patch_utils always preserve metadata as closely as possible.

Also fix a bug where "from_rev" returned "null" as its default
instead of the intended "0".

Also fix a left over print statement for skipping Change-Id.

BUG=b:343568613
TEST=./run_python_tests.py
TEST=py/bin/llvm_tools/create_patch_file.py \
--patch-dir ../chromiumos-overlay/sys-devel/llvm/files

Change-Id: I9731a56592491e96f2390db7fc32f16ce224ba31
Reviewed-on:

https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/5635619
Reviewed-by: George Burgess <gbiv@chromium.org>
Tested-by: Jordan Abrahams-Whitehead <ajordanr@google.com>
Commit-Queue: Jordan Abrahams-Whitehead <ajordanr@google.com>

M llvm_tools/create_patch_file.py
M llvm_tools/get_patch.py
M llvm_tools/get_patch_test.py
M llvm_tools/patch_utils.py

https://chromium-review.googlesource.com/5635619

ap...@google.com <ap...@google.com> #14Jul 12, 2024 11:48PM

Project: chromiumos/third_party/toolchain-utils
Branch: main

commit c788c4080a389e3dcd915ca493dff5d93b1b9b0a
Author: Jordan R Abrahams-Whitehead <ajordanr@google.com>
Date: Mon Jul 08 19:30:14 2024

llvm_tools: Add llvm_project_base_commit.py lib

This library gives programs a quick way to make an LLVM-project
base commit for the new branching workflow.

BUG=b:343568613
TEST=Run python tests

Change-Id: I412f66b8d85b0aa0bbf2d7097bdbd27ab0e1d043
Reviewed-on:

https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/5685178
Commit-Queue: Jordan Abrahams-Whitehead <ajordanr@google.com>
Reviewed-by: George Burgess <gbiv@chromium.org>
Tested-by: Jordan Abrahams-Whitehead <ajordanr@google.com>

A llvm_tools/llvm_project_base_commit.py

https://chromium-review.googlesource.com/5685178

ap...@google.com <ap...@google.com> #15Jul 16, 2024 08:16PM

Project: chromiumos/third_party/toolchain-utils
Branch: main

commit ab7ba1c694472ed66ce589d8b9881fb4ce5d16be
Author: Jordan R Abrahams-Whitehead <ajordanr@google.com>
Date: Tue Jul 16 00:08:41 2024

llvm_tools: Fix typo in llvm_project_base_commit

We need to write to the README, not the directory. :)

BUG=b:343568613
TEST=./run_python_tests.py verify_patch_consistency_test.py

Change-Id: I30b156fbca9f84b64bcb80bed091b7e7ca30aa49
Reviewed-on:

https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/5710018
Tested-by: Jordan Abrahams-Whitehead <ajordanr@google.com>
Reviewed-by: George Burgess <gbiv@chromium.org>
Commit-Queue: Jordan Abrahams-Whitehead <ajordanr@google.com>

M llvm_tools/llvm_project_base_commit.py

https://chromium-review.googlesource.com/5710018

ap...@google.com <ap...@google.com> #16Jul 16, 2024 10:55PM

Project: chromiumos/third_party/toolchain-utils
Branch: main

commit df5d3350658cc6416b11ef5596cefa7713bc4284
Author: Jordan R Abrahams-Whitehead <ajordanr@google.com>
Date: Fri Jun 28 20:10:56 2024

llvm_tools: Add verify_patch_consistency.py

This adds a new script which will verify that a given
LLVM branch CL is identical to a the local patch state
generated from a given SVN revision.

Also add the git_am_chromiumos_quiet patch function
so that it doesn't spam the terminal with patch application
messages.

BUG=b:343568613
TEST=py/bin/llvm_tools/verify_patch_consistency.py --cl 5637483
TEST=run_python_tests.sh

Change-Id: Ia1764238e721812c1adc620a439b37a077004dd5
Reviewed-on:

https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/5668406
Reviewed-by: George Burgess <gbiv@chromium.org>
Tested-by: Jordan Abrahams-Whitehead <ajordanr@google.com>
Commit-Queue: Jordan Abrahams-Whitehead <ajordanr@google.com>

M cros_utils/git_utils.py
M llvm_tools/patch_utils.py
A llvm_tools/verify_patch_consistency.py
A llvm_tools/verify_patch_consistency_test.py
A py/bin/llvm_tools/verify_patch_consistency.py

https://chromium-review.googlesource.com/5668406

ap...@google.com <ap...@google.com> #17Jul 16, 2024 10:55PM

Project: chromiumos/third_party/toolchain-utils
Branch: main

commit 984d27e8544fa547ce9680def8dd1a659cc4e9c7
Author: Jordan R Abrahams-Whitehead <ajordanr@google.com>
Date: Mon Jul 08 19:34:14 2024

llvm_tools: Add ready_llvm_branch.py

This script creates an LLVM branch locally with the necessary patch
stack.

This is a really simple script that's basically just a patch_utils.py
wrapper--and is almost entirely a subset of patch_manager.py. But it
has more ergonomic CLI usage, so I thought it would be still nice to
add.

BUG=b:343568613
TEST=py/bin/llvm_tools/ready_llvm_branch.py \
-r 516547 --branch-number 2

Change-Id: I610b3989da47de004a5c9d8491ad6dfbb04c3ef8
Reviewed-on:

https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/5685179
Reviewed-by: George Burgess <gbiv@chromium.org>
Tested-by: Jordan Abrahams-Whitehead <ajordanr@google.com>
Commit-Queue: Jordan Abrahams-Whitehead <ajordanr@google.com>

M cros_utils/cros_paths.py
M cros_utils/git_utils.py
A llvm_tools/ready_llvm_branch.py
A py/bin/llvm_tools/ready_llvm_branch.py

https://chromium-review.googlesource.com/5685179

ap...@google.com <ap...@google.com> #18Jul 18, 2024 07:23PM

Project: chromiumos/third_party/toolchain-utils
Branch: main

commit 9213283d09be2e24439113496da9a432986fdb6c
Author: Jordan R Abrahams-Whitehead <ajordanr@google.com>
Date: Thu Jul 18 18:23:29 2024

llvm_tools: Minor bug fixes for git_llvm_rev

git_llvm_rev.translate_rev_to_sha is the better
library call here instead of GetGitHashFrom. Was
encountering a bug where the chosen svn_revision
didn't exist (or rather, only existed in the future),
and the logging here was unclear.

While testing, I noticed that want_rev was not
filling in, so fixed the formatting there too.

BUG=b:343568613
TEST=py/bin/llvm_tools/ready_llvm_branch.py -r516547
TEST=run_python_tests.sh

Change-Id: Id4ec590891a803be3d6d0ed16da9e86157feb274
Reviewed-on:

https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/5722828
Reviewed-by: George Burgess <gbiv@chromium.org>
Auto-Submit: Jordan Abrahams-Whitehead <ajordanr@google.com>
Tested-by: Jordan Abrahams-Whitehead <ajordanr@google.com>
Commit-Queue: George Burgess <gbiv@chromium.org>

M llvm_tools/git_llvm_rev.py
M llvm_tools/ready_llvm_branch.py

https://chromium-review.googlesource.com/5722828

ap...@google.com <ap...@google.com> #19Jul 22, 2024 06:49PM

Project: chromiumos/third_party/toolchain-utils
Branch: main

commit e2fbffceda26d0840d9e3702a152dab0561a1b35
Author: Jordan R Abrahams-Whitehead <ajordanr@google.com>
Date: Fri Jul 19 20:49:38 2024

toolchain-utils: Edit CMakeLists in Base Commit

setup_for_workon.py uses a CMakeLists.txt hack
to prevent cmake.eclass from editing the
source files directly.

Move the parts from setup_for_workon.py into
the llvm_project_base_commit library so
it can be shared across the scripts, and
update all the users.

BUG=b:343568613, b:354225301
TEST=run_python_tests.sh
TEST=Built llvm with cros workon enabled and eclass edits

Change-Id: I12720625614f2cec38ab8ea083028f2c02f3de25
Reviewed-on:

https://chromium-review.googlesource.com/c/chromiumos/third_party/toolchain-utils/+/5726923
Commit-Queue: Jordan Abrahams-Whitehead <ajordanr@google.com>
Tested-by: Jordan Abrahams-Whitehead <ajordanr@google.com>
Reviewed-by: George Burgess <gbiv@chromium.org>

M cros_utils/cros_paths.py
M llvm_tools/llvm_project_base_commit.py
M llvm_tools/ready_llvm_branch.py
M llvm_tools/setup_for_workon.py
M llvm_tools/verify_patch_consistency.py
M llvm_tools/verify_patch_consistency_test.py

https://chromium-review.googlesource.com/5726923

bl...@google.com <bl...@google.com> #20Oct 14, 2024 07:02PM

Hoi, ajordanr! You haven't added a comment to this issue in a while. Please do so!

Automated by Blunderbuss job chromeos-toolchain-blunderbuss for config chromeos_blunderbuss_config for component 1038090.

bl...@google.com <bl...@google.com> #21Jan 6, 2025 08:32PM

Hoi, ajordanr! You haven't added a comment to this issue in a while. Please do so!

(Attention: @aj...@google.com)

Automated by Blunderbuss job chromeos-toolchain-blunderbuss for config chromeos_blunderbuss_config for component 1038090.