Remove @DoNotInline usage, disable lint check [345472586]

Fixed

Feature Request

Status Update

No update yet.

Description

al...@google.com

created issue #1

Jun 6, 2024 04:37PM

R8 may double-outline platform NewApi calls when automatic outlining is enabled, so we should consider no-op'ing the @DoNotInline annotation when we're using an R8 version that does outlining.

Looping in from email,

The design for targeted rules is in go/targeted-shrinking-rules.

You can actually target R8 rules based on R8 version, so that's probably even better. I don't know where it's documented, but you can do: META-INF/com.android.tools/r8-upto-$VERSION/rules.pro

Comments

al...@google.com <al...@google.com> #2Jun 6, 2024 07:32PM

Hello,

Thank you for reaching out.

The Product team is working on this issue. This request has no ETA, but you can follow the progress in this thread.

sg...@google.com <sg...@google.com> #3Jun 7, 2024 06:54AM

Any updates on this? Fedora 35 uses python 3.10 and gcloud is broken on this OS currently.

al...@google.com <al...@google.com> #4Jun 10, 2024 02:51PM

Workaround for Fedora 35: Downgrade python 3 or add the following to .bashrc:

export CLOUDSDK_PYTHON=/usr/bin/python2

ag...@google.com <ag...@google.com> #5Jun 10, 2024 03:08PM

Better workaround for Fedora, install python 3.9 and use that instead of 2.7

https://developer.fedoraproject.org/tech/languages/python/multiple-pythons.html

al...@google.com <al...@google.com> #6Jun 10, 2024 04:07PM

It's fixed now on Fedora 35 with latest sdk

al...@google.com <al...@google.com> Jun 10, 2024 08:57PM

Accepted by al...@google.com.

al...@google.com <al...@google.com> #7Jun 11, 2024 04:30PM

Status: New

It's not. Google Cloud SDK still doesn't support Python 3.10 with the latest 366.0:

>gcloud
ERROR: gcloud failed to load: module 'collections' has no attribute 'Mapping'
gcloud_main = _import_gcloud_main()
import googlecloudsdk.gcloud_main
from googlecloudsdk.calliope import cli
from googlecloudsdk.calliope import actions
from googlecloudsdk.calliope import markdown
from googlecloudsdk.calliope import usage_text
from googlecloudsdk.calliope import parser_arguments
from googlecloudsdk.calliope import parser_completer
from googlecloudsdk.core.console import progress_tracker
class _BaseStagedProgressTracker(collections.Mapping):

al...@google.com <al...@google.com> Jul 2, 2024 02:50PM

Assigned to al...@google.com.

al...@google.com <al...@google.com> Jul 2, 2024 05:35PM

Accepted by al...@google.com.

ap...@google.com <ap...@google.com> #8Jul 8, 2024 05:41PM

Strange I don't have problem anymore with same version. I didn't set CLOUDSDK_PYTHON

ap...@google.com <ap...@google.com> #9Jul 8, 2024 07:31PM

It seems that is fixed in SDK 367.0.0

ap...@google.com <ap...@google.com> #10Jul 9, 2024 03:56PM

The fix is released with gcloud version 367.0.0 today. Please download latest gcloud version to work with Python 3.10.

al...@google.com <al...@google.com> #11Jul 9, 2024 04:37PM

Thanks. I can confirm that at least on Windows 10 using latest Python 3.10 from MS Store I'm now able to run gcloud SDK.

ap...@google.com <ap...@google.com> #12Jul 9, 2024 05:08PM

for some reason running gcloud on it's own still produces error (on Mac)

~ ❯ gcloud --version                                       
Google Cloud SDK 367.0.0
beta 2021.12.10
bq 2.0.72
core 2021.12.10
gsutil 5.5
~ ❯ gcloud                                                   
ERROR: (gcloud) Command name argument expected.
ERROR: gcloud crashed (CommandLoadFailure): Problem loading gcloud.events: module 'collections' has no attribute 'MutableMapping'.

If you would like to report this issue, please run the following command:
  gcloud feedback

To check gcloud for common problems, please run the following command:
  gcloud info --run-diagnostics

ap...@google.com <ap...@google.com> #13Jul 9, 2024 05:38PM

Hi i could not reproduce the issue. could you please try fresh download the latest gcloud?

$ export CLOUDSDK_PYTHON=/Library/Frameworks/Python.framework/Versions/3.10/bin/python3
$ gcloud --version
Google Cloud SDK 367.0.0
bq 2.0.72
core 2021.12.10
gsutil 5.5

ap...@google.com <ap...@google.com> #14Jul 10, 2024 04:05PM

I can. gcloud when used with any of parameters works fine. However without parameters it produces an error:

>gcloud --version
Google Cloud SDK 367.0.0
beta 2021.12.10
bq 2.0.72
core 2021.12.10
gsutil 5.5
kubectl 1.20.8

>gcloud projects list
PROJECT_ID NAME PROJECT_NUMBER
xxxxxxxxxxxx XXXXXXXXXXXXX 1234556789

>gcloud
ERROR: (gcloud) Command name argument expected.
ERROR: gcloud crashed (CommandLoadFailure): Problem loading gcloud.events: module 'collections' has no attribute 'MutableMapping'.

al...@google.com <al...@google.com> #15Jul 10, 2024 05:48PM

Assigned to bu...@google.com.

Thanks. I can reproduce it. We will work on a fix.

bu...@google.com <bu...@google.com> #16Jul 10, 2024 05:53PM

Accepted by bu...@google.com.

i can confirm - gcloud with parameters doesn't work.

Version: 367.0.0
Python: 3.10

ap...@google.com <ap...@google.com> #17Jul 18, 2024 03:34PM

HI Coco,

I see another bug related to this and it says it fixed, is that true?

https://buganizer.corp.google.com/issues/202258405

Thanks!

bu...@google.com <bu...@google.com> Jul 23, 2024 02:34PM

Assigned to al...@google.com.

al...@google.com <al...@google.com> #18Jul 29, 2024 02:25PM

Marked as fixed.

vinwong@ https://buganizer.corp.google.com/issues/202258405 is fixed.

pr...@google.com <pr...@google.com> #19Aug 13, 2024 06:58PM

thanks cocosheng@

So, just want to verify one last thing, so is GCP SDK now fully support Python 3.10? I just want to make sure it is before I tell the customer, thanks!

Vincent

na...@google.com <na...@google.com> #20Aug 21, 2024 07:55PM

for now, running gcloud without any parameters still throws an error.

pr...@google.com <pr...@google.com> #21Sep 5, 2024 08:09PM

I'm still getting the error when I try to deploy to App Engine Flexible using the `gloud app deploy` command. As a temporary workaround, I've set the SDK to use Python 3.9.

na...@google.com <na...@google.com> #22Sep 18, 2024 05:37PM

vinwong@ we don't have full support for python 3.10 yet.

pr...@google.com <pr...@google.com> #23Oct 2, 2024 05:37PM

Thanks! Do we have any ETA on when it might have a solution that will make the SDK fully support using Python 3.10? Just want to set the customer's expectation, thanks!

na...@google.com <na...@google.com> #24Oct 16, 2024 05:48PM

Thanks for your patience. Our product team confirmed that the issue has been fixed. Can you please check from your end of everything is okay?

na...@google.com <na...@google.com> #25Nov 13, 2024 06:19PM

Can you confirm which version this is fixed in?

pr...@google.com <pr...@google.com> #26Dec 11, 2024 06:27PM

It should work fine with python 3.10.

na...@google.com <na...@google.com> #27Jan 29, 2025 06:11PM

It doesn't. As mentioned previously gcloud SDK 367.0 still fails when running gcloud without parameters. It also fails if running gcloud with *incorrect* parameter set. For example:

>gcloud set project my-project
ERROR: gcloud failed to load (gcloud.interactive): Problem loading gcloud.interactive: cannot import name 'Mapping' from 'collections'

pr...@google.com <pr...@google.com> #28Feb 12, 2025 06:40PM

This is still occurring with Fedora 35 after updating to 368.0.0

na...@google.com <na...@google.com> #29Mar 12, 2025 06:13PM

After updating my SDK to the latest version, the issue got resolved. Can you please try reinstalling the SDK if it doesn't solve the issue?

This issue tracker is a channel for reporting issues and requesting new features.

The issue you described looks like a technical issue and for troubleshooting, it would be best for you to contact the GCP support or to use the Community support.