IssueTracker

I tried to build with the following *FLAGS to optimize the build: -flto=4 -Werror=odr -Werror=lto-type-mismatch -Werror=strict-aliasing

Note the -Werror=* flags are used to help detect cases where the compiler tries to optimize by assuming UB cannot exist in the source code -- if it does exist, ordinarily the code would be miscompiled, and this says to make the miscompilation a fatal error.

I got this error:

ninja -v -j8 -k0
[1/3] cd /var/tmp/portage/dev-util/android-tools-35.0.1/work/android-tools-35.0.1_build/vendor && /usr/bin/cmake -E create_symlink /usr/share/android-tools/mkbootimg/mkbootimg.py /var/tmp/portage/dev-util/android-tools-35.0.1/work/android-tools-35.0.1_build/vendor/mkbootimg
[2/3] : && /usr/bin/x86_64-pc-linux-gnu-g++ -pipe -march=native -fstack-protector-all -O2 -fdiagnostics-color=always -frecord-gcc-switches -flto=4 -Werror=odr -Werror=lto-type-mismatch -Werror=strict-aliasing -Werror=lto-type-mismatch  -Wformat -Werror=format-security -ftrivial-auto-var-init=zero -Wl,-O1 -Wl,--as-needed -Wl,-z,pack-relative-relocs -flto=4 -Werror=odr -Werror=lto-type-mismatch -Werror=strict-aliasing -Werror=lto-type-mismatch -Wl,--defsym=__gentoo_check_ldflags__=0 vendor/CMakeFiles/make_f2fs.dir/f2fs-tools/lib/libf2fs_io.c.o vendor/CMakeFiles/make_f2fs.dir/f2fs-tools/mkfs/f2fs_format_main.c.o -o vendor/make_f2fs  vendor/liblibf2fs.a  vendor/liblibsparse.a  -lz  vendor/liblibext2_uuid.a  vendor/liblibbase.a  vendor/fmtlib/libfmt.a  vendor/libliblog.a && :
FAILED: vendor/make_f2fs 
: && /usr/bin/x86_64-pc-linux-gnu-g++ -pipe -march=native -fstack-protector-all -O2 -fdiagnostics-color=always -frecord-gcc-switches -flto=4 -Werror=odr -Werror=lto-type-mismatch -Werror=strict-aliasing -Werror=lto-type-mismatch  -Wformat -Werror=format-security -ftrivial-auto-var-init=zero -Wl,-O1 -Wl,--as-needed -Wl,-z,pack-relative-relocs -flto=4 -Werror=odr -Werror=lto-type-mismatch -Werror=strict-aliasing -Werror=lto-type-mismatch -Wl,--defsym=__gentoo_check_ldflags__=0 vendor/CMakeFiles/make_f2fs.dir/f2fs-tools/lib/libf2fs_io.c.o vendor/CMakeFiles/make_f2fs.dir/f2fs-tools/mkfs/f2fs_format_main.c.o -o vendor/make_f2fs  vendor/liblibf2fs.a  vendor/liblibsparse.a  -lz  vendor/liblibext2_uuid.a  vendor/liblibbase.a  vendor/fmtlib/libfmt.a  vendor/libliblog.a && :
/var/tmp/portage/dev-util/android-tools-35.0.1/work/android-tools-35.0.1/vendor/f2fs-tools/include/f2fs_fs.h:1641:34: error: type of ‘c’ does not match original declaration [-Werror=lto-type-mismatch]
 1641 | extern struct f2fs_configuration c;
      |                                  ^
/var/tmp/portage/dev-util/android-tools-35.0.1/work/android-tools-35.0.1/vendor/f2fs-tools/lib/libf2fs_io.c:42:27: note: ‘c’ was previously declared here
   42 | struct f2fs_configuration c;
      |                           ^
/var/tmp/portage/dev-util/android-tools-35.0.1/work/android-tools-35.0.1/vendor/f2fs-tools/lib/libf2fs_io.c:42:27: note: code may be misoptimized unless ‘-fno-strict-aliasing’ is used
lto1: some warnings being treated as errors
lto-wrapper: fatal error: /usr/bin/x86_64-pc-linux-gnu-g++ returned 1 exit status
compilation terminated.
/usr/lib/gcc/x86_64-pc-linux-gnu/13/../../../../x86_64-pc-linux-gnu/bin/ld: error: lto-wrapper failed
collect2: error: ld returned 1 exit status
[3/3] : && /usr/bin/x86_64-pc-linux-gnu-g++ -pipe -march=native -fstack-protector-all -O2 -fdiagnostics-color=always -frecord-gcc-switches -flto=4 -Werror=odr -Werror=lto-type-mismatch -Werror=strict-aliasing -Werror=lto-type-mismatch  -Wformat -Werror=format-security -ftrivial-auto-var-init=zero -Wl,-O1 -Wl,--as-needed -Wl,-z,pack-relative-relocs -flto=4 -Werror=odr -Werror=lto-type-mismatch -Werror=strict-aliasing -Werror=lto-type-mismatch -Wl,--defsym=__gentoo_check_ldflags__=0 vendor/CMakeFiles/adb.dir/adb/adb.cpp.o vendor/CMakeFiles/adb.dir/adb/adb_io.cpp.o vendor/CMakeFiles/adb.dir/adb/adb_listeners.cpp.o vendor/CMakeFiles/adb.dir/adb/adb_trace.cpp.o vendor/CMakeFiles/adb.dir/adb/adb_unique_fd.cpp.o vendor/CMakeFiles/adb.dir/adb/adb_utils.cpp.o vendor/CMakeFiles/adb.dir/adb/fdevent/fdevent.cpp.o vendor/CMakeFiles/adb.dir/adb/fdevent/fdevent_poll.cpp.o vendor/CMakeFiles/adb.dir/adb/fdevent/fdevent_epoll.cpp.o vendor/CMakeFiles/adb.dir/adb/shell_service_protocol.cpp.o vendor/CMakeFiles/adb.dir/adb/sockets.cpp.o vendor/CMakeFiles/adb.dir/adb/socket_spec.cpp.o vendor/CMakeFiles/adb.dir/adb/transport.cpp.o vendor/CMakeFiles/adb.dir/adb/transport_fd.cpp.o vendor/CMakeFiles/adb.dir/adb/client/transport_local.cpp.o vendor/CMakeFiles/adb.dir/adb/client/transport_usb.cpp.o vendor/CMakeFiles/adb.dir/adb/types.cpp.o -o vendor/adb  vendor/liblibadb.a  vendor/liblibadb_crypto_defaults.a  vendor/liblibadb_tls_connection_defaults.a  vendor/liblibbase.a  vendor/liblibcrypto.a  vendor/liblibadb_sysdeps.a  vendor/liblibcutils.a  vendor/liblibdiagnoseusb.a  vendor/libliblog.a  vendor/liblibzip.a  vendor/boringssl/crypto/libcrypto.a  vendor/boringssl/ssl/libssl.a  /usr/lib64/libprotobuf.so.22.5.0  -lz  vendor/fmtlib/libfmt.a  vendor/boringssl/crypto/libcrypto.a  /usr/lib64/libabsl_log_internal_check_op.so.2301.0.0  /usr/lib64/libabsl_leak_check.so.2301.0.0  /usr/lib64/libabsl_die_if_null.so.2301.0.0  /usr/lib64/libabsl_log_internal_conditions.so.2301.0.0  /usr/lib64/libabsl_log_internal_message.so.2301.0.0  /usr/lib64/libabsl_log_internal_nullguard.so.2301.0.0  /usr/lib64/libabsl_examine_stack.so.2301.0.0  /usr/lib64/libabsl_log_internal_format.so.2301.0.0  /usr/lib64/libabsl_log_internal_proto.so.2301.0.0  /usr/lib64/libabsl_log_internal_log_sink_set.so.2301.0.0  /usr/lib64/libabsl_log_sink.so.2301.0.0  /usr/lib64/libabsl_log_entry.so.2301.0.0  /usr/lib64/libabsl_flags.so.2301.0.0  /usr/lib64/libabsl_flags_internal.so.2301.0.0  /usr/lib64/libabsl_flags_marshalling.so.2301.0.0  /usr/lib64/libabsl_flags_reflection.so.2301.0.0  /usr/lib64/libabsl_flags_config.so.2301.0.0  /usr/lib64/libabsl_flags_program_name.so.2301.0.0  /usr/lib64/libabsl_flags_private_handle_accessor.so.2301.0.0  /usr/lib64/libabsl_flags_commandlineflag.so.2301.0.0  /usr/lib64/libabsl_flags_commandlineflag_internal.so.2301.0.0  /usr/lib64/libabsl_log_initialize.so.2301.0.0  /usr/lib64/libabsl_log_globals.so.2301.0.0  /usr/lib64/libabsl_log_internal_globals.so.2301.0.0  /usr/lib64/libabsl_hash.so.2301.0.0  /usr/lib64/libabsl_city.so.2301.0.0  /usr/lib64/libabsl_low_level_hash.so.2301.0.0  /usr/lib64/libabsl_raw_hash_set.so.2301.0.0  /usr/lib64/libabsl_hashtablez_sampler.so.2301.0.0  /usr/lib64/libabsl_statusor.so.2301.0.0  /usr/lib64/libabsl_status.so.2301.0.0  /usr/lib64/libabsl_cord.so.2301.0.0  /usr/lib64/libabsl_cordz_info.so.2301.0.0  /usr/lib64/libabsl_cord_internal.so.2301.0.0  /usr/lib64/libabsl_cordz_functions.so.2301.0.0  /usr/lib64/libabsl_exponential_biased.so.2301.0.0  /usr/lib64/libabsl_cordz_handle.so.2301.0.0  /usr/lib64/libabsl_crc_cord_state.so.2301.0.0  /usr/lib64/libabsl_crc32c.so.2301.0.0  /usr/lib64/libabsl_crc_internal.so.2301.0.0  /usr/lib64/libabsl_crc_cpu_detect.so.2301.0.0  /usr/lib64/libabsl_bad_optional_access.so.2301.0.0  /usr/lib64/libabsl_str_format_internal.so.2301.0.0  /usr/lib64/libabsl_strerror.so.2301.0.0  /usr/lib64/libabsl_synchronization.so.2301.0.0  /usr/lib64/libabsl_stacktrace.so.2301.0.0  /usr/lib64/libabsl_symbolize.so.2301.0.0  /usr/lib64/libabsl_debugging_internal.so.2301.0.0  /usr/lib64/libabsl_demangle_internal.so.2301.0.0  /usr/lib64/libabsl_graphcycles_internal.so.2301.0.0  /usr/lib64/libabsl_malloc_internal.so.2301.0.0  /usr/lib64/libabsl_time.so.2301.0.0  /usr/lib64/libabsl_strings.so.2301.0.0  /usr/lib64/libabsl_throw_delegate.so.2301.0.0  /usr/lib64/libabsl_strings_internal.so.2301.0.0  /usr/lib64/libabsl_base.so.2301.0.0  /usr/lib64/libabsl_spinlock_wait.so.2301.0.0  /usr/lib64/libabsl_int128.so.2301.0.0  /usr/lib64/libabsl_civil_time.so.2301.0.0  /usr/lib64/libabsl_time_zone.so.2301.0.0  /usr/lib64/libabsl_bad_variant_access.so.2301.0.0  /usr/lib64/libabsl_raw_logging_internal.so.2301.0.0  /usr/lib64/libabsl_log_severity.so.2301.0.0  /usr/lib64/libbrotlicommon.so  /usr/lib64/libbrotlidec.so  /usr/lib64/libbrotlienc.so  /usr/lib64/liblz4.so  /usr/lib64/libusb-1.0.so  /usr/lib64/libzstd.so && :
FAILED: vendor/adb 
: && /usr/bin/x86_64-pc-linux-gnu-g++ -pipe -march=native -fstack-protector-all -O2 -fdiagnostics-color=always -frecord-gcc-switches -flto=4 -Werror=odr -Werror=lto-type-mismatch -Werror=strict-aliasing -Werror=lto-type-mismatch  -Wformat -Werror=format-security -ftrivial-auto-var-init=zero -Wl,-O1 -Wl,--as-needed -Wl,-z,pack-relative-relocs -flto=4 -Werror=odr -Werror=lto-type-mismatch -Werror=strict-aliasing -Werror=lto-type-mismatch -Wl,--defsym=__gentoo_check_ldflags__=0 vendor/CMakeFiles/adb.dir/adb/adb.cpp.o vendor/CMakeFiles/adb.dir/adb/adb_io.cpp.o vendor/CMakeFiles/adb.dir/adb/adb_listeners.cpp.o vendor/CMakeFiles/adb.dir/adb/adb_trace.cpp.o vendor/CMakeFiles/adb.dir/adb/adb_unique_fd.cpp.o vendor/CMakeFiles/adb.dir/adb/adb_utils.cpp.o vendor/CMakeFiles/adb.dir/adb/fdevent/fdevent.cpp.o vendor/CMakeFiles/adb.dir/adb/fdevent/fdevent_poll.cpp.o vendor/CMakeFiles/adb.dir/adb/fdevent/fdevent_epoll.cpp.o vendor/CMakeFiles/adb.dir/adb/shell_service_protocol.cpp.o vendor/CMakeFiles/adb.dir/adb/sockets.cpp.o vendor/CMakeFiles/adb.dir/adb/socket_spec.cpp.o vendor/CMakeFiles/adb.dir/adb/transport.cpp.o vendor/CMakeFiles/adb.dir/adb/transport_fd.cpp.o vendor/CMakeFiles/adb.dir/adb/client/transport_local.cpp.o vendor/CMakeFiles/adb.dir/adb/client/transport_usb.cpp.o vendor/CMakeFiles/adb.dir/adb/types.cpp.o -o vendor/adb  vendor/liblibadb.a  vendor/liblibadb_crypto_defaults.a  vendor/liblibadb_tls_connection_defaults.a  vendor/liblibbase.a  vendor/liblibcrypto.a  vendor/liblibadb_sysdeps.a  vendor/liblibcutils.a  vendor/liblibdiagnoseusb.a  vendor/libliblog.a  vendor/liblibzip.a  vendor/boringssl/crypto/libcrypto.a  vendor/boringssl/ssl/libssl.a  /usr/lib64/libprotobuf.so.22.5.0  -lz  vendor/fmtlib/libfmt.a  vendor/boringssl/crypto/libcrypto.a  /usr/lib64/libabsl_log_internal_check_op.so.2301.0.0  /usr/lib64/libabsl_leak_check.so.2301.0.0  /usr/lib64/libabsl_die_if_null.so.2301.0.0  /usr/lib64/libabsl_log_internal_conditions.so.2301.0.0  /usr/lib64/libabsl_log_internal_message.so.2301.0.0  /usr/lib64/libabsl_log_internal_nullguard.so.2301.0.0  /usr/lib64/libabsl_examine_stack.so.2301.0.0  /usr/lib64/libabsl_log_internal_format.so.2301.0.0  /usr/lib64/libabsl_log_internal_proto.so.2301.0.0  /usr/lib64/libabsl_log_internal_log_sink_set.so.2301.0.0  /usr/lib64/libabsl_log_sink.so.2301.0.0  /usr/lib64/libabsl_log_entry.so.2301.0.0  /usr/lib64/libabsl_flags.so.2301.0.0  /usr/lib64/libabsl_flags_internal.so.2301.0.0  /usr/lib64/libabsl_flags_marshalling.so.2301.0.0  /usr/lib64/libabsl_flags_reflection.so.2301.0.0  /usr/lib64/libabsl_flags_config.so.2301.0.0  /usr/lib64/libabsl_flags_program_name.so.2301.0.0  /usr/lib64/libabsl_flags_private_handle_accessor.so.2301.0.0  /usr/lib64/libabsl_flags_commandlineflag.so.2301.0.0  /usr/lib64/libabsl_flags_commandlineflag_internal.so.2301.0.0  /usr/lib64/libabsl_log_initialize.so.2301.0.0  /usr/lib64/libabsl_log_globals.so.2301.0.0  /usr/lib64/libabsl_log_internal_globals.so.2301.0.0  /usr/lib64/libabsl_hash.so.2301.0.0  /usr/lib64/libabsl_city.so.2301.0.0  /usr/lib64/libabsl_low_level_hash.so.2301.0.0  /usr/lib64/libabsl_raw_hash_set.so.2301.0.0  /usr/lib64/libabsl_hashtablez_sampler.so.2301.0.0  /usr/lib64/libabsl_statusor.so.2301.0.0  /usr/lib64/libabsl_status.so.2301.0.0  /usr/lib64/libabsl_cord.so.2301.0.0  /usr/lib64/libabsl_cordz_info.so.2301.0.0  /usr/lib64/libabsl_cord_internal.so.2301.0.0  /usr/lib64/libabsl_cordz_functions.so.2301.0.0  /usr/lib64/libabsl_exponential_biased.so.2301.0.0  /usr/lib64/libabsl_cordz_handle.so.2301.0.0  /usr/lib64/libabsl_crc_cord_state.so.2301.0.0  /usr/lib64/libabsl_crc32c.so.2301.0.0  /usr/lib64/libabsl_crc_internal.so.2301.0.0  /usr/lib64/libabsl_crc_cpu_detect.so.2301.0.0  /usr/lib64/libabsl_bad_optional_access.so.2301.0.0  /usr/lib64/libabsl_str_format_internal.so.2301.0.0  /usr/lib64/libabsl_strerror.so.2301.0.0  /usr/lib64/libabsl_synchronization.so.2301.0.0  /usr/lib64/libabsl_stacktrace.so.2301.0.0  /usr/lib64/libabsl_symbolize.so.2301.0.0  /usr/lib64/libabsl_debugging_internal.so.2301.0.0  /usr/lib64/libabsl_demangle_internal.so.2301.0.0  /usr/lib64/libabsl_graphcycles_internal.so.2301.0.0  /usr/lib64/libabsl_malloc_internal.so.2301.0.0  /usr/lib64/libabsl_time.so.2301.0.0  /usr/lib64/libabsl_strings.so.2301.0.0  /usr/lib64/libabsl_throw_delegate.so.2301.0.0  /usr/lib64/libabsl_strings_internal.so.2301.0.0  /usr/lib64/libabsl_base.so.2301.0.0  /usr/lib64/libabsl_spinlock_wait.so.2301.0.0  /usr/lib64/libabsl_int128.so.2301.0.0  /usr/lib64/libabsl_civil_time.so.2301.0.0  /usr/lib64/libabsl_time_zone.so.2301.0.0  /usr/lib64/libabsl_bad_variant_access.so.2301.0.0  /usr/lib64/libabsl_raw_logging_internal.so.2301.0.0  /usr/lib64/libabsl_log_severity.so.2301.0.0  /usr/lib64/libbrotlicommon.so  /usr/lib64/libbrotlidec.so  /usr/lib64/libbrotlienc.so  /usr/lib64/liblz4.so  /usr/lib64/libusb-1.0.so  /usr/lib64/libzstd.so && :
/var/tmp/portage/dev-util/android-tools-35.0.1/work/android-tools-35.0.1/vendor/adb/socket.h:58:8: error: type ‘struct asocket’ violates the C++ One Definition Rule [-Werror=odr]
   58 | struct asocket {
      |        ^
/var/tmp/portage/dev-util/android-tools-35.0.1/work/android-tools-35.0.1/vendor/adb/socket.h:58:8: note: a different type is defined in another translation unit
   58 | struct asocket {
      |        ^
/var/tmp/portage/dev-util/android-tools-35.0.1/work/android-tools-35.0.1/vendor/adb/socket.h:103:12: note: the first difference of corresponding definitions is field ‘____xxx_shutdown’
  103 |     void (*shutdown)(asocket* s) = nullptr;
      |            ^
/var/tmp/portage/dev-util/android-tools-35.0.1/work/android-tools-35.0.1/vendor/adb/socket.h:103:12: note: a field with different name is defined in another translation unit
  103 |     void (*shutdown)(asocket* s) = nullptr;
      |            ^
/var/tmp/portage/dev-util/android-tools-35.0.1/work/android-tools-35.0.1/vendor/adb/transfer_id.h:22:12: error: type ‘TransferDirection’ violates the C++ One Definition Rule [-Werror=odr]
   22 | enum class TransferDirection : uint64_t {
      |            ^
/var/tmp/portage/dev-util/android-tools-35.0.1/work/android-tools-35.0.1/vendor/adb/client/file_sync_client.cpp:107:12: note: a type with different precision is defined in another translation unit
  107 | enum class TransferDirection {
      |            ^
/var/tmp/portage/dev-util/android-tools-35.0.1/work/android-tools-35.0.1/vendor/adb/transfer_id.h:22:12: error: type ‘TransferDirection’ violates the C++ One Definition Rule [-Werror=odr]
   22 | enum class TransferDirection : uint64_t {
      |            ^
/var/tmp/portage/dev-util/android-tools-35.0.1/work/android-tools-35.0.1/vendor/adb/client/file_sync_client.cpp:107:12: note: an enum with different value name is defined in another translation unit
  107 | enum class TransferDirection {
      |            ^
/var/tmp/portage/dev-util/android-tools-35.0.1/work/android-tools-35.0.1/vendor/adb/transfer_id.h:23:5: note: name ‘READ’ differs from name ‘push’ defined in another translation unit
   23 |     READ = 0,
      |     ^
/var/tmp/portage/dev-util/android-tools-35.0.1/work/android-tools-35.0.1/vendor/adb/client/file_sync_client.cpp:108:5: note: mismatching definition
  108 |     push,
      |     ^
lto1: some warnings being treated as errors
lto-wrapper: fatal error: /usr/bin/x86_64-pc-linux-gnu-g++ returned 1 exit status
compilation terminated.
/usr/lib/gcc/x86_64-pc-linux-gnu/13/../../../../x86_64-pc-linux-gnu/bin/ld: error: lto-wrapper failed
collect2: error: ld returned 1 exit status
ninja: build stopped: cannot make progress due to previous errors.

Attached is a full build log. There are tracking issues downstream at:

• (adb) https://bugs.gentoo.org/858311
• (f2fs-tools) https://bugs.gentoo.org/863896

There are two different issues here:

• the vendored f2fs-tools code has an LTO bug. Unfortunately, even though I sent an email to the f2fs-tools development mailing list I got no response and appear to have been automoderated due to sourceforge. Maybe someone else will have better luck than I did...

• the adb code itself has two violations of the C++ One Definition Rule (probably easy to fix by renaming them to be unique)