IssueTracker

Original crosstool bug: b/323944113

A recent upstream change breaks instances of allocating containers which take a constant type argument. These containers are:

• vector
• deque
• forward_list
• list
• set
• map
• multiset
• multimap
• unordered_set
• unordered_map
• unorded_multiset
• unordered_multimap

To give an example of an invalid type:

std::vector<const int>  // Undefined behaviour

This will likely be a big problem for future us. In first party code, we guess a total of 140 instances of this. We don't know how many are in 3rd party code.

We can enable _LIBCPP_ENABLE_CXX20_REMOVED_ALLOCATOR_MEMBERS to delay the inevitable, but eventually we need to fix this.

It's possible we can automate a lot of these away, but we do need to be careful.