Change theme
Help
Press space for more information.
Show links for this issue (Shortcut: i, l)
Copy issue ID
Previous Issue (Shortcut: k)
Next Issue (Shortcut: j)
Sign in to use full features.
Vote: I am impacted
Notification menu
Refresh (Shortcut: Shift+r)
Go home (Shortcut: u)
Pending code changes (auto-populated)
Maintained by go/gitwatcher - Please do not modify manually. [ID: 762704]
Maintained by go/gitwatcher - Please do not modify manually. [ID: 762733]
Which product in the toolchain? (clang, Rust, Go, GDB..) [ID: 834766]
View issue level access limits(Press Alt + Right arrow for more information)
Unintended behavior
View staffing
Description
Original crosstool bug: b/323944113
A recent upstream change breaks instances of allocating containers which take a constant type argument. These containers are:
To give an example of an invalid type:
This will likely be a big problem for future us. In first party code, we guess a total of 140 instances of this. We don't know how many are in 3rd party code.
We can enable
_LIBCPP_ENABLE_CXX20_REMOVED_ALLOCATOR_MEMBERS
to delay the inevitable, but eventually we need to fix this.It's possible we can automate a lot of these away, but we do need to be careful.