Change theme
Help
Press space for more information.
Show links for this issue (Shortcut: i, l)
Copy issue ID
Previous Issue (Shortcut: k)
Next Issue (Shortcut: j)
Sign in to use full features.
Vote: I am impacted
Notification menu
Refresh (Shortcut: Shift+r)
Go home (Shortcut: u)
Pending code changes (auto-populated)
Needs more info comment that > 10 days [ID: 963198]
Comment such as: SPAM, non-actionable [ID: 963127]
Resolved actionable follow-up comments [ID: 963027]
View issue level access limits(Press Alt + Right arrow for more information)
Attachment actions
Request for new functionality
View staffing
Description
What would you like to see us add to this API?
The test
instanceof HTMLElement
fails on Google AMP websites because AMP does not support it. Any AMP site that uses Google Maps will break when Google pulls v3.55 (scheduled for the end of October) because of this issue. The issue is that the map infoWindow does not open. It fails silently because when the code tests that the infoWindow close button is aninstanceof HTMLElement
and only falls back to testinginstanceof SVGElement
. If you added another fallback to testinstanceof HTMLButtonElement
then it would not break on AMP sites.What part of the API (please specify, a library, or the code module)?
The problem code can be found in the script returned byhttps://maps.googleapis.com/maps/api/js
Please describe how the feature should work:
Add a fallback to allow
instanceof HTMLButtonElement
to pass. See attached screenshots.Please give a use case or explain where and why you need this feature:
We have high profile medical sites that run Google AMP and Google Maps. Although AMP is deprecated, it still provides desirable speed optimizations, and it is still widely in use. A simple fallback for this
HTMLElement
test should allow the infoWindow to open, and this could save the Google Maps integration with these sites. Otherwise we will have to remove Google AMP or switch to another map service. The second option is less overhead for our teams.