R8 not properly checking for file type [358041218]

Assigned

Feature Request

Status Update

No update yet.

Description

oh...@gmail.com

created issue #1

Aug 7, 2024 02:36PM

R8 primarily supports class files and archives, as seen here: https://r8.googlesource.com/r8/+/refs/heads/main/src/main/java/com/android/tools/r8/utils/FileUtils.java#68

The issue is that it only checks for the extension instead of their magic number. If a valid archive is not named after an archive extension, R8 will not process the file.

Archives such as ZIP, JAR, and co have a magic number as specified in the spec sheet (0x04034b50): https://pkwaredownloads.blob.core.windows.net/pkware-general/Documentation/APPNOTE-6.3.9.TXT
DEX files have the magic number dex\n039\0 as specified in: https://source.android.com/docs/core/runtime/dex-format#dex-file-magic
Class files have 0xCAFEBABE: https://en.wikipedia.org/wiki/Java_class_file#:~:text=Magic%20Number%3A%200xCAFEBABE,versions%20of%20the%20class%20file

Source files do not have any magic number and would need to be checked for their extension.

An alternative solution to this issue is to add a parameter to specify or override the type of the file to process manually.

Comments

sg...@google.com <sg...@google.com> #2Aug 8, 2024 06:15AM

Reassigned to sg...@google.com.

Can you share idea.log file if this issue reproduces again.

oh...@gmail.com <oh...@gmail.com> #3Aug 8, 2024 11:31AM

Here is the log file.

sg...@google.com <sg...@google.com> #4Aug 8, 2024 12:06PM

When I open the viewEditor Preview Window, it always show!

oh...@gmail.com <oh...@gmail.com> #5Aug 8, 2024 03:16PM

Raluca: I believe this is a known IJ bug. Have we merged the fix yet?

ri...@google.com <ri...@google.com> #6Aug 8, 2024 04:16PM

I cherry-picked the fix for

https://youtrack.jetbrains.com/issue/IDEA-186452 into 3.2, it seems small enough and related to floating tool windows.

On the other hand,

https://youtrack.jetbrains.com/issue/IDEA-189629 seems to affect 2018.2 EAP, and I'm not sure whether we'll have a fix to cherry-pick in time for 3.2.

Issue 358041218